Fixes a bug in the certificate PUCM process #2560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rProfile.IntIP does not exist
mhsreddy
requested review from
bennerv,
cadenmarchese,
cblecker,
darthhexx,
facchettos,
hawkowl,
jewzaam,
jharrington22,
m1kola,
petrkotas and
rogbas
as code owners
mhsreddy
force-pushed
the
fixing-mcscert-adminupdate
branch
from
3fe4f94 to
68121cc
Compare
darthhexx
approved these changes
Nov 28, 2022
darthhexx
added
next-release
s-amann
reviewed
Nov 28, 2022
|
|
||
| if isEverything || isRenewCerts { | ||
| toRun = append(toRun, | ||
| steps.Action(m.populateDatabaseIntIP), |
Contributor
There was a problem hiding this comment.
nit: can this additional step be moved down to within the condition on line 85 where we check the same isEverything || isRenewCerts?
s-amann
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
"Fixes a bug in the certificate PUCM process that does not take into account clusters that have not been successfully PUCM'ed since a large infra change PR was merged in Feb 2021".
Previous ADO Card for Certificate PUCM : https://msazure.visualstudio.com/AzureRedHatOpenShift/_workitems/edit/15581636/
What this PR does / why we need it:
"Fixes a bug in the certificate PUCM process that does not take into account clusters that have not been successfully PUCM'ed since a large infra change PR was merged in Feb 2021". At present fixMCSCert step failing as it could not find the Properties.APIServerProfile.IntIP entry in the Cluster Document.
Test plan for issue:
Create Test Cluster without the Properties.APIServerProfile.IntIP entry in the Cluster Document and run the Certificate PUCM and it will create a new entry for Properties.APIServerProfile.IntIP and update the Cluster Document in Cosmos DB.
CURL Command to perform Admin Update just for certificates renewal:
curl -X PATCH -k "https://localhost:8443/subscriptions/$AZURE_SUBSCRIPTION_ID/resourceGroups/$RESOURCEGROUP/providers/Microsoft.RedHatOpenShift/openShiftClusters/$CLUSTER?api-version=admin" --header "Content-Type: application/json" -d '{"properties":{"maintenanceTask": "CertificatesRenewal"}}'
Is there any documentation that needs to be updated for this PR?