Skip to content

e2e keyvault tests shared environment #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
m1kola merged 1 commit into from
Nov 2, 2021
Merged

e2e keyvault tests shared environment #1793

m1kola merged 1 commit into from
Nov 2, 2021

Conversation

@rolandmkunkel
Copy link
Contributor

@rolandmkunkel rolandmkunkel commented Oct 15, 2021 •
edited
Loading

Which issue this PR addresses:

First part of:
https://msazure.visualstudio.com/AzureRedHatOpenShift/_workitems/edit/7404076

What this PR does / why we need it:

This adds a shared keyvault, key, and disk encryption set to the shared environment in order to enable disk encryption tests for local cluster deployments.

Test plan for issue:

  • Deploying shared environment to a new resource group
  • running e2e tests

Is there any documentation that needs to be updated for this PR?

No

@rolandmkunkel rolandmkunkel marked this pull request as draft October 15, 2021 14:15
@mwoodson
Copy link
Contributor

mwoodson commented Oct 15, 2021

I noticed the API date bump. I'm not super familiar with the API dates/version in Azure. Is anything needed to test with this bump?

@github-actions github-actions bot added the needs-rebase branch needs a rebase label Oct 15, 2021
@github-actions
Copy link

github-actions bot commented Oct 15, 2021

Please rebase pull request.

@rolandmkunkel rolandmkunkel force-pushed the disc-encryption-e2e-tests-shared-env branch from 62a2586 to d50f26b Compare October 29, 2021 07:36
@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Oct 29, 2021
m1kola
m1kola reviewed Oct 29, 2021
View reviewed changes
@rolandmkunkel rolandmkunkel force-pushed the disc-encryption-e2e-tests-shared-env branch 2 times, most recently from d735007 to 47dd9b8 Compare October 29, 2021 14:55
@rolandmkunkel rolandmkunkel marked this pull request as ready for review October 29, 2021 15:58
m1kola
m1kola reviewed Oct 29, 2021
View reviewed changes
Copy link
Contributor

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Few minor things and we can merge, IMO.

@rolandmkunkel rolandmkunkel force-pushed the disc-encryption-e2e-tests-shared-env branch from 47dd9b8 to a25c479 Compare November 1, 2021 07:09
@rolandmkunkel rolandmkunkel mentioned this pull request Nov 1, 2021
Merged
m1kola
m1kola previously approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one more place with cardcoded API version + one question.

I'm happy to merge as is and have a small follow up PR to address these remaining things as they are not critical. Or have it fixed in this one. Let me know what you prefer.

@rolandmkunkel rolandmkunkel force-pushed the disc-encryption-e2e-tests-shared-env branch from a25c479 to 9b66405 Compare November 1, 2021 14:40
@rolandmkunkel rolandmkunkel force-pushed the disc-encryption-e2e-tests-shared-env branch from 9b66405 to 5a94f02 Compare November 1, 2021 15:47
m1kola
m1kola approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's merge once CI is green. Great job!

@m1kola
Copy link
Contributor

m1kola commented Nov 2, 2021

Going to merge now as jobs are green.

I noticed the API date bump. I'm not super familiar with the API dates/version in Azure. Is anything needed to test with this bump?

I think this should be covered by e2es.

@m1kola m1kola merged commit 13671eb into Azure:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@hawkowl hawkowl Awaiting requested review from hawkowl hawkowl is a code owner

@jewzaam jewzaam Awaiting requested review from jewzaam

@mjudeikis mjudeikis Awaiting requested review from mjudeikis

@mwoodson mwoodson Awaiting requested review from mwoodson

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

1 more reviewer

@m1kola m1kola m1kola approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rolandmkunkel @mwoodson @m1kola