Skip to content

Conversation

@m1kola
Copy link
Contributor

@m1kola m1kola commented Jul 19, 2021

What this PR does / why we need it:

#1615 got merged too early: I did not address the feedback about unused argument. This PR addresses #1615 (comment)

Copy link
Contributor

@troy0820 troy0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Removed subscriptionID from NewServicePrincipalChecker from feedback in #1615

LGTM

@troy0820 troy0820 added LGTM Looks Good To Me priority-low Low priority issue or pull request size-small Size small labels Jul 19, 2021
@troy0820
Copy link
Contributor

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jewzaam jewzaam merged commit 3e1a4f8 into Azure:master Jul 21, 2021
@m1kola m1kola deleted the 1615_followup branch July 22, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM Looks Good To Me priority-low Low priority issue or pull request size-small Size small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants