Expose DNS conditions on the ARO Operator #1277
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troy0820
commented
Jan 26, 2021
troy0820
force-pushed
the
feat/dns-vnet-operator
branch
3 times, most recently
from
ef7165b to
9130d46
Compare
troy0820
force-pushed
the
feat/dns-vnet-operator
branch
2 times, most recently
from
b2ea0d2 to
7f93d45
Compare
troy0820
requested review from
jim-minter,
mjudeikis and
olga-mir
as code owners
troy0820
force-pushed
the
feat/dns-vnet-operator
branch
from
28a86e5 to
64616dc
Compare
|
Please rebase pull request. |
troy0820
force-pushed
the
feat/dns-vnet-operator
branch
from
64616dc to
2d8bdfa
Compare
github-actions
bot
added
needs-rebase
|
Please rebase pull request. |
jim-minter
suggested changes
Feb 10, 2021
Member
jim-minter
left a comment
jim-minter
left a comment
There was a problem hiding this comment.
Please hold this PR while we work out whether #1296 can get rid of the DNS problem at source.
Member
Contributor
Author
|
@jim-minter We can close this. If there are any other conditions that are necessary for the operator to add, I can make another branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes 8858773
What this PR does / why we need it:
Places conditions of the DNS servers (custom DNS) on the ARO operator
Test plan for issue:
E2E test will be performed to check all conditions on cluster create. This is being done on PR #1273
Is there any documentation that needs to be updated for this PR?
No documentation. The conditions are appended to the conditions that exist with the operator which include
MachineValid, InternetReachableFromMaster, InternetReachableFromWorkerand nowDNSValid