refactor dynamic validator to be operator compatible #1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennerv
requested review from
jim-minter,
mjudeikis and
olga-mir
as code owners
bennerv
changed the title
bennerv
force-pushed
the
validator.split
branch
from
0ffb4fa to
5e8551d
Compare
mjudeikis
approved these changes
Dec 19, 2020
Contributor
|
/azp run e2e |
Contributor
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
jim-minter
pushed a commit
to jim-minter/ARO-RP
that referenced
this pull request
Jan 7, 2021
bennerv
pushed a commit
to bennerv/ARO-RP
that referenced
this pull request
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #1232 with changes suggested by @ihcsim in this comment
Which issue this PR addresses:
Fixes our ability to consume dynamic validation in context of Cluster/Operator.
Suggestion for #1230
What this PR does / why we need it:
Introduced 2 flavors of dynamic validator:
Full - all validators. Intended to run in the context of RP.
Slim - Validators intended to be running in the context of Operator.
It would need more refactoring so could consume the data from the validator. But might be good start.
Test plan for issue:
unit tests
Is there any documentation that needs to be updated for this PR?
no