Skip to content

test: skip 5.0 candidate install until HCCO ingress fix lands - #6163

Merged
openshift-merge-bot[bot] merged 1 commit into
Azure:mainfrom
zgalor:test-cs-topology-skip-50
Jul 21, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
Azure:mainfrom
zgalor:test-cs-topology-skip-50

Conversation

@zgalor

@zgalor Zohar Galor (zgalor) commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Skip the 5.0 candidate install e2e test until a 5.0 EC build includes the HCCO ingress LB scope fix (OCPBUGS-98571)
  • The fix (openshift/hypershift#8992) merged to HyperShift main on 2026-07-14, but 5.0.0-ec.4 (built 2026-07-03) does not include it
  • When CS sets topology=PublicAndPrivate on Swift clusters (ARO-26913), the HCCO creates an IngressController with InternalLoadBalancer scope, causing *.apps routes to point to an unreachable internal LB IP (10.0.0.5) instead of the shared ingress public IP
  • 4.22 is covered by the CPO override in openshift/hypershift#9010
  • Uses time-bomb pattern: skips before 2026-08-10, fails after — ensuring the skip doesn't persist silently once the fix should be available (5.0.0-ec.5 expected ~July 27)

Test plan

  • Verify the skip follows existing time-bomb patterns (nodepool_ephemeral_osdisk.go, cluster_create_private_ingress.go)
  • e2e-parallel CI passes with the 5.0 test skipped

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR temporarily disables the 5.0 candidate install path in the multi-version E2E install suite due to a known HyperShift HCCO ingress load balancer scoping bug that breaks *.apps route reachability under PublicAndPrivate topology.

Changes:

  • Add a targeted Skip() for the 5.0 entry in the multi-version install DescribeTable.
  • Document the rationale inline with links to the tracked bug and relevant upstream PR timing/build context.

Comment on lines +75 to +77
if version == "5.0" {
Skip("5.0 candidate releases do not yet include the HCCO ingress LB scope fix (https://issues.redhat.com/browse/OCPBUGS-98571)")
}
OCPBUGS-98571: HyperShift HCCO forces InternalLoadBalancer scope for
PublicAndPrivate topology on ARO HCP, causing *.apps routes to be
unreachable. The fix (openshift/hypershift#8992) merged to main on
2026-07-14 but 5.0.0-ec.4 (built 2026-07-03) does not include it.
Skip the 5.0 candidate install test until an EC build with the fix
is available in the candidate channel.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 20, 2026 09:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

test/e2e/complete_cluster_create_multiversion.go:80

  • The 5.0 skip is currently time-based only and triggers regardless of channel group. This can keep the test skipped even after a fixed 5.0 EC lands (before the deadline), and it may also skip unexpectedly if the channel group is overridden to something other than candidate (the skip message specifically says "candidate releases"). Consider scoping the skip to the candidate channel and skipping only while the resolved install version is older than the first known fixed EC build, while keeping the deadline as a time bomb.
			if version == "5.0" {
				timeBombDeadline := time.Date(2026, time.August, 10, 0, 0, 0, 0, time.UTC)
				if time.Now().Before(timeBombDeadline) {
					Skip(fmt.Sprintf("5.0 candidate releases do not yet include the HCCO ingress LB scope fix (https://issues.redhat.com/browse/OCPBUGS-98571); skipping until %s", timeBombDeadline.Format(time.RFC3339)))
				}

@zgalor

Copy link
Copy Markdown
Collaborator Author

Miquel Simon (@miquelsi) Patrik Suba (@patriksuba), this is required to unblock the merging of private KAS support into CS. PTAL

@zgalor

Copy link
Copy Markdown
Collaborator Author

Ben Vesel (@bennerv) PTAL as well

@miquelsi

Copy link
Copy Markdown
Collaborator

/approve

@miquelsi

Copy link
Copy Markdown
Collaborator

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: miquelsi, zgalor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zgalor

Copy link
Copy Markdown
Collaborator Author

/test e2e-parallel

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9a8c6da and 2 for PR HEAD 9b24f82 in total

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0b1697a and 1 for PR HEAD 9b24f82 in total

@zgalor

Copy link
Copy Markdown
Collaborator Author

/retest-required

@openshift-merge-bot
openshift-merge-bot Bot merged commit d276595 into Azure:main Jul 21, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants