fix(observability): add https:// scheme to nodepool alert runbook_url - #6055
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates nodepool SLO alert rule annotations to include an explicit https:// scheme in runbook_url, aligning the alert output with runbook URL rendering requirements and regenerating the corresponding Azure Monitor rule group Bicep.
Changes:
- Prefixed all nodepool SLO alert
runbook_urlannotations withhttps://. - Updated promtool rule test expectations to match the new
runbook_urlvalues. - Regenerated the Azure Monitor Prometheus rule group Bicep output to reflect the updated annotations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| observability/alerts/nodepool-slo-prometheusRule.yaml | Updates nodepool alert runbook_url annotations to include https://. |
| observability/alerts/nodepool-slo-prometheusRule_test.yaml | Updates promtool expected annotations for runbook_url. |
| dev-infrastructure/modules/metrics/rules/generatedRPPrometheusAlertingRules.bicep | Regenerated alerting rules output to include updated nodepool runbook_url annotations. |
839b6ea to
be70ada
Compare
The ADR requires runbook_url annotations use the https:// scheme. Without it, the IcM connector may not render the link as clickable. Regenerated bicep included (generator also normalized whitespace).
be70ada to
74611de
Compare
Brendan Bergen (SudoBrendan)
left a comment
Brendan Bergen (SudoBrendan)
left a comment
There was a problem hiding this comment.
/lgtm
/approve
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SudoBrendan, swiencki, venkateshsredhat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ARO-28396
What
Adds the
https://scheme prefix to allrunbook_urlannotations in the node pool SLO alert rules.Why
The alerting ADR requires
runbook_urlannotations use thehttps://scheme. Without it, the IcM connector may not render the link as clickable in the incident ticket.Testing
Promtool rule tests pass. Regenerated bicep included.