Update cincinatti interaction to use maestro for clusterID - #5045
Merged
Merged
Conversation
openshift-ci
Bot
requested review from
Gerd Oberlechner (geoberle) and
Matthew Barnes (mbarnes)
April 27, 2026 17:21
This disconnects cluster-service from another piece of our controllers. We should consider a backup flow that uses an value when missing and see if we can supply the value to cluster-service and generate it ourselves.
David Eads (deads2k)
force-pushed
the
cs-159-refine-cluster-uid
branch
from
April 28, 2026 13:59
4c2a7c4 to
3d9d7f8
Compare
Manyanda Chitimbo (machi1990)
approved these changes
Apr 28, 2026
Manyanda Chitimbo (machi1990)
left a comment
Manyanda Chitimbo (machi1990)
left a comment
Collaborator
There was a problem hiding this comment.
/lgtm
I left a comment in the cluster desired version controller about using a default UUID one for the case of install when we move the cluster creation call to the backend, that will be handled in the dedicated PR by Jakob Gray (@JakobGray)
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, machi1990 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disconnects cluster-service from another piece of our controllers.
We should consider a backup flow that uses an value when missing and see if we can supply the value to cluster-service and generate it ourselves.
Addresses the first cause of the nodepoolversion controller retry in https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/Azure_ARO-HCP/5020/pull-ci-Azure-ARO-HCP-main-e2e-parallel/2048471908730540032