test(e2e): use workload identity webhook label instead of manual injection - #4627
Merged
Conversation
…ction Now that the Azure workload identity webhook is available as a KAS sidecar (CNTRLPLANE-2910), use the `azure.workload.identity/use` pod label so the webhook automatically injects the required env vars, volume, and volume mount. Remove the manual configuration that was serving as a workaround. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ailability Dev and INT environments have the webhook deployed, so they use the label-based injection. Higher environments (stg, prod) fall back to manual injection of env vars and volumes until April 1st 2026, after which all environments are expected to have the webhook.
openshift-ci
Bot
requested review from
David Eads (deads2k) and
Mike Gahagan (mgahagan73)
March 25, 2026 11:45
Collaborator
|
/lgtm replaces 4515 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bennerv, geoberle The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use the
azure.workload.identity/usepod label in the OIDC workload identity e2e test so the webhook automatically injects the required env vars, volume, and volume mount. Remove the manual configuration that was serving as a workaround.Until Apr 1st (or sooner if we want to remove it before that), keep the manual injection in stage and prod.
Why
The Azure workload identity webhook is now available as a KAS sidecar (CNTRLPLANE-2910), so the manual env var, volume, and volume mount injection is no longer needed. This resolves the TODOs left in the test.
Special notes for your reviewer
The
az logincommand in the pod still references$AZURE_CLIENT_ID,$AZURE_TENANT_ID, and$AZURE_FEDERATED_TOKEN_FILE— these are now expected to be injected by the webhook rather than set manually.