align frontend cluster CRUD to use internal types#3379
Merged
Conversation
deads2k
requested review from
DennisJWheeler,
Nanyte25,
SudoBrendan,
avollmer-redhat,
bennerv,
geoberle,
hbhushan3,
katherinelc321,
kostola,
mbarnes,
mociarain,
oriAdler,
raelga,
sclarkso,
tsatam and
venkateshsredhat
as code owners
|
Please rebase pull request. |
deads2k
force-pushed
the
cs-50-model-replace
branch
from
286578c to
0568993
Compare
deads2k
force-pushed
the
cs-50-model-replace
branch
from
0568993 to
6460fa4
Compare
deads2k
requested review from
janboll,
jharrington22,
jonathan34c,
mbukatov,
mgahagan73,
miquelsi,
patriksuba,
weinong and
whober0521
as code owners
deads2k
requested review from
mmazur,
roivaz,
stevekuznetsov,
tony-schndr,
trevorwilliams2025 and
weherdh
as code owners
deads2k
changed the title
deads2k
force-pushed
the
cs-50-model-replace
branch
from
6460fa4 to
83dc42e
Compare
This refacts the frontend for clusters to be internal API only. That means that the first step to using data from anywhere else is to get it into an internal type. Then take action based on that and the last step is the convert to external for serialization.
deads2k
force-pushed
the
cs-50-model-replace
branch
from
83dc42e to
83001f8
Compare
|
@deads2k: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
mbarnes
approved these changes
Dec 2, 2025
This was referenced Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our decoding strategy results in vastly different newObjs for patch versus put. Currently, this means that validation won't pass on the patched version. When we have actual content in cosmos we have a couple choices for patch.
Currently the patching code doesn't appear clear fields when the client desires it because the merge doesn't start with an original to clear. I'm thinking 2 will be better.
However, the error handling is driving me batty, so I'm going to try to fix that first.