capture definitionReferenceId that starts with number. #324
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
We (slz engineering team) found an issue in alz's invoke-policyToBicep.ps1. This script doesn't support any definitionReferenceId that starts with number. E.g. We have a policySet definitions that pulled from azure built-in policy, the definitionReferenceId is like '10006169408036501401'. The invoke-policyToBicep.ps1 generates _policySetDefintionsBicepInput.txt like this.

It uses
.10006169408036501401
to reference an object which is illegals for neither json nor bicep. The invoke-policyToBicep.ps1 somehow missed to handle this case.This PR fixes/adds/changes/removes
$definitionReferenceIdForParameters -match '^[0-9].+'
Breaking Changes
N/A
Testing Evidence
with this pr, we can see the result diff in the output of the invoke-PolicyToBicep.ps1

As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch