Sample for managing resources via MSI Identity#1
Sample for managing resources via MSI Identity#1vishrutshah merged 5 commits intoAzure-Samples:masterfrom vishrutshah:sample
Conversation
Gemfile
Outdated
| gem 'vcr', '~>3.0' | ||
| end | ||
|
|
||
| gem 'ms_rest_azure', path: 'C:\Users\vishrut\repo\azure-sdk-for-ruby\runtime\ms_rest_azure' |
There was a problem hiding this comment.
remove the dependency after releasing on 08/28 :)
veronicagg
left a comment
veronicagg
left a comment
There was a problem hiding this comment.
Looks good, you may want to add some sentences for each section where you explain the sample, if there's something you think it's worth adding. Thanks!
| ### Create an Azure Vault | ||
|
|
||
| ```ruby | ||
| puts 'Creating key vault account with MSI Identity...' |
There was a problem hiding this comment.
is there anything special on the key vault account creation related to MSI Identity, or is it just the fact that's created under the ResourceGroup that was created with MSITokenProvider? If so, it may be worth commenting on it.
| @@ -0,0 +1,8 @@ | |||
| # This is a sample of what your .env file should look like if you wanted to run integration tests. | |||
There was a problem hiding this comment.
nit: This is a sample of your .env file to run integration tests.
| @@ -0,0 +1,8 @@ | |||
| # This is a sample of what your .env file should look like if you wanted to run integration tests. | |||
| # If you move this file to the .env and replace the environment variables with your own values, then the environment | |||
| # will be included when the rake test tasks are executed. Otherwise, you could just export the environment vars | |||
There was a problem hiding this comment.
nit:Otherwise, you could just export the environment variables manually
| <a id="run"></a> | ||
| ## Run this sample | ||
|
|
||
| 1. log in to the above Azure virtual machine which has MSI service running and then follow the steps on that VM. |
There was a problem hiding this comment.
All steps are marked with 1.
There was a problem hiding this comment.
hahah thanks for catching..updated
README.md
Outdated
| git clone https://github.com/Azure-Samples/resources-ruby-manage-resources-with-msi.git | ||
| ``` | ||
|
|
||
| 1. Install the dependencies using bundle. |
README.md
Outdated
| ``` | ||
|
|
||
| <a id="example"></a> | ||
| ## What is example.rb doing? |
There was a problem hiding this comment.
nit:What does example.rb do?
|
@sarangan12 @veronicagg Let me know if you have any more comments. Thanks! |
veronicagg
left a comment
veronicagg
left a comment
There was a problem hiding this comment.
Looks good, just minor comment inline.
.env_sample
Outdated
| @@ -1,7 +1,7 @@ | |||
| # This is a sample of what your .env file should look like if you wanted to run integration tests. | |||
| # This is a sample of what your .env file to run integration tests. | |||
There was a problem hiding this comment.
something seems odd with this sentence, not sure what you meant to change it to.
There was a problem hiding this comment.
:( now I read it and wonder as well..I'll keep it as-is as that seems structured
|
Thanks for the review!! |
vishrutshah
changed the title
3 participants
Related to Azure/azure-sdk-for-ruby#885