Skip to content

Align namespaces with simplification performed in Barretenberg #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maddiaa0 merged 1 commit into from
Feb 12, 2024
Merged

Align namespaces with simplification performed in Barretenberg #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions bberg/src/circuit_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ impl CircuitBuilder for BBFiles {
};
let check_lookup_transformation = |lookup_name: &String| {
format!(
"if (!evaluate_logderivative.template operator()<honk::{lookup_name}_relation<FF>>(\"{lookup_name}\")) {{
"if (!evaluate_logderivative.template operator()<{lookup_name}_relation<FF>>(\"{lookup_name}\")) {{
return false;
}}"
)
Expand Down Expand Up @@ -117,8 +117,6 @@ impl CircuitBuilder for BBFiles {
let circuit_hpp = format!("
{includes}

using namespace bb;

namespace bb {{

{row_with_all_included};
Expand Down Expand Up @@ -204,7 +202,7 @@ fn get_lookup_check_closure() -> String {
const auto evaluate_logderivative = [&]<typename LogDerivativeSettings>(const std::string& lookup_name) {

// Check the logderivative relation
bb::logderivative_library::compute_logderivative_inverse<
bb::compute_logderivative_inverse<
Flavor,
LogDerivativeSettings>(
polys, params, num_rows);
Expand Down
2 changes: 1 addition & 1 deletion bberg/src/lookup_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ fn create_lookup_settings_file(lookup: &Lookup) -> String {
"
{lookup_settings_includes}

namespace bb::sumcheck {{
namespace bb {{

/**
* @brief This class contains an example of how to set LookupSettings classes used by the
Expand Down
2 changes: 1 addition & 1 deletion bberg/src/permutation_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ fn create_permutation_settings_file(permutation: &Permutation) -> String {
"
{permutation_settings_includes}

namespace bb::sumcheck {{
namespace bb {{

class {permutation_name}_permutation_settings {{
public:
Expand Down