Merged
Conversation
just-mitch
approved these changes
Nov 12, 2024
LHerskind
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 13, 2024
Fixes #9718. Implements the oracles relying directly on the `fake_exponential` e,g., the proving cost and fee asset cost. Using the data generated from AztecProtocol/engineering-designs#38 and checks that the solidity implementation matches the values from the python. The `MinimalFeeModel` showcase the storage needed and computations, the same logic logic will end up living closer to the rollup contract in what #9804
stevenplatt
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 13, 2024
Fixes #9718. Implements the oracles relying directly on the `fake_exponential` e,g., the proving cost and fee asset cost. Using the data generated from AztecProtocol/engineering-designs#38 and checks that the solidity implementation matches the values from the python. The `MinimalFeeModel` showcase the storage needed and computations, the same logic logic will end up living closer to the rollup contract in what #9804
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made some updates to the fee notebook such that it can be used to generate data for the solidity implementation and addresses some floats lingering around...