This repository was archived by the owner on Jan 16, 2024. It is now read-only.
Conversation
6 tasks
Maddiaa0
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 31, 2023
# Description closes: #1248 - Adds a build step before yarn project base that compiles the noir contracts using the nightly compiler version. - Adds an ephemeral layer to yarn project base to process the noir artifacts. ## Dependencies Uses the following build system pr in order to use multi stage builds of yarn project base. AztecProtocol/build-system#16 # Checklist: - [x] I have reviewed my diff in github, line by line. - [x] Every change is related to the PR description. - [x] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to the issue(s) that it resolves. - [x] There are no unexpected formatting changes, superfluous debug logs, or commented-out code. - [ ] The branch has been merged or rebased against the head of its merge target. - [ ] I'm happy for the PR to be merged at the reviewer's next convenience. --------- Co-authored-by: ludamad <adam.domurad@gmail.com>
ludamad
approved these changes
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The issue
The build script currently looks for any images that look like the following:
and pulls them.
When using multistep builds, the build script would try to pull the image for
builderas it was used inFROM builder.The solution
This pr tells the build system to NOT pull images that are suffixed with
_, now if we want to use multistage builds that build on images created within the current dockerfile, we can use something likebuilder_.Next steps: