join_split: Require same account flag for 'merge'#70
Merged
LeilaWang merged 2 commits intodefi-bridge-projectfrom Jan 20, 2023
Merged
join_split: Require same account flag for 'merge'#70LeilaWang merged 2 commits intodefi-bridge-projectfrom
LeilaWang merged 2 commits intodefi-bridge-projectfrom
Conversation
Collaborator
Author
|
@LeilaWang for the join split changes (in general) is there anything we need to update in |
ludamad
force-pushed
the
adam/auth_sdk/allow_no_sig_if_match
branch
from
30f8e62 to
d79d43d
Compare
|
Yes, we should add this to the |
sirasistant
approved these changes
Jan 20, 2023
dbanks12
pushed a commit
that referenced
this pull request
Jan 24, 2023
* fix(join_split): Check account flag. Fixes #66 * fix(constants): redo verification keys Co-authored-by: ludamad <adam@aztecprotocol.com>
dbanks12
pushed a commit
that referenced
this pull request
Jan 24, 2023
* fix(join_split): Check account flag. Fixes #66 * fix(constants): redo verification keys Co-authored-by: ludamad <adam@aztecprotocol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #66 for writeup
Modifies the definition of a "merge" (which, critically, is used when deciding to skip signature checks) to include checking the account flag
Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.