Skip to content

fix: Avoid bb.js memory issues.#578

Merged
codygunton merged 1 commit intomasterfrom
cg/lax-slab
Jul 5, 2023
Merged

fix: Avoid bb.js memory issues.#578
codygunton merged 1 commit intomasterfrom
cg/lax-slab

Conversation

@codygunton
Copy link
Copy Markdown

@codygunton codygunton commented Jul 5, 2023

Description

Less aggressive slab allocation and sporadic memory errors (leading to a timeout in bb.js CI). Cache reduced accordingly. Parameters here are chosen heuristically, and the new values were arrived at in a call with @charlielye.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@codygunton codygunton marked this pull request as ready for review July 5, 2023 08:43
@codygunton codygunton requested a review from charlielye July 5, 2023 08:43
@codygunton codygunton merged commit 96891de into master Jul 5, 2023
@codygunton codygunton deleted the cg/lax-slab branch July 5, 2023 09:01
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants