Skip to content

fix: BarycentricData instantiation time and unused code in secp curves#572

Merged
codygunton merged 6 commits intomasterfrom
cg/compilation-profiling-and-fixes
Jul 3, 2023
Merged

fix: BarycentricData instantiation time and unused code in secp curves#572
codygunton merged 6 commits intomasterfrom
cg/compilation-profiling-and-fixes

Conversation

@codygunton
Copy link
Copy Markdown

@codygunton codygunton commented Jul 3, 2023

Description

Using ClangBuildAnalyzer we identified some bottlenecks for compilation and found some fixes. The batch inversion at compilation time saves about 5 minutes of code generation! But we still have work to do (see #573).

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@codygunton codygunton changed the title fix: BarycentricData instantiation time + compilation profiling fix: BarycentricData instantiation time and unused code in secp curves Jul 3, 2023
@codygunton codygunton marked this pull request as ready for review July 3, 2023 16:20
@codygunton
Copy link
Copy Markdown
Author

codygunton commented Jul 3, 2023

@zac-williamson and I worked on this together, and it's small and uncontroversial, so we don't seek a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant