Skip to content

fix(ecdsa): correct short weierstrass curve eqn #567

Merged
codygunton merged 3 commits intomasterfrom
fix/non-k1-curve-eqn
Jul 1, 2023
Merged

fix(ecdsa): correct short weierstrass curve eqn #567
codygunton merged 3 commits intomasterfrom
fix/non-k1-curve-eqn

Conversation

@Maddiaa0
Copy link
Copy Markdown
Member

Description

Bumped into an issue creating circuits proving secp256r1 circuits, this pr pushes a fix checking the pk is on the curve, and also corrects curve eqn for curves with an a value.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@Maddiaa0 Maddiaa0 marked this pull request as ready for review June 30, 2023 08:12
Copy link
Copy Markdown

@codygunton codygunton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@codygunton codygunton merged commit 386ec63 into master Jul 1, 2023
@codygunton codygunton deleted the fix/non-k1-curve-eqn branch July 1, 2023 15:11
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants