Add cmake logic to support building of dependent C++/WASM projects#54
Merged
dbanks12 merged 10 commits intodefi-bridge-projectfrom Jan 24, 2023
Merged
Add cmake logic to support building of dependent C++/WASM projects#54dbanks12 merged 10 commits intodefi-bridge-projectfrom
dbanks12 merged 10 commits intodefi-bridge-projectfrom
Conversation
dbanks12
force-pushed
the
db/cmake_wasm_dependent_pj
branch
from
fb0ffad to
fbaa923
Compare
dbanks12
force-pushed
the
db/cmake_wasm_dependent_pj
branch
from
01f35eb to
cd79701
Compare
dbanks12
changed the title
dbanks12
force-pushed
the
db/cmake_wasm_dependent_pj
branch
from
c16101a to
b4c460b
Compare
added 8 commits
January 24, 2023 14:20
…e cleaner subshell instead of cd'ing back up after ignition in bootstrap.
… wasm-linux-clang.cmake
dbanks12
force-pushed
the
db/cmake_wasm_dependent_pj
branch
from
b6365d0 to
7b79a31
Compare
dbanks12
added a commit
that referenced
this pull request
Jan 24, 2023
* cmake updates to support dependent projects (native + wasm) * nothing should depend on constants from `rollup/` * use `cmake --build <dir> --parallel` everywhere instead of -j with nprocs * forward all bootstrap args to cmake with --target prefix for each. Use cleaner subshell instead of cd'ing back up after ignition in bootstrap. * allow dependent project to set WASI_SDK_PREFIX and have it be used in wasm-linux-clang.cmake * update readme to use cmake
dbanks12
added a commit
that referenced
this pull request
Jan 24, 2023
* cmake updates to support dependent projects (native + wasm) * nothing should depend on constants from `rollup/` * use `cmake --build <dir> --parallel` everywhere instead of -j with nprocs * forward all bootstrap args to cmake with --target prefix for each. Use cleaner subshell instead of cd'ing back up after ignition in bootstrap. * allow dependent project to set WASI_SDK_PREFIX and have it be used in wasm-linux-clang.cmake * update readme to use cmake
zac-williamson
added a commit
that referenced
this pull request
Jan 30, 2023
(compiles all of bberg into a single library)
dbanks12
added a commit
that referenced
this pull request
Feb 7, 2023
…llup/ removal, kesha's bigfield fix) (#123) * Target skylake but without avx. * Fix indent. * Fixing fuzzer build (#14) * Add cmake logic to support building of dependent C++/WASM projects (#54) * cmake updates to support dependent projects (native + wasm) * nothing should depend on constants from `rollup/` * use `cmake --build <dir> --parallel` everywhere instead of -j with nprocs * forward all bootstrap args to cmake with --target prefix for each. Use cleaner subshell instead of cd'ing back up after ignition in bootstrap. * allow dependent project to set WASI_SDK_PREFIX and have it be used in wasm-linux-clang.cmake * update readme to use cmake * Removed all files in rollup/ not necessary for join split tests * dockerfile, script, and ci changes now that rollup contents are gone except join split * remove more unused code from rollup/js dir * removed standard example * rename rollup directory to join_split_example * bigfield fix * filter out longer join split tests (leave only one full proof test in) for CI. fix bb-tests * fix dockerfile now that rollup executables were removed * rename rollup namespace to join_split_example * add blake 3 to executables/libraries in aztec cmakelists * Removing non-join-split constants as per recommendation here https://github.com/AztecProtocol/barretenberg/pull/124\#discussion_r1098698470 * remove vk constants from join-split --------- Co-authored-by: Charlie Lye <karl.lye@gmail.com> Co-authored-by: Innokentii Sennovskii <isennovskiy@gmail.com> Co-authored-by: Adam Domurad <adam.domurad@gmail.com> Co-authored-by: ludamad <adam@aztecprotocol.com>
ludamad
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
…llup/ removal, kesha's bigfield fix) (AztecProtocol/barretenberg#123) * Target skylake but without avx. * Fix indent. * Fixing fuzzer build (AztecProtocol/barretenberg#14) * Add cmake logic to support building of dependent C++/WASM projects (AztecProtocol/barretenberg#54) * cmake updates to support dependent projects (native + wasm) * nothing should depend on constants from `rollup/` * use `cmake --build <dir> --parallel` everywhere instead of -j with nprocs * forward all bootstrap args to cmake with --target prefix for each. Use cleaner subshell instead of cd'ing back up after ignition in bootstrap. * allow dependent project to set WASI_SDK_PREFIX and have it be used in wasm-linux-clang.cmake * update readme to use cmake * Removed all files in rollup/ not necessary for join split tests * dockerfile, script, and ci changes now that rollup contents are gone except join split * remove more unused code from rollup/js dir * removed standard example * rename rollup directory to join_split_example * bigfield fix * filter out longer join split tests (leave only one full proof test in) for CI. fix bb-tests * fix dockerfile now that rollup executables were removed * rename rollup namespace to join_split_example * add blake 3 to executables/libraries in aztec cmakelists * Removing non-join-split constants as per recommendation here https://github.com/AztecProtocol/barretenberg/pull/124\#discussion_r1098698470 * remove vk constants from join-split --------- Co-authored-by: Charlie Lye <karl.lye@gmail.com> Co-authored-by: Innokentii Sennovskii <isennovskiy@gmail.com> Co-authored-by: Adam Domurad <adam.domurad@gmail.com> Co-authored-by: ludamad <adam@aztecprotocol.com>
ludamad
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
…llup/ removal, kesha's bigfield fix) (AztecProtocol/barretenberg#123) * Target skylake but without avx. * Fix indent. * Fixing fuzzer build (AztecProtocol/barretenberg#14) * Add cmake logic to support building of dependent C++/WASM projects (AztecProtocol/barretenberg#54) * cmake updates to support dependent projects (native + wasm) * nothing should depend on constants from `rollup/` * use `cmake --build <dir> --parallel` everywhere instead of -j with nprocs * forward all bootstrap args to cmake with --target prefix for each. Use cleaner subshell instead of cd'ing back up after ignition in bootstrap. * allow dependent project to set WASI_SDK_PREFIX and have it be used in wasm-linux-clang.cmake * update readme to use cmake * Removed all files in rollup/ not necessary for join split tests * dockerfile, script, and ci changes now that rollup contents are gone except join split * remove more unused code from rollup/js dir * removed standard example * rename rollup directory to join_split_example * bigfield fix * filter out longer join split tests (leave only one full proof test in) for CI. fix bb-tests * fix dockerfile now that rollup executables were removed * rename rollup namespace to join_split_example * add blake 3 to executables/libraries in aztec cmakelists * Removing non-join-split constants as per recommendation here https://github.com/AztecProtocol/barretenberg/pull/124\#discussion_r1098698470 * remove vk constants from join-split --------- Co-authored-by: Charlie Lye <karl.lye@gmail.com> Co-authored-by: Innokentii Sennovskii <isennovskiy@gmail.com> Co-authored-by: Adam Domurad <adam.domurad@gmail.com> Co-authored-by: ludamad <adam@aztecprotocol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CMake changes to support this along with minor C++ changes to prepare for move of
rollup/contents to a dependent project.Prerequisite for AC PR #2269
Details
build*/libfor eachsrc/aztec/subdirectory. It also generates alibbarretenberg.awhich is a single barretenberg library file that can be used in a dependent project.libbarretenberg.aand using-Wl,--whole-archive.rollup/, I copied a single constant fromrollup/constantstostdlib/constants.