Skip to content

fix: add NUM_RESERVED_GATES before fetching subgroup size in composer#539

Merged
vezenovm merged 1 commit intomasterfrom
mv/dsl-subgroup-size-fix
Jun 16, 2023
Merged

fix: add NUM_RESERVED_GATES before fetching subgroup size in composer#539
vezenovm merged 1 commit intomasterfrom
mv/dsl-subgroup-size-fix

Conversation

@vezenovm
Copy link
Copy Markdown

@vezenovm vezenovm commented Jun 16, 2023 •
edited
Loading

Description

Check this old PR for the description: #507

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@vezenovm vezenovm mentioned this pull request Jun 16, 2023
Closed
11 tasks
@vezenovm vezenovm merged commit fa11abf into master Jun 16, 2023
@vezenovm vezenovm deleted the mv/dsl-subgroup-size-fix branch June 16, 2023 16:16
@github-actions github-actions Bot mentioned this pull request Jun 16, 2023
Merged
vezenovm added a commit that referenced this pull request Jun 16, 2023
@vezenovm
Revert "fix: add NUM_RESERVED_GATES before fetching subgroup size in …
cf0d121 
…composer (#539)"

This reverts commit fa11abf.
@vezenovm vezenovm mentioned this pull request Jun 16, 2023
Merged
@github-actions github-actions Bot mentioned this pull request Jul 11, 2023
Merged
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@vezenovm
fix: add NUM_RESERVED_GATES before fetching subgroup size in composer (…
6f422df 
…AztecProtocol/barretenberg#539)
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@vezenovm
fix: add NUM_RESERVED_GATES before fetching subgroup size in composer (…
0a0d767 
…AztecProtocol/barretenberg#539)
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charlielye charlielye Awaiting requested review from charlielye

1 more reviewer

@kevaundray kevaundray kevaundray approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vezenovm @kevaundray