fix: cleanup of include statements#527
Merged
maramihali merged 3 commits intomasterfrom Jun 16, 2023
Merged
Conversation
maramihali
force-pushed
the
cg/plonk-dep-cleanup
branch
2 times, most recently
from
9691ba8 to
e7829fa
Compare
maramihali
force-pushed
the
cg/plonk-dep-cleanup
branch
from
e7829fa to
a31869d
Compare
codygunton
commented
Jun 16, 2023
Author
codygunton
left a comment
codygunton
left a comment
There was a problem hiding this comment.
Looks good. Since I started this PR I can't approve it, so could you approve and merge after rebasing?
maramihali
approved these changes
Jun 16, 2023
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
…rretenberg#527) Ensure honk does not depend on plonk anymore. Remove use of the stdlib composer headers used for forward declaration outside stdlib. Co-authored-by: maramihali <mara@aztecprotocol.com>, codygunton <cody@aztecprotocol.com>
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
…rretenberg#527) Ensure honk does not depend on plonk anymore. Remove use of the stdlib composer headers used for forward declaration outside stdlib. Co-authored-by: maramihali <mara@aztecprotocol.com>, codygunton <cody@aztecprotocol.com>
This was referenced Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup include statments
Ensure that
composers_fwd.hppandcomposers.hppused for forward declaration in stdlib are not used anywhere else. Further cleanup so honk doesn't depend on plonk anymoreChecklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.