Conversation
ludamad
reviewed
Jun 6, 2023
|
|
||
| Fr* scalars = (Fr*)aligned_alloc(32, sizeof(Fr) * num_points); | ||
|
|
||
| AffineElement* points = (AffineElement*)aligned_alloc(32, sizeof(AffineElement) * num_points * 2 + 1); |
Collaborator
There was a problem hiding this comment.
Any reason this can't just be a points = new AffineElement[num_points * 2 + 1]?
Author
There was a problem hiding this comment.
We need them aligned. From what I understand by default new doesn't do that and we absolutely need that for pippenger
ledwards2225
approved these changes
Jun 12, 2023
| key->polynomial_store.put("z_lookup", std::move(z_lookup)); | ||
| for (size_t k = 1; k < 4; ++k) { | ||
| free(accumulators[k]); | ||
| } |
kevaundray
changed the title
Rumata888
force-pushed
the
is/memory_fixes
branch
from
7f45eb9 to
d9be8d9
Compare
Rumata888
changed the title
Rumata888
changed the title
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
This was referenced Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Check circuit had an off-by-one error
Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.