feat(api): external cpp header for circuits#489
Merged
Conversation
added 2 commits
May 31, 2023 18:01
Merged
6 tasks
added 3 commits
May 31, 2023 18:30
…t break when aztec PR is merged to master
ludamad
approved these changes
May 31, 2023
Collaborator
ludamad
left a comment
There was a problem hiding this comment.
As noted, I never intended
#include "serialize/cbind.hpp"
#include "serialize/msgpack.hpp"
#include "serialize/test_helper.hpp"
To be exposed to header files. It may slow down compilation (although only really if we have a lot of .cpp files). Otherwise LGTM.
codygunton
approved these changes
May 31, 2023
codygunton
left a comment
There was a problem hiding this comment.
Thanks for this. This is crucial as a first step, and in that sense it looks right to me. That said, this API is really large and hence we can expect regular breaking changes until we can pare it down as discussed earlier today.
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
…rg#489) * missing header includes * comments in api header with issues/todos
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
…rg#489) * missing header includes * comments in api header with issues/todos
This was referenced Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After this PR is merged followed by its blocked aztec PR,
.aztec-packages-commitcan be set to master or latest aztec master commit.Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.