Skip to content

Add partial-fix for ecdsa signature construction malleability#439

Closed
kevaundray wants to merge 1 commit intomasterfrom
kw/fix-malleability-bug
Closed

Add partial-fix for ecdsa signature construction malleability#439
kevaundray wants to merge 1 commit intomasterfrom
kw/fix-malleability-bug

Conversation

@kevaundray
Copy link
Copy Markdown

Description

This does not fix the issue because the verification logic does not check that s is "low". This is only a partial fix for the problems encountered in DSL.

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

@kevaundray
Copy link
Copy Markdown
Author

superceded by #512

@kevaundray kevaundray closed this Jun 12, 2023
@ludamad ludamad deleted the kw/fix-malleability-bug branch February 20, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant