feat(dsl)!: add hash index to pedersen constraint#436
Merged
sirasistant merged 3 commits intomasterfrom May 30, 2023
Merged
Conversation
sirasistant
force-pushed
the
arv/noir_hash_index
branch
from
d9a57b9 to
7673912
Compare
phated
reviewed
May 11, 2023
Author
|
I was going to change the noir ref to use my pedersen with domain separator branch but another barretenberg breaking change has landed already #417 which complicates more having a noir branch that works with both breaking changes. |
kevaundray
approved these changes
May 30, 2023
sirasistant
added a commit
that referenced
this pull request
May 31, 2023
* feat(noir): add hash index to pedersen constraint * feat: added pedesen with hash_index in header
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
…etenberg#436) * feat(noir): add hash index to pedersen constraint * feat: added pedesen with hash_index in header
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
…etenberg#436) * feat(noir): add hash index to pedersen constraint * feat: added pedesen with hash_index in header
This was referenced Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the hash_index value to the PedersenConstraint used by noir (previously it was always using the default, zero)
Also adds a new cbind to be able to call plookup commit with hash index.
Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.