Elide sig check on 'merge' join-split proofs#42
Merged
LeilaWang merged 7 commits intodefi-bridge-projectfrom Jan 16, 2023
Merged
Elide sig check on 'merge' join-split proofs#42LeilaWang merged 7 commits intodefi-bridge-projectfrom
LeilaWang merged 7 commits intodefi-bridge-projectfrom
Conversation
…enberg into adam/auth_sdk/allow_no_sig_if_match
ludamad
commented
Jan 16, 2023
| // This is a merge if one this is a 'send' proof type and one of the output notes has value 0 | ||
| const bool_ct is_merge_send = is_send && (output_note_1_value == 0 || output_note_2_value == 0); | ||
| // If we are merging our own notes, we don't need to sign | ||
| // Note: when computing is_same_owner, we rely on input_note_1.owner == input_note_2.owner being checked already |
Collaborator
Author
There was a problem hiding this comment.
feedback: get rid of verified_or_merge_with_same_owners_and_amount, is_merge_send already implies the following:
const bool_ct is_merge_send = is_send && (output_note_1_value == 0 || output_note_2_value == 0) && is_same_owner && is_same_amount;
then have (verified || is_merge_send).assert_equal....
dbanks12
pushed a commit
that referenced
this pull request
Jan 24, 2023
* Elide sig check on 'merge' join-split proofs * README.md: Mention bootstrap.sh directory * join_split: simplify from feedback * Update join_split_circuit.cpp * Update join_split_circuit.cpp * constants.hpp: redo vk hashes Co-authored-by: ludamad <adam@aztecprotocol.com>
dbanks12
pushed a commit
that referenced
this pull request
Jan 24, 2023
* Elide sig check on 'merge' join-split proofs * README.md: Mention bootstrap.sh directory * join_split: simplify from feedback * Update join_split_circuit.cpp * Update join_split_circuit.cpp * constants.hpp: redo vk hashes Co-authored-by: ludamad <adam@aztecprotocol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
P.S. this repo could use a pull request template
See https://hackmd.io/@aztec-network/H10r1JqOo
Checklist:
/markdown/specshave been updated.Barretenberg-specific requirements:
@briefdescribing the intended functionality.