chore: Fetch master for DSL recursion#381
Closed
vezenovm wants to merge 5 commits intozw/noir-recursionfrom
Closed
chore: Fetch master for DSL recursion#381vezenovm wants to merge 5 commits intozw/noir-recursionfrom
vezenovm wants to merge 5 commits intozw/noir-recursionfrom
Conversation
Author
|
Closing in favor of mv/noir-recursion. Don't squash the branch just yet though as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The noir-recursion branch requires more changes from master that Noir also requires
There was a change in the recursion work that removed the reference string from the std lib verification key which required usage of the env crs. However, any usage of
env_load_prover_crsorenv_load_verifier_crsfails on mainframe due toundefined reference tobbmalloc'` (oddly enough it all works on my local macbook). This branch also includes a workaround to get EnvReferenceString compiling by just calling aligned_alloc which bbmalloc calls internally. However, I don't know if this possibly breaks things elsewhere in wasm. Otherwise we may have to go back to storing the reference string inside the stdlib verification key, or nail down why we are getting an undefined reference when linking on linux.Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.