Skip to content

Add Mutex to global initialisation of generators #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevaundray merged 2 commits into from
Apr 21, 2023
Merged

Add Mutex to global initialisation of generators #371

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f409714
Mutex lock initialization call
maxhora Apr 21, 2023
6036f52
add comment on mutex
kevaundray Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions cpp/src/barretenberg/crypto/pedersen_hash/pedersen_lookup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#include "./pedersen_lookup.hpp"

#include <mutex>

#include "barretenberg/ecc/curves/grumpkin/grumpkin.hpp"

namespace crypto {
Expand All @@ -10,6 +12,12 @@ std::array<std::vector<grumpkin::g1::affine_element>, NUM_PEDERSEN_TABLES> peder
std::vector<grumpkin::g1::affine_element> pedersen_iv_table;
std::array<grumpkin::g1::affine_element, NUM_PEDERSEN_TABLES> generators;

// Mutex is not available in the WASM context.
// WASM runs in a single-thread so this is acceptable.
#if !defined(__wasm__)
std::mutex init_mutex;
#endif

static bool inited = false;

void init_single_lookup_table(const size_t index)
Expand Down Expand Up @@ -66,6 +74,11 @@ void init()
{
ASSERT(BITS_PER_TABLE < BITS_OF_BETA);
ASSERT(BITS_PER_TABLE + BITS_OF_BETA < BITS_ON_CURVE);

#if !defined(__wasm__)
const std::lock_guard<std::mutex> lock(init_mutex);
#endif

if (inited) {
return;
}
Expand Down