Skip to content

doc: Document more thoroughly why fields don't 0-init #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 3 commits into from
Apr 13, 2023
Merged

doc: Document more thoroughly why fields don't 0-init #349

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f744367
Update field.hpp
ludamad Apr 12, 2023
381ce7e
Update field.hpp
ludamad Apr 12, 2023
62abab8
Update field.hpp
ludamad Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cpp/src/barretenberg/ecc/fields/field.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ namespace barretenberg {
template <class Params> struct alignas(32) field {
public:
// We don't initialize data by default since we'd lose a lot of time on pointless initializations.
// Other alternatives have been noted, such as casting to get around constructors where they matter,
// however it is felt that sanitizer tools (e.g. MSAN) can detect garbage well, whereas doing
// hacky casts where needed would require rework to critical algos like MSM, FFT, Sumcheck.
// Instead, the recommended solution is use an explicit = 0 where initialization is important.
field() noexcept {}

constexpr field(const uint256_t& input) noexcept
Expand Down