Skip to content

feat: parallelize DIE pass #9933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 2 commits into from
Nov 13, 2024
Merged

feat: parallelize DIE pass #9933

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c450449
chore: turn off DIE pass
TomAFrench Nov 13, 2024
2368244
chore: parallelize DIE pass
TomAFrench Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions noir/noir-repo/compiler/noirc_evaluator/src/ssa/opt/die.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
use fxhash::{FxHashMap as HashMap, FxHashSet as HashSet};
use im::Vector;
use noirc_errors::Location;
use rayon::iter::{IntoParallelRefMutIterator, ParallelIterator};

use crate::ssa::{
ir::{
Expand All @@ -24,9 +25,8 @@ impl Ssa {
/// unused results.
#[tracing::instrument(level = "trace", skip(self))]
pub(crate) fn dead_instruction_elimination(mut self) -> Ssa {
for function in self.functions.values_mut() {
function.dead_instruction_elimination(true);
}
self.functions.par_iter_mut().for_each(|(_, func)| func.dead_instruction_elimination(true));

self
}
}
Expand Down