Skip to content

chore: pull noir PR #6461 from sync PR#9923

Merged
TomAFrench merged 3 commits intomasterfrom
tf/pull-out-simulator-fix
Nov 13, 2024
Merged

chore: pull noir PR #6461 from sync PR#9923
TomAFrench merged 3 commits intomasterfrom
tf/pull-out-simulator-fix

Conversation

@TomAFrench
Copy link
Member

Pulls out noir-lang/noir#6461 from the sync PR

@TomAFrench TomAFrench changed the title fix: pull noir PR #6461 from sync PR chore: pull noir PR #6461 from sync PR Nov 13, 2024
@github-actions
Copy link
Contributor

Changes to circuit sizes

Generated at commit: 4f549ad66ba64d5f059c6fe6ba40f7b803b89919, compared to commit: 21dccf8aeb15ce4a9bf5181c63a7278a157ddbdd

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_init +23 ❌ +0.11% +21 ❌ +0.06%
private_kernel_inner +26 ❌ +0.07% +22 ❌ +0.04%
private_kernel_tail +3 ❌ +0.07% +3 ❌ +0.02%
parity_base +3 ❌ +0.07% +3 ❌ +0.01%
private_kernel_tail_to_public +3 ❌ +0.02% +3 ❌ +0.01%
private_kernel_reset_4_4_4_4_4_4_4_4_1 +1 ❌ +0.00% +1 ❌ +0.00%
rollup_base_private +38 ❌ +0.01% +38 ❌ +0.00%
rollup_base_public +38 ❌ +0.01% +38 ❌ +0.00%
rollup_merge +4 ❌ +0.12% +4 ❌ +0.00%
rollup_root +4 ❌ +0.03% +4 ❌ +0.00%
rollup_block_merge +4 ❌ +0.03% +4 ❌ +0.00%
private_kernel_reset +1 ❌ +0.00% +1 ❌ +0.00%
rollup_block_root +4 ❌ +0.09% +4 ❌ +0.00%
parity_root +3 ❌ +0.06% +3 ❌ +0.00%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_init 21,726 (+23) +0.11% 34,887 (+21) +0.06%
private_kernel_inner 38,093 (+26) +0.07% 57,530 (+22) +0.04%
private_kernel_tail 4,493 (+3) +0.07% 13,045 (+3) +0.02%
parity_base 4,301 (+3) +0.07% 30,698 (+3) +0.01%
private_kernel_tail_to_public 18,852 (+3) +0.02% 31,300 (+3) +0.01%
private_kernel_reset_4_4_4_4_4_4_4_4_1 32,455 (+1) +0.00% 86,600 (+1) +0.00%
rollup_base_private 332,907 (+38) +0.01% 3,432,553 (+38) +0.00%
rollup_base_public 470,090 (+38) +0.01% 3,770,594 (+38) +0.00%
rollup_merge 3,419 (+4) +0.12% 1,909,446 (+4) +0.00%
rollup_root 11,989 (+4) +0.03% 1,940,906 (+4) +0.00%
rollup_block_merge 12,005 (+4) +0.03% 1,940,920 (+4) +0.00%
private_kernel_reset 84,097 (+1) +0.00% 618,117 (+1) +0.00%
rollup_block_root 4,489 (+4) +0.09% 2,863,252 (+4) +0.00%
parity_root 5,034 (+3) +0.06% 3,801,552 (+3) +0.00%

@TomAFrench TomAFrench merged commit 21e07d2 into master Nov 13, 2024
@TomAFrench TomAFrench deleted the tf/pull-out-simulator-fix branch November 13, 2024 13:28
@TomAFrench TomAFrench restored the tf/pull-out-simulator-fix branch November 13, 2024 13:28
@TomAFrench TomAFrench deleted the tf/pull-out-simulator-fix branch November 13, 2024 13:29
TomAFrench added a commit that referenced this pull request Nov 13, 2024
* master:
  fix: TXE fixes (#9930)
  chore: pull noir PR #6461 from sync PR (#9923)
  chore: update version numbers of noir packages (#9922)
  chore: pull doc changes out of sync PR (#9921)
  feat: naive attempt to bind the honk solidity verifier function to the ts interface (#9432)
  fix: update cli-wallet bash tests to reflect token contract changes (#9927)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants