test: prove one epoch in kind by alexghr · Pull Request #9886 · AztecProtocol/aztec-packages

alexghr · 2024-11-11T15:35:32Z

Please read contributing guidelines and remove this line.

spalladino

Typescript side of things looks good, but I wouldn't count my approval for the k8s side.

github-actions · 2024-11-13T15:18:09Z

Changes to circuit sizes

Generated at commit: a3265474f16ae1173306fc3e9fc92df8d380caa9, compared to commit: e4c3f4baf932e304151d022767b38c5dcfff35b2

🧾 Summary (100% most significant diffs)

Program	%	Circuit size (+/-)	%
private_kernel_empty	0.00%	+41,200 ❌	+4.57%
parity_root	0.00%	+164,800 ❌	+4.53%
rollup_block_root	0.00%	+123,600 ❌	+4.51%
rollup_merge	0.00%	+82,400 ❌	+4.51%
rollup_root	0.00%	+82,400 ❌	+4.43%
rollup_block_merge	0.00%	+82,400 ❌	+4.43%
rollup_base_private	0.00%	+41,201 ❌	+1.21%
rollup_base_public	0.00%	+41,200 ❌	+1.10%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_empty	612 (0)	0.00%	942,839 (+41,200)	+4.57%
parity_root	5,034 (0)	0.00%	3,801,552 (+164,800)	+4.53%
rollup_block_root	4,489 (0)	0.00%	2,863,252 (+123,600)	+4.51%
rollup_merge	3,419 (0)	0.00%	1,909,446 (+82,400)	+4.51%
rollup_root	11,989 (0)	0.00%	1,940,906 (+82,400)	+4.43%
rollup_block_merge	12,005 (0)	0.00%	1,940,920 (+82,400)	+4.43%
rollup_base_private	335,062 (0)	0.00%	3,450,602 (+41,201)	+1.21%
rollup_base_public	472,329 (0)	0.00%	3,786,954 (+41,200)	+1.10%

PhilWindle · 2024-11-13T15:31:50Z

spartan/aztec-network/values/1-validator-with-proving-and-metrics.yaml

+proverAgent:
+  replicas: 6
+  realProofs: true
+  realProofs: true


PhilWindle · 2024-11-13T15:31:59Z

spartan/aztec-network/values/1-validator-with-proving.yaml

 proverAgent:
  replicas: 6
  realProofs: true
+  realProofs: true


github-actions · 2024-11-13T20:04:46Z

Changes to public function bytecode sizes

Generated at commit: a3265474f16ae1173306fc3e9fc92df8d380caa9, compared to commit: e4c3f4baf932e304151d022767b38c5dcfff35b2

🧾 Summary (100% most significant diffs)

Program	Bytecode size in bytes (+/-)	%
Token::complete_refund	+208 ❌	+3.56%
Token::public_dispatch	+536 ❌	+1.59%
AvmTest::poseidon2_hash	+12 ❌	+0.69%
AvmTest::get_args_hash	+12 ❌	+0.67%
AuthRegistry::set_reject_all	+12 ❌	+0.65%
AvmTest::read_storage_map	+12 ❌	+0.62%
NFT::_finish_transfer_to_public	+12 ❌	+0.62%
Auth::get_scheduled_authorized	+12 ❌	+0.62%
PriceFeed::set_price	+12 ❌	+0.62%
AvmTest::set_storage_map	+12 ❌	+0.61%
StatefulTest::get_public_value	+12 ❌	+0.61%
AuthRegistry::is_reject_all	+12 ❌	+0.61%
PriceFeed::get_price	+12 ❌	+0.60%
Benchmarking::broadcast	+12 ❌	+0.60%
AuthRegistry::set_authorized	+12 ❌	+0.60%
NFT::is_minter	+12 ❌	+0.59%
Token::is_minter	+12 ❌	+0.59%
Auth::get_authorized	+12 ❌	+0.59%
AuthRegistry::_set_authorized	+12 ❌	+0.58%
FeeJuice::balance_of_public	+12 ❌	+0.58%
StatefulTest::increment_public_value_no_init_check	+12 ❌	+0.57%
TokenBlacklist::balance_of_public	+12 ❌	+0.57%
Token::balance_of_public	+12 ❌	+0.57%
AuthRegistry::is_consumable	+12 ❌	+0.56%
StatefulTest::increment_public_value	+12 ❌	+0.56%
Token::set_minter	+12 ❌	+0.55%
NFT::set_minter	+12 ❌	+0.54%
Lending::get_asset	+12 ❌	+0.54%
AvmTest::add_storage_map	+12 ❌	+0.52%
Auth::get_authorized_delay	+12 ❌	+0.50%
FeeJuice::check_balance	+12 ❌	+0.49%
EasyPrivateVoting::add_to_tally_public	+12 ❌	+0.47%
FeeJuice::_increase_public_balance	+12 ❌	+0.46%
NFT::owner_of	+12 ❌	+0.43%
Spam::public_spam	+12 ❌	+0.43%
TokenBlacklist::_increase_public_balance	+12 ❌	+0.42%
Token::_increase_public_balance	+12 ❌	+0.42%
CardGame::start_game	+29 ❌	+0.42%
Lending::_deposit	+12 ❌	+0.39%
FPC::constructor	+12 ❌	+0.38%
Lending::init	+12 ❌	+0.38%
Claim::constructor	+12 ❌	+0.37%
TokenBridge::constructor	+12 ❌	+0.36%
NFT::mint	+12 ❌	+0.36%
Parent::public_nested_static_call	+12 ❌	+0.36%
Token::mint_to_public	+12 ❌	+0.34%
Benchmarking::increment_balance	+12 ❌	+0.32%
CardGame::on_game_joined	+12 ❌	+0.24%
Lending::get_position	+12 ❌	+0.23%
Lending::update_accumulator	+12 ❌	+0.21%
CardGame::on_card_played	+12 ❌	+0.20%
Lending::_repay	+12 ❌	+0.19%
NFT::finalize_transfer_to_private	+12 ❌	+0.19%
NFT::_finalize_transfer_to_private_unsafe	+12 ❌	+0.19%
Token::finalize_mint_to_private	+12 ❌	+0.17%
Token::_finalize_mint_to_private_unsafe	+12 ❌	+0.17%
Token::finalize_transfer_to_private	+12 ❌	+0.16%
CardGame::on_cards_claimed	+12 ❌	+0.16%
Token::_finalize_transfer_to_private_unsafe	+12 ❌	+0.16%
Lending::_borrow	+12 ❌	+0.13%
Lending::_withdraw	+12 ❌	+0.13%
CardGame::public_dispatch	+16 ❌	+0.10%
Benchmarking::public_dispatch	-1 ✅	-0.02%
AvmTest::bulk_testing	-10 ✅	-0.04%
Uniswap::swap_public	-10 ✅	-0.06%
TokenBridge::claim_public	-10 ✅	-0.08%
Test::consume_mint_to_public_message	-10 ✅	-0.09%
Test::consume_message_from_arbitrary_sender_public	-10 ✅	-0.13%
TokenBlacklist::constructor	-10 ✅	-0.13%
TokenBlacklist::update_roles	-10 ✅	-0.13%
Lending::public_dispatch	-40 ✅	-0.14%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1	-10 ✅	-0.15%
TokenBlacklist::shield	-10 ✅	-0.16%
TokenBlacklist::transfer_public	-10 ✅	-0.16%
TokenBridge::public_dispatch	-36 ✅	-0.16%
Parent::public_dispatch	-14 ✅	-0.16%
Auth::set_authorized	-10 ✅	-0.17%
Auth::set_authorized_delay	-10 ✅	-0.17%
TokenBlacklist::burn_public	-10 ✅	-0.17%
AvmTest::public_dispatch	-114 ✅	-0.19%
Token::constructor	-10 ✅	-0.19%
Token::transfer_in_public	-10 ✅	-0.21%
NFT::constructor	-10 ✅	-0.21%
Auth::public_dispatch	-23 ✅	-0.21%
Token::burn_public	-10 ✅	-0.21%
TokenBlacklist::mint_public	-10 ✅	-0.22%
FeeJuice::public_dispatch	-14 ✅	-0.22%
TokenBlacklist::mint_private	-10 ✅	-0.23%
TokenBlacklist::public_dispatch	-62 ✅	-0.24%
Uniswap::public_dispatch	-62 ✅	-0.25%
StatefulTest::public_constructor	-10 ✅	-0.26%
NFT::transfer_in_public	-10 ✅	-0.27%
AppSubscription::constructor	-10 ✅	-0.27%
Crowdfunding::init	-10 ✅	-0.28%
NFT::public_dispatch	-75 ✅	-0.28%
AvmInitializerTest::public_dispatch	-10 ✅	-0.29%
EasyPrivateVoting::constructor	-10 ✅	-0.31%
AuthRegistry::consume	-10 ✅	-0.31%
Auth::constructor	-10 ✅	-0.32%
Uniswap::constructor	-10 ✅	-0.32%
Claim::public_dispatch	-14 ✅	-0.33%
PriceFeed::public_dispatch	-14 ✅	-0.34%
TokenBlacklist::get_roles	-10 ✅	-0.36%
Spam::public_dispatch	-14 ✅	-0.36%
EasyPrivateVoting::public_dispatch	-23 ✅	-0.37%
InclusionProofs::constructor	-10 ✅	-0.38%
AvmInitializerTest::constructor	-10 ✅	-0.39%
Child::public_dispatch	-26 ✅	-0.42%
DocsExample::public_dispatch	-26 ✅	-0.43%
Test::public_dispatch	-88 ✅	-0.43%
StatefulTest::public_dispatch	-36 ✅	-0.44%
AppSubscription::public_dispatch	-23 ✅	-0.45%
Router::public_dispatch	-13 ✅	-0.50%
StaticParent::public_dispatch	-39 ✅	-0.53%
Crowdfunding::public_dispatch	-36 ✅	-0.57%
AuthRegistry::public_dispatch	-49 ✅	-0.58%
AuthWitTest::public_dispatch	-13 ✅	-0.66%
StaticChild::public_dispatch	-26 ✅	-0.82%
InclusionProofs::public_dispatch	-36 ✅	-0.85%
FPC::public_dispatch	-84 ✅	-0.99%

Full diff report 👇

Program	Bytecode size in bytes (+/-)	%
Token::complete_refund	6,056 (+208)	+3.56%
Token::public_dispatch	34,189 (+536)	+1.59%
AvmTest::poseidon2_hash	1,746 (+12)	+0.69%
AvmTest::get_args_hash	1,816 (+12)	+0.67%
AuthRegistry::set_reject_all	1,857 (+12)	+0.65%
AvmTest::read_storage_map	1,941 (+12)	+0.62%
NFT::_finish_transfer_to_public	1,941 (+12)	+0.62%
Auth::get_scheduled_authorized	1,953 (+12)	+0.62%
PriceFeed::set_price	1,958 (+12)	+0.62%
AvmTest::set_storage_map	1,968 (+12)	+0.61%
StatefulTest::get_public_value	1,972 (+12)	+0.61%
AuthRegistry::is_reject_all	1,982 (+12)	+0.61%
PriceFeed::get_price	2,000 (+12)	+0.60%
Benchmarking::broadcast	2,006 (+12)	+0.60%
AuthRegistry::set_authorized	2,019 (+12)	+0.60%
NFT::is_minter	2,036 (+12)	+0.59%
Token::is_minter	2,036 (+12)	+0.59%
Auth::get_authorized	2,053 (+12)	+0.59%
AuthRegistry::_set_authorized	2,066 (+12)	+0.58%
FeeJuice::balance_of_public	2,080 (+12)	+0.58%
StatefulTest::increment_public_value_no_init_check	2,110 (+12)	+0.57%
TokenBlacklist::balance_of_public	2,134 (+12)	+0.57%
Token::balance_of_public	2,134 (+12)	+0.57%
AuthRegistry::is_consumable	2,149 (+12)	+0.56%
StatefulTest::increment_public_value	2,159 (+12)	+0.56%
Token::set_minter	2,212 (+12)	+0.55%
NFT::set_minter	2,217 (+12)	+0.54%
Lending::get_asset	2,221 (+12)	+0.54%
AvmTest::add_storage_map	2,328 (+12)	+0.52%
Auth::get_authorized_delay	2,410 (+12)	+0.50%
FeeJuice::check_balance	2,453 (+12)	+0.49%
EasyPrivateVoting::add_to_tally_public	2,559 (+12)	+0.47%
FeeJuice::_increase_public_balance	2,598 (+12)	+0.46%
NFT::owner_of	2,808 (+12)	+0.43%
Spam::public_spam	2,808 (+12)	+0.43%
TokenBlacklist::_increase_public_balance	2,867 (+12)	+0.42%
Token::_increase_public_balance	2,867 (+12)	+0.42%
CardGame::start_game	6,994 (+29)	+0.42%
Lending::_deposit	3,053 (+12)	+0.39%
FPC::constructor	3,164 (+12)	+0.38%
Lending::init	3,204 (+12)	+0.38%
Claim::constructor	3,281 (+12)	+0.37%
TokenBridge::constructor	3,362 (+12)	+0.36%
NFT::mint	3,376 (+12)	+0.36%
Parent::public_nested_static_call	3,376 (+12)	+0.36%
Token::mint_to_public	3,537 (+12)	+0.34%
Benchmarking::increment_balance	3,725 (+12)	+0.32%
CardGame::on_game_joined	5,058 (+12)	+0.24%
Lending::get_position	5,250 (+12)	+0.23%
Lending::update_accumulator	5,776 (+12)	+0.21%
CardGame::on_card_played	5,959 (+12)	+0.20%
Lending::_repay	6,191 (+12)	+0.19%
NFT::finalize_transfer_to_private	6,447 (+12)	+0.19%
NFT::_finalize_transfer_to_private_unsafe	6,494 (+12)	+0.19%
Token::finalize_mint_to_private	7,117 (+12)	+0.17%
Token::_finalize_mint_to_private_unsafe	7,164 (+12)	+0.17%
Token::finalize_transfer_to_private	7,327 (+12)	+0.16%
CardGame::on_cards_claimed	7,350 (+12)	+0.16%
Token::_finalize_transfer_to_private_unsafe	7,374 (+12)	+0.16%
Lending::_borrow	9,021 (+12)	+0.13%
Lending::_withdraw	9,285 (+12)	+0.13%
CardGame::public_dispatch	16,259 (+16)	+0.10%
Benchmarking::public_dispatch	5,659 (-1)	-0.02%
AvmTest::bulk_testing	23,785 (-10)	-0.04%
Uniswap::swap_public	15,713 (-10)	-0.06%
TokenBridge::claim_public	12,946 (-10)	-0.08%
Test::consume_mint_to_public_message	11,094 (-10)	-0.09%
Test::consume_message_from_arbitrary_sender_public	7,967 (-10)	-0.13%
TokenBlacklist::constructor	7,928 (-10)	-0.13%
TokenBlacklist::update_roles	7,689 (-10)	-0.13%
Lending::public_dispatch	28,493 (-40)	-0.14%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1	6,463 (-10)	-0.15%
TokenBlacklist::shield	6,428 (-10)	-0.16%
TokenBlacklist::transfer_public	6,323 (-10)	-0.16%
TokenBridge::public_dispatch	22,156 (-36)	-0.16%
Parent::public_dispatch	8,500 (-14)	-0.16%
Auth::set_authorized	6,044 (-10)	-0.17%
Auth::set_authorized_delay	5,958 (-10)	-0.17%
TokenBlacklist::burn_public	5,890 (-10)	-0.17%
AvmTest::public_dispatch	61,247 (-114)	-0.19%
Token::constructor	5,155 (-10)	-0.19%
Token::transfer_in_public	4,809 (-10)	-0.21%
NFT::constructor	4,799 (-10)	-0.21%
Auth::public_dispatch	10,885 (-23)	-0.21%
Token::burn_public	4,701 (-10)	-0.21%
TokenBlacklist::mint_public	4,623 (-10)	-0.22%
FeeJuice::public_dispatch	6,335 (-14)	-0.22%
TokenBlacklist::mint_private	4,306 (-10)	-0.23%
TokenBlacklist::public_dispatch	25,304 (-62)	-0.24%
Uniswap::public_dispatch	25,014 (-62)	-0.25%
StatefulTest::public_constructor	3,872 (-10)	-0.26%
NFT::transfer_in_public	3,726 (-10)	-0.27%
AppSubscription::constructor	3,702 (-10)	-0.27%
Crowdfunding::init	3,547 (-10)	-0.28%
NFT::public_dispatch	26,386 (-75)	-0.28%
AvmInitializerTest::public_dispatch	3,442 (-10)	-0.29%
EasyPrivateVoting::constructor	3,235 (-10)	-0.31%
AuthRegistry::consume	3,234 (-10)	-0.31%
Auth::constructor	3,109 (-10)	-0.32%
Uniswap::constructor	3,068 (-10)	-0.32%
Claim::public_dispatch	4,291 (-14)	-0.33%
PriceFeed::public_dispatch	4,058 (-14)	-0.34%
TokenBlacklist::get_roles	2,785 (-10)	-0.36%
Spam::public_dispatch	3,829 (-14)	-0.36%
EasyPrivateVoting::public_dispatch	6,112 (-23)	-0.37%
InclusionProofs::constructor	2,633 (-10)	-0.38%
AvmInitializerTest::constructor	2,557 (-10)	-0.39%
Child::public_dispatch	6,115 (-26)	-0.42%
DocsExample::public_dispatch	6,066 (-26)	-0.43%
Test::public_dispatch	20,276 (-88)	-0.43%
StatefulTest::public_dispatch	8,139 (-36)	-0.44%
AppSubscription::public_dispatch	5,037 (-23)	-0.45%
Router::public_dispatch	2,612 (-13)	-0.50%
StaticParent::public_dispatch	7,339 (-39)	-0.53%
Crowdfunding::public_dispatch	6,241 (-36)	-0.57%
AuthRegistry::public_dispatch	8,466 (-49)	-0.58%
AuthWitTest::public_dispatch	1,971 (-13)	-0.66%
StaticChild::public_dispatch	3,152 (-26)	-0.82%
InclusionProofs::public_dispatch	4,196 (-36)	-0.85%
FPC::public_dispatch	8,389 (-84)	-0.99%

* master: (281 commits) fix: don't take down runners with faulty runner check (#10019) feat(docs): add transaction profiler docs (#9932) chore: hotfix runner wait (#10018) refactor: remove EnqueuedCallSimulator (#10015) refactor: stop calling public kernels (#9971) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg chore: drop info to verbose in sequencer hot loop (#9983) refactor: Trace structure is an object (#10003) refactor: enqueued calls processor -> public tx simulator (#9919) chore: World state tech debt cleanup 1 (#9561) chore(ci): run noir tests in parallel to building e2e tests (#9977) Revert "chore: lower throughput of ebs disks" (#9996) feat: new proving broker implementation (#9400) chore: replace `to_radix` directive with brillig (#9970) chore: disable failing 48validator kind test (#9920) test: prove one epoch in kind (#9886) fix: formatting (#9979) ...

alexghr changed the title ~~Ag/kind proving test~~ test: prove one epoch in kind Nov 12, 2024

alexghr marked this pull request as ready for review November 12, 2024 10:50

alexghr force-pushed the ag/kind-proving-test branch 2 times, most recently from 9e35696 to 10a520b Compare November 12, 2024 10:57

spalladino approved these changes Nov 12, 2024

View reviewed changes

alexghr force-pushed the ag/kind-proving-test branch from 57b042d to 1de28a1 Compare November 13, 2024 13:25

PhilWindle requested changes Nov 13, 2024

View reviewed changes

Alex Gherghisan added 17 commits November 14, 2024 14:09

test: nightly test that we can prove epochs

cc1b9c2

fix: tweak helm install timeout

6410ef4

fix: verifier deployment

f180caf

fix: add metrics to metrics yaml

5c23f39

chore: disable reorg test due to timeouts

590c658

chore: timeouts

4c82946

fix: cleanup kind cluster at the end

24f77f2

fix: explicitely stop stern

414a0c6

fix: re-enable proving test

1035d02

fix: increase stern ulimit

1ac516b

fix: enable retries in setup-protocol-contracts

aa4b9c3

fix: only init fee juice is uniitialized

250f69f

fix: add heartbeat

430bd24

fix: cleanup cluster at the end

89736b6

fix: change runner image

611f6d2

fix: change ubuntu ver

a7644f5

chore: undo changes

10ad49b

alexghr force-pushed the ag/kind-proving-test branch from 1bfbfea to 10ad49b Compare November 14, 2024 14:09

fix: dupelicate yaml entry

ebb8ede

PhilWindle approved these changes Nov 14, 2024

View reviewed changes

alexghr enabled auto-merge (squash) November 14, 2024 15:37

alexghr merged commit 44ea5fb into master Nov 15, 2024

alexghr deleted the ag/kind-proving-test branch November 15, 2024 10:00

AztecBot mentioned this pull request Nov 15, 2024

chore(master): Release 0.63.0 #9651

Merged

alexghr linked an issue Nov 18, 2024 that may be closed by this pull request

test: Epoch proving #9876

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: prove one epoch in kind#9886

test: prove one epoch in kind#9886
alexghr merged 18 commits intomasterfrom
ag/kind-proving-test

alexghr commented Nov 11, 2024

Uh oh!

spalladino left a comment •

edited

Loading

Uh oh!

github-actions bot commented Nov 13, 2024 •

edited

Loading

Uh oh!

PhilWindle Nov 13, 2024

Uh oh!

PhilWindle Nov 13, 2024

Uh oh!

github-actions bot commented Nov 13, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

alexghr commented Nov 11, 2024

Uh oh!

spalladino left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

Uh oh!

PhilWindle Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

PhilWindle Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes to public function bytecode sizes

🧾 Summary (100% most significant diffs)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

spalladino left a comment •

edited

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading