Merged
Conversation
sklppy88
approved these changes
Nov 8, 2024
Contributor
sklppy88
left a comment
sklppy88
left a comment
There was a problem hiding this comment.
Very nice. Looking fwd to 0 warnings 😄
nventuro
added a commit
that referenced
this pull request
Nov 11, 2024
Similar to #9819, except I'm now also replacing some usage of `storage[]` for `get` and `set`, and I added some constraining comments.
AztecBot
pushed a commit
to AztecProtocol/aztec-nr
that referenced
this pull request
Nov 12, 2024
Similar to AztecProtocol/aztec-packages#9819, except I'm now also replacing some usage of `storage[]` for `get` and `set`, and I added some constraining comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are mostly:
pub(some I madepub(crate)since they were clearly internals, such as our testing mocks)BoundedVec::storage())