Merged
Conversation
…ang/noir#6413) feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)
* master: (83 commits) fix: update solhint (#9399) chore: redo typo PR by leopardracer (#9705) feat: Encode static error strings in the ABI (#9552) chore: redo typo PR by donatik27 (#9693) chore: update install instructions for foundry to display version of rust to install (#9653) chore: disable bench upload until #9692 fix: earthly-ci in bench-e2e (#9689) chore: redo typo PR by cypherpepe (#9687) chore: redo typo PR by youyyytrok (#9686) chore: redo typo PR by mdqst (#9685) chore: redo typo PR by mdqst (#9684) feat: adding tags to encrypted logs (#9566) fix: enable gerousia e2e test (#9677) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg chore: redo typo PR by dsarfed (#9667) fix: bench e2e jobs (#9662) fix: Fix random for Mac users (#9670) ...
TomAFrench
reviewed
Nov 4, 2024
Comment on lines
+84
to
+85
| // TODO: what to do here? | ||
| 11 => ProcedureId::RevertWithString("".to_string()), |
Member
There was a problem hiding this comment.
@vezenovm FYI that we can't enumerate all potential ProcedureIds anymore as they can now contain strings. I've just had this method return an empty string but you may need to consider how this affects the flamegraphs.
Member
|
@guipublic This is reporting that the protocol circuits are not solvable. |
TomAFrench
reviewed
Nov 4, 2024
noir/noir-repo/compiler/noirc_evaluator/src/ssa/function_builder/mod.rs
Outdated
Show resolved
Hide resolved
TomAFrench
approved these changes
Nov 4, 2024
This was referenced Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat: nargo command to generate shell completions (noir-lang/noir#6413)
feat: ensure that generated ACIR is solvable (noir-lang/noir#6415)
fix: fix Alias and Error kinds (noir-lang/noir#6426)
fix: type-check turbofish in trait before function call (noir-lang/noir#6416)
chore: create a regression test for #6420 (noir-lang/noir#6421)
chore: Release Noir(0.37.0) (noir-lang/noir#6321)
chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419)
feat!: remove mimc from stdlib (noir-lang/noir#6402)
chore: Replace dead link with updated route in README (noir-lang/noir#6392)
feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396)
feat: improve malformed test attribute error (noir-lang/noir#6414)
fix: aliases in path (noir-lang/noir#6399)
feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385)
chore(lsp): Remove profile code lens (noir-lang/noir#6411)
chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406)
fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404)
fix: numeric generic doesn't have a default type (noir-lang/noir#6405)
feat: Sync from aztec-packages (noir-lang/noir#6403)
chore: add regression tests for #4372 (noir-lang/noir#6401)
chore: add regression tests for #6314 (noir-lang/noir#6381)
END_COMMIT_OVERRIDE