Conversation
Thunkar
commented
Nov 5, 2024
Thunkar
commented
Nov 5, 2024
Thunkar
commented
Nov 5, 2024
Thunkar
commented
Nov 5, 2024
… gj/process_tagged_logs
nventuro
reviewed
Nov 6, 2024
Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
…ec-packages into gj/process_tagged_logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #9371 #9370 #9372
Blindly moves the logic in
note_processor.tsto thesimulator_oracle, so retrieved logs can be processed and injected in PXE's db. This approach has several problems:compute_note_hash_and_nullifier. This either implies moving lot of stuff intoclient_execution_context(namely, the key store), or a chicken and egg problem withsimulator_oracle(we need a simulator in the oracle that is provided to a simulator). Right now a very ugly solution is adopted, instantiating a new simulator in place.Are deferred notes even necessary now?No, will be removed in Remove note processor in favor of new approach #9575dataStartIndexForTxall the way from the node to compute the note index? (this is not too bad IMO)aztec.nr?