Skip to content

feat: Sync from noir#9569

Merged
TomAFrench merged 5 commits intomasterfrom
sync-noir
Oct 30, 2024
Merged

feat: Sync from noir#9569
TomAFrench merged 5 commits intomasterfrom
sync-noir

Conversation

@AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented Oct 30, 2024

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: use array instead of Vec in keccak256 (noir-lang/noir#6395)
fix: make keccak256 work with input lengths greater than 136 bytes (noir-lang/noir#6393)
feat: support specifying generics on a struct when calling an associated function (noir-lang/noir#6306)
fix: Display every bit in integer tokens (noir-lang/noir#6360)
feat: better LSP hover for functions (noir-lang/noir#6376)
feat: Add capacities to brillig vectors and use them in slice ops (noir-lang/noir#6332)
feat: suggest removing ! from macro call that doesn't return Quoted (noir-lang/noir#6384)
fix: (formatter) correctly format quote delimiters (noir-lang/noir#6377)
fix: allow globals in format strings (noir-lang/noir#6382)
END_COMMIT_OVERRIDE

AztecBot and others added 3 commits October 30, 2024 08:02
[1 changes] chore: use array instead of Vec in keccak256 (noir-lang/n…
81fa94c 
…oir#6395)

fix: make keccak256 work with input lengths greater than 136 bytes (noir-lang/noir#6393)
feat: support specifying generics on a struct when calling an associated function (noir-lang/noir#6306)
fix: Display every bit in integer tokens (noir-lang/noir#6360)
feat: better LSP hover for functions (noir-lang/noir#6376)
feat: Add capacities to brillig vectors and use them in slice ops (noir-lang/noir#6332)
feat: suggest removing `!` from macro call that doesn't return Quoted (noir-lang/noir#6384)
fix: (formatter) correctly format quote delimiters (noir-lang/noir#6377)
fix: allow globals in format strings (noir-lang/noir#6382)
chore: apply sync fixes
49398d4
@sirasistant
Merge branch 'master' into sync-noir
4523b29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

Changes to public function bytecode sizes

Generated at commit: 70bf3cbdc0206e823615406ae73c1a7dbe8a9f81, compared to commit: 9d66c1abca1af9ddb0715627fad87c2efc612a1d

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
FPC::pay_refund_with_shielded_rebate +393 ❌ +32.83%
Lending::borrow_public +411 ❌ +30.76%
Lending::withdraw_public +411 ❌ +30.76%
FPC::prepare_fee +411 ❌ +29.15%
FPC::pay_refund +411 ❌ +28.36%
Parent::public_static_call +207 ❌ +24.50%
StaticParent::public_static_call +207 ❌ +24.50%
Lending::repay_public +444 ❌ +24.37%
Lending::deposit_public +453 ❌ +23.50%
StaticParent::public_nested_static_call +409 ❌ +22.04%
Benchmarking::increment_balance +392 ❌ +12.62%
StatefulTest::public_constructor +392 ❌ +12.17%
Child::set_value_with_two_nested_calls +80 ❌ +8.39%
Benchmarking::public_dispatch +405 ❌ +8.07%
AvmTest::nested_static_call_to_set_storage +33 ❌ +7.88%
ImportTest::pub_call_public_fn +33 ❌ +7.86%
StaticParent::public_dispatch +508 ❌ +7.81%
AvmTest::create_same_nullifier_in_nested_call +33 ❌ +7.76%
Parent::pub_entry_point_twice +66 ❌ +7.67%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 +434 ❌ +7.63%
AvmTest::create_different_nullifier_in_nested_call +33 ❌ +7.59%
Parent::pub_entry_point +33 ❌ +6.75%
StaticParent::public_call +33 ❌ +6.75%
AuthWitTest::consume_public +33 ❌ +6.38%
FPC::public_dispatch +502 ❌ +5.94%
Lending::_withdraw +476 ❌ +5.76%
Lending::_borrow +458 ❌ +5.71%
Child::public_dispatch +308 ❌ +5.71%
StatefulTest::public_dispatch +391 ❌ +5.36%
TokenBridge::exit_to_l1_public +392 ❌ +5.23%
Parent::public_dispatch +338 ❌ +4.30%
Child::set_value_twice_with_nested_first +46 ❌ +4.26%
Child::set_value_twice_with_nested_last +46 ❌ +4.26%
Child::pub_set_value +14 ❌ +4.22%
StaticChild::pub_set_value +14 ❌ +4.22%
Uniswap::swap_public +584 ❌ +4.00%
AvmTest::nested_call_to_add_with_gas +32 ❌ +3.88%
StaticParent::public_get_value_from_child +32 ❌ +3.83%
AvmTest::nested_static_call_to_add +32 ❌ +3.77%
AvmTest::nested_call_to_assert_same +32 ❌ +3.77%
AvmTest::nested_call_to_add +32 ❌ +3.77%
TokenBridge::_call_mint_on_token +32 ❌ +3.76%
DocsExample::get_shared_immutable_constrained_public_indirect +32 ❌ +3.57%
TokenBridge::claim_public +392 ❌ +3.48%
AvmTest::revert_oracle +13 ❌ +3.47%
Uniswap::_assert_token_is_same +32 ❌ +3.46%
AvmTest::debug_logging +38 ❌ +3.08%
AvmTest::returndata_copy_oracle +55 ❌ +2.98%
Test::emit_unencrypted +40 ❌ +2.53%
TokenBridge::public_dispatch +466 ❌ +2.22%
Lending::public_dispatch +568 ❌ +2.14%
ImportTest::public_dispatch +31 ❌ +2.11%
Uniswap::public_dispatch +478 ❌ +2.02%
Child::pub_inc_value +13 ❌ +1.79%
StaticChild::pub_inc_value +13 ❌ +1.79%
AuthWitTest::public_dispatch +31 ❌ +1.75%
StaticChild::pub_illegal_inc_value +13 ❌ +1.73%
Child::pub_inc_value_internal +13 ❌ +1.72%
AvmTest::emit_unencrypted_log +40 ❌ +1.41%
StaticChild::public_dispatch +40 ❌ +1.41%
Lending::_deposit +32 ❌ +1.14%
Parent::public_nested_static_call +31 ❌ +0.98%
Crowdfunding::_publish_donation_receipts +12 ❌ +0.94%
NFT::transfer_in_public +32 ❌ +0.93%
Token::burn_public +32 ❌ +0.74%
Token::transfer_public +32 ❌ +0.72%
Benchmarking::broadcast +13 ❌ +0.70%
TestLog::emit_unencrypted_events +12 ❌ +0.68%
Token::shield +32 ❌ +0.65%
AvmTest::public_dispatch +340 ❌ +0.59%
TokenBlacklist::burn_public +32 ❌ +0.58%
DocsExample::public_dispatch +31 ❌ +0.56%
Lending::_repay +32 ❌ +0.56%
TokenBlacklist::transfer_public +32 ❌ +0.54%
TokenBlacklist::shield +32 ❌ +0.53%
TestLog::public_dispatch +12 ❌ +0.38%
Test::public_dispatch +40 ❌ +0.21%
Token::complete_refund +12 ❌ +0.21%
Crowdfunding::public_dispatch +12 ❌ +0.20%
NFT::finalize_transfer_to_private +12 ❌ +0.20%
NFT::_finalize_transfer_to_private_unsafe +12 ❌ +0.20%
NFT::public_dispatch +45 ❌ +0.18%
Token::public_dispatch +45 ❌ +0.14%
TokenBlacklist::public_dispatch +31 ❌ +0.13%
AvmTest::bulk_testing +15 ❌ +0.06%
Test::consume_mint_public_message -1 ✅ -0.01%
CardGame::public_dispatch -2 ✅ -0.01%
TokenBlacklist::constructor -1 ✅ -0.01%
Test::consume_message_from_arbitrary_sender_public -1 ✅ -0.01%
TokenBlacklist::update_roles -1 ✅ -0.01%
CardGame::on_cards_claimed -1 ✅ -0.01%
CardGame::start_game -1 ✅ -0.01%
CardGame::on_card_played -1 ✅ -0.02%
Auth::set_authorized -1 ✅ -0.02%
Auth::set_authorized_delay -1 ✅ -0.02%
Lending::update_accumulator -1 ✅ -0.02%
Auth::public_dispatch -2 ✅ -0.02%
Lending::get_position -1 ✅ -0.02%
CardGame::on_game_joined -1 ✅ -0.02%
TokenBlacklist::mint_public -1 ✅ -0.02%
TokenBlacklist::mint_private -1 ✅ -0.02%
AuthRegistry::public_dispatch -2 ✅ -0.03%
AppSubscription::constructor -1 ✅ -0.03%
Crowdfunding::init -1 ✅ -0.03%
Token::mint_public -1 ✅ -0.03%
Token::mint_private -1 ✅ -0.03%
NFT::mint -1 ✅ -0.03%
Claim::constructor -1 ✅ -0.03%
TokenBridge::constructor -1 ✅ -0.03%
AuthRegistry::consume -1 ✅ -0.03%
EasyPrivateVoting::constructor -1 ✅ -0.03%
Lending::init -1 ✅ -0.03%
PrivateFPC::constructor -1 ✅ -0.03%
FeeJuice::public_dispatch -2 ✅ -0.03%
Auth::constructor -1 ✅ -0.03%
EasyPrivateVoting::public_dispatch -2 ✅ -0.03%
FPC::constructor -1 ✅ -0.03%
Uniswap::constructor -1 ✅ -0.03%
TokenBlacklist::_increase_public_balance -1 ✅ -0.04%
Token::_increase_public_balance -1 ✅ -0.04%
Spam::public_spam -1 ✅ -0.04%
NFT::owner_of -1 ✅ -0.04%
TokenBlacklist::get_roles -1 ✅ -0.04%
InclusionProofs::constructor -1 ✅ -0.04%
Token::constructor -2 ✅ -0.04%
FeeJuice::_increase_public_balance -1 ✅ -0.04%
Token::assert_minter_and_mint -1 ✅ -0.04%
AppSubscription::public_dispatch -2 ✅ -0.04%
AvmInitializerTest::constructor -1 ✅ -0.04%
EasyPrivateVoting::add_to_tally_public -1 ✅ -0.04%
NFT::constructor -2 ✅ -0.04%
FeeJuice::check_balance -1 ✅ -0.04%
Auth::get_authorized_delay -1 ✅ -0.05%
AvmTest::add_storage_map -1 ✅ -0.05%
Lending::get_asset -1 ✅ -0.05%
NFT::set_minter -1 ✅ -0.05%
Token::set_minter -1 ✅ -0.05%
Claim::public_dispatch -2 ✅ -0.05%
StatefulTest::increment_public_value -1 ✅ -0.05%
AuthRegistry::is_consumable -1 ✅ -0.05%
Test::create_l2_to_l1_message_public -1 ✅ -0.05%
StatefulTest::increment_public_value_no_init_check -1 ✅ -0.05%
InclusionProofs::public_dispatch -2 ✅ -0.05%
PrivateFPC::public_dispatch -2 ✅ -0.05%
TokenBlacklist::balance_of_public -1 ✅ -0.05%
Token::balance_of_public -1 ✅ -0.05%
AuthRegistry::_set_authorized -1 ✅ -0.05%
FeeJuice::balance_of_public -1 ✅ -0.05%
Auth::get_authorized -1 ✅ -0.05%
PriceFeed::public_dispatch -2 ✅ -0.05%
AuthRegistry::set_authorized -1 ✅ -0.05%
NFT::is_minter -1 ✅ -0.05%
Token::is_minter -1 ✅ -0.05%
AvmTest::sha256_hash -2 ✅ -0.05%
PriceFeed::get_price -1 ✅ -0.05%
AuthRegistry::is_reject_all -1 ✅ -0.05%
AvmTest::set_storage_map -1 ✅ -0.05%
StatefulTest::get_public_value -1 ✅ -0.05%
PriceFeed::set_price -1 ✅ -0.06%
Auth::get_scheduled_authorized -1 ✅ -0.06%
AvmTest::read_storage_map -1 ✅ -0.06%
Spam::public_dispatch -2 ✅ -0.06%
NFT::_finish_transfer_to_public -1 ✅ -0.06%
AuthRegistry::set_reject_all -1 ✅ -0.06%
AvmInitializerTest::public_dispatch -2 ✅ -0.06%
AvmTest::pedersen_hash -2 ✅ -0.07%
AvmTest::pedersen_hash_with_index -2 ✅ -0.07%
Router::public_dispatch -2 ✅ -0.08%
AvmTest::pedersen_commit -1 ✅ -0.09%
Token::_reduce_total_supply -1 ✅ -0.10%
TokenBlacklist::_reduce_total_supply -1 ✅ -0.10%
FeeJuice::set_portal -1 ✅ -0.10%
Router::_check_timestamp -1 ✅ -0.12%
AvmTest::get_args_hash -2 ✅ -0.12%
Router::_check_block_number -1 ✅ -0.12%
DocsExample::initialize_public_immutable -1 ✅ -0.12%
DocsExample::initialize_shared_immutable -1 ✅ -0.12%
AvmTest::poseidon2_hash -2 ✅ -0.12%
NFT::set_admin -1 ✅ -0.14%
Token::set_admin -1 ✅ -0.14%
EasyPrivateVoting::end_vote -1 ✅ -0.14%
AvmTest::set_read_storage_single -1 ✅ -0.15%
NFT::_store_payload_in_transient_storage_unsafe -2 ✅ -0.15%
Token::_store_payload_in_transient_storage_unsafe -2 ✅ -0.15%
TokenBlacklist::total_supply -1 ✅ -0.16%
Token::total_supply -1 ✅ -0.16%
TokenBridge::get_portal_address_public -1 ✅ -0.18%
TokenBridge::_assert_token_is_same -1 ✅ -0.19%
DocsExample::get_shared_immutable_constrained_public -1 ✅ -0.19%
Token::public_get_decimals -1 ✅ -0.19%
NFT::public_get_name -1 ✅ -0.19%
NFT::get_admin -1 ✅ -0.19%
Token::public_get_symbol -1 ✅ -0.19%
Token::public_get_name -1 ✅ -0.19%
NFT::public_get_symbol -1 ✅ -0.19%
TokenBridge::get_token -1 ✅ -0.19%
Token::get_admin -1 ✅ -0.19%
AvmInitializerTest::read_storage_immutable -1 ✅ -0.20%
AvmTest::keccak_f1600 -1 ✅ -0.21%
AvmTest::read_storage_single -1 ✅ -0.22%
AvmTest::assert_calldata_copy -1 ✅ -0.22%
Lending::get_assets -2 ✅ -0.25%
AvmTest::to_radix_le -1 ✅ -0.26%
DocsExample::get_shared_immutable_constrained_public_multiple -2 ✅ -0.28%
AvmTest::return_oracle -1 ✅ -0.29%
AvmTest::read_storage_list -2 ✅ -0.32%
AvmTest::keccak_hash -243 ✅ -8.57%
Full diff report 👇
Program Bytecode size in bytes (+/-) %
FPC::pay_refund_with_shielded_rebate 1,590 (+393) +32.83%
Lending::borrow_public 1,747 (+411) +30.76%
Lending::withdraw_public 1,747 (+411) +30.76%
FPC::prepare_fee 1,821 (+411) +29.15%
FPC::pay_refund 1,860 (+411) +28.36%
Parent::public_static_call 1,052 (+207) +24.50%
StaticParent::public_static_call 1,052 (+207) +24.50%
Lending::repay_public 2,266 (+444) +24.37%
Lending::deposit_public 2,381 (+453) +23.50%
StaticParent::public_nested_static_call 2,265 (+409) +22.04%
Benchmarking::increment_balance 3,497 (+392) +12.62%
StatefulTest::public_constructor 3,614 (+392) +12.17%
Child::set_value_with_two_nested_calls 1,034 (+80) +8.39%
Benchmarking::public_dispatch 5,423 (+405) +8.07%
AvmTest::nested_static_call_to_set_storage 452 (+33) +7.88%
ImportTest::pub_call_public_fn 453 (+33) +7.86%
StaticParent::public_dispatch 7,016 (+508) +7.81%
AvmTest::create_same_nullifier_in_nested_call 458 (+33) +7.76%
Parent::pub_entry_point_twice 926 (+66) +7.67%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 6,121 (+434) +7.63%
AvmTest::create_different_nullifier_in_nested_call 468 (+33) +7.59%
Parent::pub_entry_point 522 (+33) +6.75%
StaticParent::public_call 522 (+33) +6.75%
AuthWitTest::consume_public 550 (+33) +6.38%
FPC::public_dispatch 8,958 (+502) +5.94%
Lending::_withdraw 8,737 (+476) +5.76%
Lending::_borrow 8,475 (+458) +5.71%
Child::public_dispatch 5,706 (+308) +5.71%
StatefulTest::public_dispatch 7,692 (+391) +5.36%
TokenBridge::exit_to_l1_public 7,894 (+392) +5.23%
Parent::public_dispatch 8,197 (+338) +4.30%
Child::set_value_twice_with_nested_first 1,126 (+46) +4.26%
Child::set_value_twice_with_nested_last 1,126 (+46) +4.26%
Child::pub_set_value 346 (+14) +4.22%
StaticChild::pub_set_value 346 (+14) +4.22%
Uniswap::swap_public 15,193 (+584) +4.00%
AvmTest::nested_call_to_add_with_gas 856 (+32) +3.88%
StaticParent::public_get_value_from_child 867 (+32) +3.83%
AvmTest::nested_static_call_to_add 881 (+32) +3.77%
AvmTest::nested_call_to_assert_same 881 (+32) +3.77%
AvmTest::nested_call_to_add 881 (+32) +3.77%
TokenBridge::_call_mint_on_token 882 (+32) +3.76%
DocsExample::get_shared_immutable_constrained_public_indirect 929 (+32) +3.57%
TokenBridge::claim_public 11,669 (+392) +3.48%
AvmTest::revert_oracle 388 (+13) +3.47%
Uniswap::_assert_token_is_same 956 (+32) +3.46%
AvmTest::debug_logging 1,270 (+38) +3.08%
AvmTest::returndata_copy_oracle 1,899 (+55) +2.98%
Test::emit_unencrypted 1,622 (+40) +2.53%
TokenBridge::public_dispatch 21,442 (+466) +2.22%
Lending::public_dispatch 27,079 (+568) +2.14%
ImportTest::public_dispatch 1,497 (+31) +2.11%
Uniswap::public_dispatch 24,139 (+478) +2.02%
Child::pub_inc_value 741 (+13) +1.79%
StaticChild::pub_inc_value 741 (+13) +1.79%
AuthWitTest::public_dispatch 1,798 (+31) +1.75%
StaticChild::pub_illegal_inc_value 766 (+13) +1.73%
Child::pub_inc_value_internal 771 (+13) +1.72%
AvmTest::emit_unencrypted_log 2,877 (+40) +1.41%
StaticChild::public_dispatch 2,880 (+40) +1.41%
Lending::_deposit 2,849 (+32) +1.14%
Parent::public_nested_static_call 3,198 (+31) +0.98%
Crowdfunding::_publish_donation_receipts 1,283 (+12) +0.94%
NFT::transfer_in_public 3,466 (+32) +0.93%
Token::burn_public 4,381 (+32) +0.74%
Token::transfer_public 4,493 (+32) +0.72%
Benchmarking::broadcast 1,874 (+13) +0.70%
TestLog::emit_unencrypted_events 1,765 (+12) +0.68%
Token::shield 4,922 (+32) +0.65%
AvmTest::public_dispatch 57,678 (+340) +0.59%
TokenBlacklist::burn_public 5,506 (+32) +0.58%
DocsExample::public_dispatch 5,526 (+31) +0.56%
Lending::_repay 5,761 (+32) +0.56%
TokenBlacklist::transfer_public 5,913 (+32) +0.54%
TokenBlacklist::shield 6,052 (+32) +0.53%
TestLog::public_dispatch 3,154 (+12) +0.38%
Test::public_dispatch 18,769 (+40) +0.21%
Token::complete_refund 5,706 (+12) +0.21%
Crowdfunding::public_dispatch 5,880 (+12) +0.20%
NFT::finalize_transfer_to_private 6,109 (+12) +0.20%
NFT::_finalize_transfer_to_private_unsafe 6,140 (+12) +0.20%
NFT::public_dispatch 24,994 (+45) +0.18%
Token::public_dispatch 31,647 (+45) +0.14%
TokenBlacklist::public_dispatch 23,992 (+31) +0.13%
AvmTest::bulk_testing 24,961 (+15) +0.06%
Test::consume_mint_public_message 9,941 (-1) -0.01%
CardGame::public_dispatch 15,846 (-2) -0.01%
TokenBlacklist::constructor 7,496 (-1) -0.01%
Test::consume_message_from_arbitrary_sender_public 7,423 (-1) -0.01%
TokenBlacklist::update_roles 7,267 (-1) -0.01%
CardGame::on_cards_claimed 7,132 (-1) -0.01%
CardGame::start_game 6,820 (-1) -0.01%
CardGame::on_card_played 5,717 (-1) -0.02%
Auth::set_authorized 5,716 (-1) -0.02%
Auth::set_authorized_delay 5,636 (-1) -0.02%
Lending::update_accumulator 5,378 (-1) -0.02%
Auth::public_dispatch 10,182 (-2) -0.02%
Lending::get_position 4,866 (-1) -0.02%
CardGame::on_game_joined 4,832 (-1) -0.02%
TokenBlacklist::mint_public 4,321 (-1) -0.02%
TokenBlacklist::mint_private 4,068 (-1) -0.02%
AuthRegistry::public_dispatch 7,982 (-2) -0.03%
AppSubscription::constructor 3,470 (-1) -0.03%
Crowdfunding::init 3,323 (-1) -0.03%
Token::mint_public 3,297 (-1) -0.03%
Token::mint_private 3,262 (-1) -0.03%
NFT::mint 3,124 (-1) -0.03%
Claim::constructor 3,073 (-1) -0.03%
TokenBridge::constructor 3,040 (-1) -0.03%
AuthRegistry::consume 3,036 (-1) -0.03%
EasyPrivateVoting::constructor 3,021 (-1) -0.03%
Lending::init 2,978 (-1) -0.03%
PrivateFPC::constructor 2,964 (-1) -0.03%
FeeJuice::public_dispatch 5,893 (-2) -0.03%
Auth::constructor 2,883 (-1) -0.03%
EasyPrivateVoting::public_dispatch 5,717 (-2) -0.03%
FPC::constructor 2,858 (-1) -0.03%
Uniswap::constructor 2,858 (-1) -0.03%
TokenBlacklist::_increase_public_balance 2,659 (-1) -0.04%
Token::_increase_public_balance 2,659 (-1) -0.04%
Spam::public_spam 2,616 (-1) -0.04%
NFT::owner_of 2,590 (-1) -0.04%
TokenBlacklist::get_roles 2,587 (-1) -0.04%
InclusionProofs::constructor 2,451 (-1) -0.04%
Token::constructor 4,847 (-2) -0.04%
FeeJuice::_increase_public_balance 2,420 (-1) -0.04%
Token::assert_minter_and_mint 2,404 (-1) -0.04%
AppSubscription::public_dispatch 4,762 (-2) -0.04%
AvmInitializerTest::constructor 2,367 (-1) -0.04%
EasyPrivateVoting::add_to_tally_public 2,363 (-1) -0.04%
NFT::constructor 4,499 (-2) -0.04%
FeeJuice::check_balance 2,237 (-1) -0.04%
Auth::get_authorized_delay 2,210 (-1) -0.05%
AvmTest::add_storage_map 2,188 (-1) -0.05%
Lending::get_asset 2,057 (-1) -0.05%
NFT::set_minter 2,049 (-1) -0.05%
Token::set_minter 2,044 (-1) -0.05%
Claim::public_dispatch 4,024 (-2) -0.05%
StatefulTest::increment_public_value 2,007 (-1) -0.05%
AuthRegistry::is_consumable 1,997 (-1) -0.05%
Test::create_l2_to_l1_message_public 1,978 (-1) -0.05%
StatefulTest::increment_public_value_no_init_check 1,974 (-1) -0.05%
InclusionProofs::public_dispatch 3,946 (-2) -0.05%
PrivateFPC::public_dispatch 3,910 (-2) -0.05%
TokenBlacklist::balance_of_public 1,954 (-1) -0.05%
Token::balance_of_public 1,954 (-1) -0.05%
AuthRegistry::_set_authorized 1,916 (-1) -0.05%
FeeJuice::balance_of_public 1,916 (-1) -0.05%
Auth::get_authorized 1,901 (-1) -0.05%
PriceFeed::public_dispatch 3,798 (-2) -0.05%
AuthRegistry::set_authorized 1,885 (-1) -0.05%
NFT::is_minter 1,872 (-1) -0.05%
Token::is_minter 1,872 (-1) -0.05%
AvmTest::sha256_hash 3,714 (-2) -0.05%
PriceFeed::get_price 1,852 (-1) -0.05%
AuthRegistry::is_reject_all 1,834 (-1) -0.05%
AvmTest::set_storage_map 1,832 (-1) -0.05%
StatefulTest::get_public_value 1,824 (-1) -0.05%
PriceFeed::set_price 1,812 (-1) -0.06%
Auth::get_scheduled_authorized 1,809 (-1) -0.06%
AvmTest::read_storage_map 1,809 (-1) -0.06%
Spam::public_dispatch 3,578 (-2) -0.06%
NFT::_finish_transfer_to_public 1,779 (-1) -0.06%
AuthRegistry::set_reject_all 1,727 (-1) -0.06%
AvmInitializerTest::public_dispatch 3,102 (-2) -0.06%
AvmTest::pedersen_hash 2,857 (-2) -0.07%
AvmTest::pedersen_hash_with_index 2,857 (-2) -0.07%
Router::public_dispatch 2,393 (-2) -0.08%
AvmTest::pedersen_commit 1,145 (-1) -0.09%
Token::_reduce_total_supply 974 (-1) -0.10%
TokenBlacklist::_reduce_total_supply 969 (-1) -0.10%
FeeJuice::set_portal 952 (-1) -0.10%
Router::_check_timestamp 867 (-1) -0.12%
AvmTest::get_args_hash 1,704 (-2) -0.12%
Router::_check_block_number 850 (-1) -0.12%
DocsExample::initialize_public_immutable 847 (-1) -0.12%
DocsExample::initialize_shared_immutable 847 (-1) -0.12%
AvmTest::poseidon2_hash 1,630 (-2) -0.12%
NFT::set_admin 703 (-1) -0.14%
Token::set_admin 703 (-1) -0.14%
EasyPrivateVoting::end_vote 702 (-1) -0.14%
AvmTest::set_read_storage_single 650 (-1) -0.15%
NFT::_store_payload_in_transient_storage_unsafe 1,289 (-2) -0.15%
Token::_store_payload_in_transient_storage_unsafe 1,289 (-2) -0.15%
TokenBlacklist::total_supply 620 (-1) -0.16%
Token::total_supply 620 (-1) -0.16%
TokenBridge::get_portal_address_public 555 (-1) -0.18%
TokenBridge::_assert_token_is_same 539 (-1) -0.19%
DocsExample::get_shared_immutable_constrained_public 538 (-1) -0.19%
Token::public_get_decimals 538 (-1) -0.19%
NFT::public_get_name 523 (-1) -0.19%
NFT::get_admin 523 (-1) -0.19%
Token::public_get_symbol 523 (-1) -0.19%
Token::public_get_name 523 (-1) -0.19%
NFT::public_get_symbol 518 (-1) -0.19%
TokenBridge::get_token 518 (-1) -0.19%
Token::get_admin 518 (-1) -0.19%
AvmInitializerTest::read_storage_immutable 493 (-1) -0.20%
AvmTest::keccak_f1600 468 (-1) -0.21%
AvmTest::read_storage_single 455 (-1) -0.22%
AvmTest::assert_calldata_copy 449 (-1) -0.22%
Lending::get_assets 797 (-2) -0.25%
AvmTest::to_radix_le 387 (-1) -0.26%
DocsExample::get_shared_immutable_constrained_public_multiple 705 (-2) -0.28%
AvmTest::return_oracle 338 (-1) -0.29%
AvmTest::read_storage_list 618 (-2) -0.32%
AvmTest::keccak_hash 2,593 (-243) -8.57%

@sirasistant
Copy link
Contributor

sirasistant commented Oct 30, 2024

Correctness issue, trying to revert noir-lang/noir#6375 to see if that's generating problems

@TomAFrench
Copy link
Member

TomAFrench commented Oct 30, 2024

Correctness issue, trying to revert noir-lang/noir#6375 to see if that's generating problems

Huh, that was included in the last sync (and was causing correctness issues) so not sure why it's reappearing.

@TomAFrench TomAFrench merged commit b82f3d1 into master Oct 30, 2024
@TomAFrench TomAFrench deleted the sync-noir branch October 30, 2024 11:32
@AztecBot AztecBot mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AztecBot @sirasistant @TomAFrench