Skip to content

example: add option for encoding in fromstring #9422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sklppy88 wants to merge 1 commit into from
Closed

example: add option for encoding in fromstring #9422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions yarn-project/foundation/src/fields/fields.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,14 +234,18 @@ export class Fr extends BaseField {
}

/**
* Creates a Fr instance from a hex string.
* @param buf - a hex encoded string.
* Creates a Fr instance from a string.
* @param buf - string with value.
* @param encoding - the encoding to use (default: hex)
* @returns the Fr instance
*/
static fromString(buf: string) {
return fromHexString(buf, Fr);
}
static fromString(buf: string, encoding: 'hex' | 'dec' = 'hex') {
if (encoding === 'hex') {
return fromHexString(buf, Fr);
}

return new Fr(BigInt(buf));
}
/** Arithmetic */

add(rhs: Fr) {
Expand Down Expand Up @@ -369,12 +373,17 @@ export class Fq extends BaseField {
}

/**
* Creates a Fq instance from a hex string.
* @param buf - a hex encoded string.
* Creates a Fq instance from a string.
* @param buf - string with value.
* @param encoding - the encoding to use (default: hex)
* @returns the Fq instance
*/
static fromString(buf: string) {
return fromHexString(buf, Fq);
static fromString(buf: string, encoding: 'hex' | 'dec' = 'hex') {
if (encoding === 'hex') {
return fromHexString(buf, Fq);
}

return new Fq(BigInt(buf));
}

static fromHighLow(high: Fr, low: Fr): Fq {
Expand Down