Skip to content

Cg/circuit builders#922

Merged
suyash67 merged 29 commits intomasterfrom
cg/circuit-builders
Jun 28, 2023
Merged

Cg/circuit builders#922
suyash67 merged 29 commits intomasterfrom
cg/circuit-builders

Conversation

@codygunton
Copy link
Copy Markdown
Contributor

@codygunton codygunton commented Jun 28, 2023 •
edited
Loading

Description

I forgot to squash when I merged #895.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

codygunton added 29 commits June 20, 2023 22:10
@codygunton
Use circuit constructor.
2dc4d77
@codygunton
Undo hack to stop exposing manifest.
0d186af
@codygunton
Update Bb
350ab82
@codygunton
Update Bb
ea69fc5
@codygunton
Bump Bb (need Mont conversion)
64c8ba7
@codygunton
Using builder and CircuitType
d488fc4
@codygunton
Fix some things break others.
ded2a64
@codygunton
Satisfy prettier?
2224d0f
@codygunton
Composer ~> Builder
aa6f850
@codygunton
composer ~> builder
f91ece9
@codygunton
mv dummy_composer.hpp and rename class.
86fa2cd
@codygunton
Clean change to settingss.
b3097e2
@codygunton
Bump Bb.
e3eed2f
@codygunton
Merge branch 'master' into cg/circuit-builders
019c759 
Weird stuff is happening
@codygunton
Note on compilation errors in tests.
f888db5
@codygunton
Try to satisfy clang-tidy.
4958f0a
@codygunton
Fix test that didn't compile before.
2b8e215
@codygunton
Merge branch 'master' into cg/circuit-builders
d19e5ee
@codygunton
Respond to comments and clean up
80d7d22
@codygunton
Fix typo and formatting.
ee71367
@codygunton
Merge branch 'master' into cg/circuit-builders
27b9a0a
@codygunton
Fix compilation post-merge
46b831f
@codygunton
It should be a Schnorr signature?
c10ae38
@codygunton
Merge branch 'master' into cg/circuit-builders
d5fe0d3
@codygunton
Revert to Ecdsa
ee3d9e0
@codygunton
Proposed fix.
bef4f57
@codygunton
Revert "Proposed fix."
aaeb225 
This reverts commit bef4f57.
@codygunton
Test Schnorr; update snapshot.
ec3fbf4 
Changing test description to reference Schnorr not Ecdsa leads to weird build error.
@codygunton
Rebuild WASM before making snapshot.
5d20a8d
@codygunton codygunton requested a review from suyash67 June 28, 2023 02:48
@suyash67 suyash67 merged commit 0c46b72 into master Jun 28, 2023
@suyash67 suyash67 deleted the cg/circuit-builders branch June 28, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suyash67 suyash67 suyash67 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codygunton @suyash67