fix: correct use of finalize_circuit in bb gates#9066
Closed
maramihali wants to merge 1 commit intomasterfrom
Closed
fix: correct use of finalize_circuit in bb gates#9066maramihali wants to merge 1 commit intomasterfrom
maramihali wants to merge 1 commit intomasterfrom
Conversation
Contributor
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
auto-merge was automatically disabled
October 8, 2024 16:38
Pull request was closed
Contributor
|
Subsumed by #9046 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In previous PR, I modified
bb gatesto return the number of gates after the circuit is finalised, not using an estimation withget_num_gates, but without settingensure_nonzeroto true, which means that the dummy gates added to ensure nonzero polynomials were not taken into account. This PR fixes it.