Skip to content

fix: Revert "feat: trace AVM side effects per enqueued call"#9058

Merged
ludamad merged 1 commit intomasterfrom
revert-8918-db/previous-lengths-in-avm-trace
Oct 7, 2024
Merged

fix: Revert "feat: trace AVM side effects per enqueued call"#9058
ludamad merged 1 commit intomasterfrom
revert-8918-db/previous-lengths-in-avm-trace

Conversation

@ludamad
Copy link
Collaborator

@ludamad ludamad commented Oct 7, 2024

Reverts #8918

This was breaking e2e-prover-full with

2024-10-07T18:38:39.5367651Z [36m    +e2e-prover-full[0m |   [34;1maztec:prover-client:prover-agent [0m[INFO] Agent is running with 2 in-flight jobs: id=cf7ebac9,type=BASE_ROLLUP id=5f3f9a1b,type=PUBLIC_KERNEL_INNER [34m+5s[0m
2024-10-07T18:38:45.3223814Z [36m    +e2e-prover-full[0m |   [36;1maztec:bb-prover [0m[INFO] Generated witness circuitName=base-rollup duration=14385.497549999971 inputSize=226276 outputSize=664 eventName=circuit-witness-generation [36m+7s[0m
2024-10-07T18:38:47.0520236Z [36m    +e2e-prover-full[0m |   [36;1maztec:bb-prover [0m[INFO] Generated proof for PublicKernelInnerArtifact in 8754 ms, size: 463 fields circuitName=public-kernel-inner circuitSize=524288 duration=8753.659793999977 inputSize=52672 proofSize=93892 eventName=circuit-proving numPublicInputs=2487 [36m+2s[0m
2024-10-07T18:38:47.1351455Z [36m    +e2e-prover-full[0m |   [36;1maztec:bb-prover [0m[INFO] Successfully verified proof from key in 79.74121499992907 ms [36m+84ms[0m
2024-10-07T18:38:47.1359511Z [36m    +e2e-prover-full[0m |   [34;1maztec:prover-client:prover-agent [0m[VERBOSE] Processed proving job id=5f3f9a1b type=PUBLIC_KERNEL_INNER duration=12543.893958999892ms [34m+8s[0m
2024-10-07T18:38:47.2392290Z [36m    +e2e-prover-full[0m |   [36;1maztec:bb-prover [0m[INFO] Successfully verified proof from key in 84.31422300008126 ms [36m+104ms[0m
2024-10-07T18:38:48.1190928Z [36m    +e2e-prover-full[0m |   [36;1maztec:bb-prover [0m[INFO] Generated witness circuitName=public-kernel-merge duration=805.3169080000371 inputSize=259272 outputSize=70692 eventName=circuit-witness-generation [36m+879ms[0m
2024-10-07T18:39:03.8562729Z [36m    +e2e-prover-full[0m |   [36;1maztec:bb-prover [0m[INFO] Generated proof for PublicKernelMergeArtifact in 15727 ms, size: 463 fields circuitName=public-kernel-merge circuitSize=2097152 duration=15726.628410000005 inputSize=70692 proofSize=114852 eventName=circuit-proving numPublicInputs=3142 [36m+16s[0m
2024-10-07T18:39:03.9344666Z [36m    +e2e-prover-full[0m |   [36;1maztec:bb-prover [0m[ERROR] Error running operation at /usr/src/bb/tmp-qnclFA: Error: Failed to verify proof from key! [36m+78ms[0m
2024-10-07T18:39:03.9649933Z [36m    +e2e-prover-full[0m |   [34;1maztec:prover-client:prover-agent [0m[ERROR] Error processing proving job id=6f1c2b0f type=PUBLIC_KERNEL_MERGE: Error: Failed to verify proof from key!: Error: Failed to verify proof from key!
2024-10-07T18:39:03.9653074Z [36m    +e2e-prover-full[0m |     at operation (/usr/src/yarn-project/bb-prover/src/prover/bb_prover.ts:844:15)
2024-10-07T18:39:03.9655268Z [36m    +e2e-prover-full[0m |     at processTicksAndRejections (node:internal/process/task_queues:95:5)
2024-10-07T18:39:03.9656773Z [36m    +e2e-prover-full[0m |     at runInDirectory (/usr/src/yarn-project/foundation/src/fs/run_in_dir.ts:17:12)
2024-10-07T18:39:03.9658121Z [36m    +e2e-prover-full[0m |     at BBNativeRollupProver.verifyWithKeyInternal (/usr/src/yarn-project/bb-prover/src/prover/bb_prover.ts:850:5)
2024-10-07T18:39:03.9659432Z [36m    +e2e-prover-full[0m |     at BBNativeRollupProver.verifyWithKey (/usr/src/yarn-project/bb-prover/src/prover/bb_prover.ts:823:12)
2024-10-07T18:39:03.9660661Z [36m    +e2e-prover-full[0m |     at BBNativeRollupProver.verifyProof (/usr/src/yarn-project/bb-prover/src/prover/bb_prover.ts:813:12)
2024-10-07T18:39:03.9661954Z [36m    +e2e-prover-full[0m |     at BBNativeRollupProver.getPublicKernelMergeProof (/usr/src/yarn-project/bb-prover/src/prover/bb_prover.ts:280:5)
2024-10-07T18:39:03.9663070Z [36m    +e2e-prover-full[0m |     at /usr/src/yarn-project/telemetry-client/src/telemetry.ts:150:23
2024-10-07T18:39:03.9663983Z [36m    +e2e-prover-full[0m |     at elapsed (/usr/src/yarn-project/foundation/src/timer/elapsed.ts:10:18)
2024-10-07T18:39:03.9665120Z [36m    +e2e-prover-full[0m |     at ProverAgent.work (/usr/src/yarn-project/prover-client/src/prover-agent/prover-agent.ts:129:30) [34m+17s[0m
2024-10-07T18:39:03.9667083Z [36m    +e2e-prover-full[0m |   [34;1maztec:prover-client:prover-pool:queue [0m[WARN] Job id=6f1c2b0f type=PUBLIC_KERNEL_MERGE failed with error: Failed to verify proof from key!. Retry 2/3 [34m+11m[0m

@ludamad ludamad changed the title Revert "feat: trace AVM side effects per enqueued call" fix: Revert "feat: trace AVM side effects per enqueued call" Oct 7, 2024
@ludamad ludamad merged commit 06b36f5 into master Oct 7, 2024
@ludamad ludamad deleted the revert-8918-db/previous-lengths-in-avm-trace branch October 7, 2024 19:16
dbanks12 added a commit that referenced this pull request Oct 8, 2024
dbanks12 added a commit that referenced this pull request Oct 8, 2024
Reverts #9058

Revives the original PR with the bug fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant