feat(vc): re-execution before attestation#8958
Closed
Conversation
…timeouts_to_individual_reqresp_connections
Contributor
Changes to public function bytecode sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
fcarreiro
reviewed
Oct 3, 2024
| this.contractCallDepth.add(Fr.ONE), | ||
| this.transactionFee, | ||
| this.header, | ||
| this.historicalHeader, |
Contributor
There was a problem hiding this comment.
I think this is supposed to be the current header and not the historical one. IIRC public will not have access to historical headers, since that would force nodes to be archivers.
Contributor
Member
Author
There was a problem hiding this comment.
I updated it based on the public processor factory - it instantiates the avm executor with a variable called historical header - should this be updated instead?
Member
Author
|
superceeded by #9768 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Validators currently perform blind attestations to transaction updates
This pr introduces the notion of a light public processor (really light block builder, we can change the name) which
For calls which currently run lots of kernels ( nested calls ) this currently yields an extremely large performance increase.
In the current test which has an enqueued + 4 nested calls and multiple state updates block building time goes from 2.2seconds to 400 ms ( granted the archive is not calculated )
Downsides:
part of : #8720
Issues created from this work