Skip to content

feat: Sync from noir#8867

Merged
TomAFrench merged 17 commits intomasterfrom
sync-noir
Oct 1, 2024
Merged

feat: Sync from noir#8867
TomAFrench merged 17 commits intomasterfrom
sync-noir

Conversation

@AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented Sep 28, 2024 •
edited
Loading

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat(perf): Remove redundant inc rc without instructions between (noir-lang/noir#6183)
chore: reexport CrateName through nargo (noir-lang/noir#6177)
feat(perf): Remove inc_rc instructions for arrays which are never mutably borrowed (noir-lang/noir#6168)
chore(docs): Add link to more info about proving backend to Solidity verifier page (noir-lang/noir#5754)
feat: let Module::functions and Module::structs return them in definition order (noir-lang/noir#6178)
chore: split test_programs into modules (noir-lang/noir#6101)
chore: remove DefCollectorErrorKind::MacroError (noir-lang/noir#6174)
feat(ssa): Simplify signed casts (noir-lang/noir#6166)
feat: visibility for modules (noir-lang/noir#6165)
END_COMMIT_OVERRIDE

AztecBot and others added 9 commits September 28, 2024 08:02
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2024 •
edited
Loading

Changes to public function bytecode sizes

Generated at commit: 85ad9fb0521e48fd60800068be6e40ef84dff44f, compared to commit: 38b485e4e8bf75453491d41a590f92afa25d4831

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
AvmTest::keccak_hash -14 ✅ -0.51%
Benchmarking::increment_balance -28 ✅ -0.75%
TokenBlacklist::mint_public -84 ✅ -0.79%
AvmTest::get_args_hash -14 ✅ -0.85%
Spam::public_dispatch -42 ✅ -0.91%
CardGame::start_game -70 ✅ -0.95%
TokenBlacklist::get_roles -42 ✅ -1.00%
AuthRegistry::consume -84 ✅ -1.01%
AvmTest::u128_addition_overflow -14 ✅ -1.02%
Crowdfunding::_publish_donation_receipts -14 ✅ -1.09%
Lending::_deposit -28 ✅ -1.12%
AppSubscription::constructor -70 ✅ -1.15%
CardGame::on_game_joined -56 ✅ -1.16%
CardGame::on_card_played -70 ✅ -1.17%
Lending::_repay -112 ✅ -1.18%
AvmTest::pedersen_hash -42 ✅ -1.22%
AvmTest::pedersen_hash_with_index -42 ✅ -1.22%
Token::mint_private -56 ✅ -1.26%
AvmTest::bulk_testing -406 ✅ -1.27%
CardGame::on_cards_claimed -98 ✅ -1.29%
TestLog::emit_unencrypted_events -28 ✅ -1.30%
Crowdfunding::init -70 ✅ -1.36%
AppSubscription::public_dispatch -112 ✅ -1.38%
Auth::get_authorized_delay -42 ✅ -1.39%
TokenBlacklist::mint_private -98 ✅ -1.46%
Auth::get_authorized -42 ✅ -1.52%
Claim::constructor -70 ✅ -1.53%
CardGame::public_dispatch -442 ✅ -1.55%
EasyPrivateVoting::constructor -70 ✅ -1.57%
Auth::get_scheduled_authorized -42 ✅ -1.58%
AuthRegistry::public_dispatch -378 ✅ -1.60%
Benchmarking::public_dispatch -112 ✅ -1.64%
TokenBridge::constructor -70 ✅ -1.65%
Auth::constructor -70 ✅ -1.66%
FPC::constructor -70 ✅ -1.67%
Uniswap::constructor -70 ✅ -1.67%
Test::emit_unencrypted -28 ✅ -1.70%
PrivateFPC::constructor -70 ✅ -1.70%
NFT::finalize_transfer_to_private -98 ✅ -1.72%
Test::create_l2_to_l1_message_public -42 ✅ -1.77%
FeeJuice::public_dispatch -182 ✅ -1.81%
InclusionProofs::constructor -70 ✅ -1.85%
Lending::_borrow -280 ✅ -1.85%
AvmInitializerTest::public_dispatch -70 ✅ -1.89%
AvmTest::u128_from_integer_overflow -14 ✅ -1.90%
Claim::public_dispatch -112 ✅ -1.94%
AvmInitializerTest::constructor -56 ✅ -1.94%
PriceFeed::public_dispatch -98 ✅ -1.95%
TokenBlacklist::transfer_public -336 ✅ -2.06%
Test::consume_message_from_arbitrary_sender_public -182 ✅ -2.06%
PrivateFPC::public_dispatch -112 ✅ -2.11%
Auth::set_authorized -266 ✅ -2.24%
Lending::_withdraw -294 ✅ -2.25%
Auth::set_authorized_delay -266 ✅ -2.28%
Router::_check_timestamp -28 ✅ -2.29%
AvmTest::sha256_hash -84 ✅ -2.30%
Router::_check_block_number -28 ✅ -2.32%
TokenBlacklist::update_roles -392 ✅ -2.35%
Parent::public_nested_static_call -98 ✅ -2.38%
Test::consume_mint_public_message -336 ✅ -2.44%
TokenBridge::claim_public -378 ✅ -2.53%
StatefulTest::public_constructor -112 ✅ -2.58%
Token::transfer_public -252 ✅ -2.65%
TokenBlacklist::burn_public -294 ✅ -2.69%
NFT::public_dispatch -1,113 ✅ -2.76%
AvmTest::emit_unencrypted_log -84 ✅ -2.79%
TokenBlacklist::shield -350 ✅ -2.80%
TokenBridge::exit_to_l1_public -224 ✅ -2.81%
Token::public_dispatch -1,953 ✅ -2.91%
TokenBridge::public_dispatch -952 ✅ -2.94%
Token::constructor -238 ✅ -2.97%
AvmTest::variable_base_msm -14 ✅ -3.07%
NFT::constructor -238 ✅ -3.16%
AvmTest::assert_calldata_copy -14 ✅ -3.17%
InclusionProofs::public_dispatch -196 ✅ -3.36%
EasyPrivateVoting::public_dispatch -322 ✅ -3.39%
Auth::public_dispatch -1,141 ✅ -3.39%
TokenBridge::_call_mint_on_token -28 ✅ -3.50%
Router::public_dispatch -140 ✅ -3.51%
TestLog::public_dispatch -126 ✅ -3.52%
Token::shield -308 ✅ -3.54%
StatefulTest::public_dispatch -448 ✅ -3.54%
Token::burn_public -252 ✅ -3.56%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 -336 ✅ -3.65%
AvmTest::test_get_contract_instance_raw -14 ✅ -3.69%
TokenBlacklist::constructor -630 ✅ -3.72%
Lending::public_dispatch -2,926 ✅ -3.73%
Test::public_dispatch -1,274 ✅ -3.73%
Crowdfunding::public_dispatch -336 ✅ -3.95%
Delegator::public_dispatch -84 ✅ -3.98%
Token::complete_refund -140 ✅ -4.00%
FPC::public_dispatch -462 ✅ -4.06%
DelegatedOn::public_dispatch -56 ✅ -4.27%
Lending::withdraw_public -42 ✅ -4.33%
Lending::borrow_public -42 ✅ -4.33%
Child::set_value_twice_with_nested_first -28 ✅ -4.68%
Child::set_value_twice_with_nested_last -28 ✅ -4.68%
NFT::transfer_in_public -252 ✅ -4.73%
ImportTest::public_dispatch -70 ✅ -4.82%
Uniswap::swap_public -728 ✅ -4.83%
Uniswap::public_dispatch -1,708 ✅ -5.06%
FPC::prepare_fee -56 ✅ -5.29%
DocsExample::public_dispatch -336 ✅ -5.49%
AvmTest::public_dispatch -5,259 ✅ -5.54%
TokenBlacklist::public_dispatch -8,022 ✅ -5.68%
StaticChild::public_dispatch -224 ✅ -5.74%
FPC::pay_refund -84 ✅ -5.75%
AuthWitTest::public_dispatch -112 ✅ -6.00%
AvmTest::test_get_contract_instance -56 ✅ -6.24%
Lending::deposit_public -98 ✅ -6.30%
Parent::public_dispatch -714 ✅ -6.58%
Child::public_dispatch -364 ✅ -6.89%
Lending::repay_public -98 ✅ -7.07%
FPC::pay_refund_with_shielded_rebate -98 ✅ -7.26%
AvmTest::create_different_nullifier_in_nested_call -28 ✅ -7.61%
Child::set_value_with_two_nested_calls -56 ✅ -7.83%
AvmTest::create_same_nullifier_in_nested_call -28 ✅ -7.84%
ImportTest::pub_call_public_fn -28 ✅ -8.00%
AvmTest::nested_static_call_to_set_storage -28 ✅ -8.02%
StaticParent::public_dispatch -728 ✅ -9.52%
StaticParent::public_nested_static_call -126 ✅ -10.49%
Parent::public_static_call -70 ✅ -11.76%
StaticParent::public_static_call -70 ✅ -11.76%
AuthWitTest::consume_public -70 ✅ -14.26%
Parent::pub_entry_point -70 ✅ -15.98%
StaticParent::public_call -70 ✅ -15.98%
Uniswap::_assert_token_is_same -112 ✅ -20.14%
Parent::pub_entry_point_twice -140 ✅ -20.53%
DocsExample::get_shared_immutable_constrained_public_indirect -112 ✅ -21.58%
AvmTest::nested_static_call_to_add -112 ✅ -23.05%
AvmTest::nested_call_to_add -112 ✅ -23.05%
StaticParent::public_get_value_from_child -112 ✅ -23.78%
AvmTest::nested_call_to_add_with_gas -140 ✅ -27.83%
AvmTest::pedersen_commit -1,115 ✅ -76.11%
Full diff report 👇
Program Bytecode size in bytes (+/-) %
AvmTest::keccak_hash 2,719 (-14) -0.51%
Benchmarking::increment_balance 3,694 (-28) -0.75%
TokenBlacklist::mint_public 10,529 (-84) -0.79%
AvmTest::get_args_hash 1,632 (-14) -0.85%
Spam::public_dispatch 4,562 (-42) -0.91%
CardGame::start_game 7,285 (-70) -0.95%
TokenBlacklist::get_roles 4,174 (-42) -1.00%
AuthRegistry::consume 8,258 (-84) -1.01%
AvmTest::u128_addition_overflow 1,357 (-14) -1.02%
Crowdfunding::_publish_donation_receipts 1,276 (-14) -1.09%
Lending::_deposit 2,479 (-28) -1.12%
AppSubscription::constructor 6,021 (-70) -1.15%
CardGame::on_game_joined 4,767 (-56) -1.16%
CardGame::on_card_played 5,908 (-70) -1.17%
Lending::_repay 9,362 (-112) -1.18%
AvmTest::pedersen_hash 3,401 (-42) -1.22%
AvmTest::pedersen_hash_with_index 3,401 (-42) -1.22%
Token::mint_private 4,387 (-56) -1.26%
AvmTest::bulk_testing 31,458 (-406) -1.27%
CardGame::on_cards_claimed 7,475 (-98) -1.29%
TestLog::emit_unencrypted_events 2,130 (-28) -1.30%
Crowdfunding::init 5,079 (-70) -1.36%
AppSubscription::public_dispatch 7,990 (-112) -1.38%
Auth::get_authorized_delay 2,985 (-42) -1.39%
TokenBlacklist::mint_private 6,631 (-98) -1.46%
Auth::get_authorized 2,720 (-42) -1.52%
Claim::constructor 4,505 (-70) -1.53%
CardGame::public_dispatch 28,156 (-442) -1.55%
EasyPrivateVoting::constructor 4,390 (-70) -1.57%
Auth::get_scheduled_authorized 2,624 (-42) -1.58%
AuthRegistry::public_dispatch 23,251 (-378) -1.60%
Benchmarking::public_dispatch 6,734 (-112) -1.64%
TokenBridge::constructor 4,182 (-70) -1.65%
Auth::constructor 4,135 (-70) -1.66%
FPC::constructor 4,113 (-70) -1.67%
Uniswap::constructor 4,113 (-70) -1.67%
Test::emit_unencrypted 1,623 (-28) -1.70%
PrivateFPC::constructor 4,044 (-70) -1.70%
NFT::finalize_transfer_to_private 5,585 (-98) -1.72%
Test::create_l2_to_l1_message_public 2,330 (-42) -1.77%
FeeJuice::public_dispatch 9,875 (-182) -1.81%
InclusionProofs::constructor 3,715 (-70) -1.85%
Lending::_borrow 14,838 (-280) -1.85%
AvmInitializerTest::public_dispatch 3,636 (-70) -1.89%
AvmTest::u128_from_integer_overflow 723 (-14) -1.90%
Claim::public_dispatch 5,655 (-112) -1.94%
AvmInitializerTest::constructor 2,824 (-56) -1.94%
PriceFeed::public_dispatch 4,935 (-98) -1.95%
TokenBlacklist::transfer_public 16,013 (-336) -2.06%
Test::consume_message_from_arbitrary_sender_public 8,656 (-182) -2.06%
PrivateFPC::public_dispatch 5,194 (-112) -2.11%
Auth::set_authorized 11,618 (-266) -2.24%
Lending::_withdraw 12,754 (-294) -2.25%
Auth::set_authorized_delay 11,422 (-266) -2.28%
Router::_check_timestamp 1,197 (-28) -2.29%
AvmTest::sha256_hash 3,565 (-84) -2.30%
Router::_check_block_number 1,180 (-28) -2.32%
TokenBlacklist::update_roles 16,284 (-392) -2.35%
Parent::public_nested_static_call 4,024 (-98) -2.38%
Test::consume_mint_public_message 13,411 (-336) -2.44%
TokenBridge::claim_public 14,557 (-378) -2.53%
StatefulTest::public_constructor 4,225 (-112) -2.58%
Token::transfer_public 9,249 (-252) -2.65%
TokenBlacklist::burn_public 10,624 (-294) -2.69%
NFT::public_dispatch 39,211 (-1,113) -2.76%
AvmTest::emit_unencrypted_log 2,927 (-84) -2.79%
TokenBlacklist::shield 12,132 (-350) -2.80%
TokenBridge::exit_to_l1_public 7,761 (-224) -2.81%
Token::public_dispatch 65,223 (-1,953) -2.91%
TokenBridge::public_dispatch 31,443 (-952) -2.94%
Token::constructor 7,788 (-238) -2.97%
AvmTest::variable_base_msm 442 (-14) -3.07%
NFT::constructor 7,299 (-238) -3.16%
AvmTest::assert_calldata_copy 427 (-14) -3.17%
InclusionProofs::public_dispatch 5,630 (-196) -3.36%
EasyPrivateVoting::public_dispatch 9,177 (-322) -3.39%
Auth::public_dispatch 32,477 (-1,141) -3.39%
TokenBridge::_call_mint_on_token 771 (-28) -3.50%
Router::public_dispatch 3,847 (-140) -3.51%
TestLog::public_dispatch 3,455 (-126) -3.52%
Token::shield 8,397 (-308) -3.54%
StatefulTest::public_dispatch 12,206 (-448) -3.54%
Token::burn_public 6,828 (-252) -3.56%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 8,871 (-336) -3.65%
AvmTest::test_get_contract_instance_raw 365 (-14) -3.69%
TokenBlacklist::constructor 16,306 (-630) -3.72%
Lending::public_dispatch 75,524 (-2,926) -3.73%
Test::public_dispatch 32,850 (-1,274) -3.73%
Crowdfunding::public_dispatch 8,163 (-336) -3.95%
Delegator::public_dispatch 2,025 (-84) -3.98%
Token::complete_refund 3,356 (-140) -4.00%
FPC::public_dispatch 10,931 (-462) -4.06%
DelegatedOn::public_dispatch 1,256 (-56) -4.27%
Lending::withdraw_public 929 (-42) -4.33%
Lending::borrow_public 929 (-42) -4.33%
Child::set_value_twice_with_nested_first 570 (-28) -4.68%
Child::set_value_twice_with_nested_last 570 (-28) -4.68%
NFT::transfer_in_public 5,071 (-252) -4.73%
ImportTest::public_dispatch 1,382 (-70) -4.82%
Uniswap::swap_public 14,342 (-728) -4.83%
Uniswap::public_dispatch 32,019 (-1,708) -5.06%
FPC::prepare_fee 1,002 (-56) -5.29%
DocsExample::public_dispatch 5,782 (-336) -5.49%
AvmTest::public_dispatch 89,662 (-5,259) -5.54%
TokenBlacklist::public_dispatch 133,129 (-8,022) -5.68%
StaticChild::public_dispatch 3,679 (-224) -5.74%
FPC::pay_refund 1,377 (-84) -5.75%
AuthWitTest::public_dispatch 1,754 (-112) -6.00%
AvmTest::test_get_contract_instance 841 (-56) -6.24%
Lending::deposit_public 1,458 (-98) -6.30%
Parent::public_dispatch 10,145 (-714) -6.58%
Child::public_dispatch 4,922 (-364) -6.89%
Lending::repay_public 1,288 (-98) -7.07%
FPC::pay_refund_with_shielded_rebate 1,252 (-98) -7.26%
AvmTest::create_different_nullifier_in_nested_call 340 (-28) -7.61%
Child::set_value_with_two_nested_calls 659 (-56) -7.83%
AvmTest::create_same_nullifier_in_nested_call 329 (-28) -7.84%
ImportTest::pub_call_public_fn 322 (-28) -8.00%
AvmTest::nested_static_call_to_set_storage 321 (-28) -8.02%
StaticParent::public_dispatch 6,921 (-728) -9.52%
StaticParent::public_nested_static_call 1,075 (-126) -10.49%
Parent::public_static_call 525 (-70) -11.76%
StaticParent::public_static_call 525 (-70) -11.76%
AuthWitTest::consume_public 421 (-70) -14.26%
Parent::pub_entry_point 368 (-70) -15.98%
StaticParent::public_call 368 (-70) -15.98%
Uniswap::_assert_token_is_same 444 (-112) -20.14%
Parent::pub_entry_point_twice 542 (-140) -20.53%
DocsExample::get_shared_immutable_constrained_public_indirect 407 (-112) -21.58%
AvmTest::nested_static_call_to_add 374 (-112) -23.05%
AvmTest::nested_call_to_add 374 (-112) -23.05%
StaticParent::public_get_value_from_child 359 (-112) -23.78%
AvmTest::nested_call_to_add_with_gas 363 (-140) -27.83%
AvmTest::pedersen_commit 350 (-1,115) -76.11%

AztecBot and others added 7 commits September 30, 2024 23:07
[1 changes] feat(perf): Remove redundant inc rc without instructions …
27d6427 
…between (noir-lang/noir#6183)

chore: reexport `CrateName` through `nargo` (noir-lang/noir#6177)
feat(perf): Remove inc_rc instructions for arrays which are never mutably borrowed (noir-lang/noir#6168)
chore(docs): Add link to more info about proving backend to Solidity verifier page (noir-lang/noir#5754)
feat: let `Module::functions` and `Module::structs` return them in definition order (noir-lang/noir#6178)
chore: split `test_program`s into modules (noir-lang/noir#6101)
chore: remove `DefCollectorErrorKind::MacroError` (noir-lang/noir#6174)
feat(ssa): Simplify signed casts (noir-lang/noir#6166)
feat: visibility for modules (noir-lang/noir#6165)
chore: apply sync fixes
f1d0308
feat(perf): Remove redundant inc rc without instructions between (noi…
f9d7a14 
…r-lang/noir#6183)

chore: reexport `CrateName` through `nargo` (noir-lang/noir#6177)
feat(perf): Remove inc_rc instructions for arrays which are never mutably borrowed (noir-lang/noir#6168)
chore(docs): Add link to more info about proving backend to Solidity verifier page (noir-lang/noir#5754)
feat: let `Module::functions` and `Module::structs` return them in definition order (noir-lang/noir#6178)
chore: split `test_program`s into modules (noir-lang/noir#6101)
chore: remove `DefCollectorErrorKind::MacroError` (noir-lang/noir#6174)
feat(ssa): Simplify signed casts (noir-lang/noir#6166)
feat: visibility for modules (noir-lang/noir#6165)
[1 changes] feat(perf): Remove redundant inc rc without instructions …
9051b51 
…between (noir-lang/noir#6183)

chore: reexport `CrateName` through `nargo` (noir-lang/noir#6177)
feat(perf): Remove inc_rc instructions for arrays which are never mutably borrowed (noir-lang/noir#6168)
chore(docs): Add link to more info about proving backend to Solidity verifier page (noir-lang/noir#5754)
feat: let `Module::functions` and `Module::structs` return them in definition order (noir-lang/noir#6178)
chore: split `test_program`s into modules (noir-lang/noir#6101)
chore: remove `DefCollectorErrorKind::MacroError` (noir-lang/noir#6174)
feat(ssa): Simplify signed casts (noir-lang/noir#6166)
feat: visibility for modules (noir-lang/noir#6165)
chore: apply sync fixes
ea934f8
feat(perf): Remove redundant inc rc without instructions between (noi…
83426fc 
…r-lang/noir#6183)

chore: reexport `CrateName` through `nargo` (noir-lang/noir#6177)
feat(perf): Remove inc_rc instructions for arrays which are never mutably borrowed (noir-lang/noir#6168)
chore(docs): Add link to more info about proving backend to Solidity verifier page (noir-lang/noir#5754)
feat: let `Module::functions` and `Module::structs` return them in definition order (noir-lang/noir#6178)
chore: split `test_program`s into modules (noir-lang/noir#6101)
chore: remove `DefCollectorErrorKind::MacroError` (noir-lang/noir#6174)
feat(ssa): Simplify signed casts (noir-lang/noir#6166)
feat: visibility for modules (noir-lang/noir#6165)
@TomAFrench
.
539d5ba
TomAFrench
TomAFrench reviewed Oct 1, 2024
View reviewed changes
@TomAFrench TomAFrench merged commit 2e6340b into master Oct 1, 2024
@TomAFrench TomAFrench deleted the sync-noir branch October 1, 2024 14:13
This was referenced Oct 1, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AztecBot @TomAFrench