Skip to content

feat: Sync from noir#8740

Merged
TomAFrench merged 20 commits intomasterfrom
sync-noir
Sep 25, 2024
Merged

feat: Sync from noir#8740
TomAFrench merged 20 commits intomasterfrom
sync-noir

Conversation

@AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented Sep 24, 2024

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat: optimize constraints in sha256 (noir-lang/noir#6145)
fix: Handle multi-byte utf8 characters in formatter (noir-lang/noir#6118)
fix(ssa): RC correctness issue (noir-lang/noir#6134)
fix: let token pretty printer handle += and similar token sequences (noir-lang/noir#6135)
fix: allow providing default implementations of unconstrained trait methods (noir-lang/noir#6138)
feat: remove unnecessary branching in keccak impl (noir-lang/noir#6133)
feat: do not double error on import with error (noir-lang/noir#6131)
chore: remove unnecessary Prover.tomls (noir-lang/noir#6140)
chore: split noirc_frontend/src/tests.rs into submodules (noir-lang/noir#6139)
feat: remove aztec macros (noir-lang/noir#6087)
END_COMMIT_OVERRIDE

AztecBot and others added 4 commits September 24, 2024 17:24
fix: let token pretty printer handle `+=` and similar token sequences (noir-lang/noir#6135)
fix: allow providing default implementations of unconstrained trait methods (noir-lang/noir#6138)
feat: remove unnecessary branching in keccak impl (noir-lang/noir#6133)
feat: do not double error on import with error (noir-lang/noir#6131)
chore: remove unnecessary `Prover.toml`s (noir-lang/noir#6140)
chore: split `noirc_frontend/src/tests.rs` into submodules (noir-lang/noir#6139)
feat: remove aztec macros (noir-lang/noir#6087)
@TomAFrench TomAFrench enabled auto-merge (squash) September 24, 2024 17:45
TomAFrench and others added 14 commits September 24, 2024 18:17
fix: Handle multi-byte utf8 characters in formatter (noir-lang/noir#6118)
fix(ssa): RC correctness issue  (noir-lang/noir#6134)
fix: let token pretty printer handle `+=` and similar token sequences (noir-lang/noir#6135)
fix: allow providing default implementations of unconstrained trait methods (noir-lang/noir#6138)
feat: remove unnecessary branching in keccak impl (noir-lang/noir#6133)
feat: do not double error on import with error (noir-lang/noir#6131)
chore: remove unnecessary `Prover.toml`s (noir-lang/noir#6140)
chore: split `noirc_frontend/src/tests.rs` into submodules (noir-lang/noir#6139)
feat: remove aztec macros (noir-lang/noir#6087)
fix: Handle multi-byte utf8 characters in formatter (noir-lang/noir#6118)
fix(ssa): RC correctness issue  (noir-lang/noir#6134)
fix: let token pretty printer handle `+=` and similar token sequences (noir-lang/noir#6135)
fix: allow providing default implementations of unconstrained trait methods (noir-lang/noir#6138)
feat: remove unnecessary branching in keccak impl (noir-lang/noir#6133)
feat: do not double error on import with error (noir-lang/noir#6131)
chore: remove unnecessary `Prover.toml`s (noir-lang/noir#6140)
chore: split `noirc_frontend/src/tests.rs` into submodules (noir-lang/noir#6139)
feat: remove aztec macros (noir-lang/noir#6087)
@github-actions
Copy link
Contributor

Changes to circuit sizes

Generated at commit: 3fc84da9b399fec8f7f88b247fc8c3c3b105da21, compared to commit: 150776269b557703552826f90915c85adb639137

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base +835 ❌ +0.20% +1,500 ❌ +0.04%
rollup_merge +47 ❌ +3.27% +85 ❌ +0.00%
parity_root +71 ❌ +3.48% +130 ❌ +0.00%
rollup_block_root +47 ❌ +2.45% +85 ❌ +0.00%
rollup_root +23 ❌ +0.12% +44 ❌ +0.00%
rollup_block_merge +23 ❌ +0.12% +44 ❌ +0.00%
parity_base +71 ❌ +3.52% 0 ➖ 0.00%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base 423,026 (+835) +0.20% 3,734,618 (+1,500) +0.04%
rollup_merge 1,483 (+47) +3.27% 2,751,380 (+85) +0.00%
parity_root 2,114 (+71) +3.48% 5,486,624 (+130) +0.00%
rollup_block_root 1,966 (+47) +2.45% 4,121,078 (+85) +0.00%
rollup_root 18,774 (+23) +0.12% 2,787,535 (+44) +0.00%
rollup_block_merge 18,790 (+23) +0.12% 2,787,567 (+44) +0.00%
parity_base 2,089 (+71) +3.52% 53,444 (0) 0.00%

@TomAFrench TomAFrench merged commit 0d9f547 into master Sep 25, 2024
@TomAFrench TomAFrench deleted the sync-noir branch September 25, 2024 11:56
TomAFrench added a commit that referenced this pull request Sep 25, 2024
Rumata888 pushed a commit that referenced this pull request Sep 27, 2024
Rumata888 pushed a commit that referenced this pull request Sep 27, 2024
Rumata888 pushed a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants