Closed
Conversation
25dedf6 to
0a4558f
Compare
PhilWindle
reviewed
Sep 18, 2024
| const previousKernelProof = await this.previousKernelProof.promise; | ||
| const avmProof = await this.nestedAvmProof.promise; | ||
|
|
||
| // TODO: The kernel does not require the AVM VK, we're just getting the proof. Is that correct? |
Collaborator
There was a problem hiding this comment.
I think it will require the VK. Maybe it doesn't now because we don't recursively verify the AVM proof, but we will do.
PhilWindle
reviewed
Sep 18, 2024
| const avmProof = await this.nestedAvmProof.promise; | ||
|
|
||
| // TODO: The kernel does not require the AVM VK, we're just getting the proof. Is that correct? | ||
| // TODO(#7369): How should we properly set up vkPath, vkIndex, and clientIvc for previous kernel? |
Collaborator
There was a problem hiding this comment.
I'm not sure I follow. All of the public kernels are recursively verified at the moment.
Contributor
Author
There was a problem hiding this comment.
Yeah, but public kernels require not just the recursive proof and vk, but also the vkPath, vkIndex, and clientIvc:
However, in the current orchestrator, only proof and vk are set:
PhilWindle
reviewed
Sep 18, 2024
| if (!this.context.options.simulationOnly) { | ||
| void job | ||
| .prove() | ||
| .then(proof => rootParityJob.setNestedProof(proof, index)) |
Collaborator
There was a problem hiding this comment.
I'm having difficulty understanding the general flow. I can see here we update the nested proof for each base parity, what kicks off the root parity once the final base parity is completed?
eeef089 to
35a0494
Compare
59cd9bb to
3773e64
Compare
3773e64 to
54ece9e
Compare
spalladino
added a commit
that referenced
this pull request
Oct 3, 2024
Adds a new decorator for memoizing results. Extracted from #8614.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paused in favor of #8675