feat(avm/brillig)!: take addresses in calldatacopy#8388
Merged
TomAFrench merged 2 commits intomasterfrom Sep 9, 2024
Merged
Conversation
fcarreiro
requested review from
IlyasRidhuan,
dbanks12 and
jeanmon
as code owners
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @fcarreiro and the rest of your teammates on |
fcarreiro
requested review from
sirasistant
and removed request for
IlyasRidhuan and
jeanmon
fcarreiro
force-pushed
the
fc/avm-calldatacopy-mod
branch
from
689c6e9 to
1ce3294
Compare
fcarreiro
requested review from
TomAFrench,
guipublic and
vezenovm
as code owners
fcarreiro
force-pushed
the
fc/avm-calldatacopy-mod
branch
2 times, most recently
from
865272e to
bf18e64
Compare
Member
|
This is breaking for the nargo <> bb communication so please let me know when this is ready as we'll need to coordinate on syncs/releases/etc. |
fcarreiro
changed the title
fcarreiro
force-pushed
the
fc/avm-calldatacopy-mod
branch
from
bf18e64 to
6add047
Compare
sirasistant
approved these changes
Sep 6, 2024
Contributor
sirasistant
left a comment
sirasistant
left a comment
There was a problem hiding this comment.
Brillig changes LGTM
fcarreiro
force-pushed
the
fc/avm-calldatacopy-mod
branch
from
6add047 to
963bc66
Compare
This was referenced Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes calldatacopy more flexible. It's also needed to use this opcode in user-space.
As I mentioned we'll probably want most or all opcode immediates to be addresses for maximum flexibility. This is a first experimentation on the pains of doing it :)