Skip to content

feat: Small optimization in toradix #8040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 1 commit into from
Aug 16, 2024
Merged

feat: Small optimization in toradix #8040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 28 additions & 19 deletions noir/noir-repo/compiler/noirc_evaluator/src/brillig/brillig_ir/codegen_intrinsic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,28 +84,37 @@ impl<F: AcirField + DebugToString> BrilligContext<F> {
output: HeapArray { pointer: target_vector.pointer, size: limb_count },
});

let limb_field = SingleAddrVariable::new(self.allocate_register(), F::max_num_bits());
let limb_casted = SingleAddrVariable::new(self.allocate_register(), limb_bit_size);

if limb_bit_size != F::max_num_bits() {
self.codegen_loop(target_vector.size, |ctx, iterator_register| {
// Read the limb
ctx.codegen_array_get(target_vector.pointer, iterator_register, limb_field.address);
// Cast it
ctx.cast_instruction(limb_casted, limb_field);
// Write it
ctx.codegen_array_set(
target_vector.pointer,
iterator_register,
limb_casted.address,
);
});
let end_pointer = self.allocate_register();
let temporary_register = self.allocate_register();

self.memory_op_instruction(
target_vector.pointer,
target_vector.size,
end_pointer,
BrilligBinaryOp::Add,
);

self.codegen_for_loop(
Some(target_vector.pointer),
end_pointer,
None,
|ctx, item_pointer| {
ctx.load_instruction(temporary_register, item_pointer.address);

ctx.cast(
SingleAddrVariable::new(temporary_register, limb_bit_size),
SingleAddrVariable::new(temporary_register, F::max_num_bits()),
);

ctx.store_instruction(item_pointer.address, temporary_register);
},
);

self.deallocate_register(end_pointer);
self.deallocate_register(temporary_register);
}

// Deallocate our temporary registers
self.deallocate_single_addr(limb_field);
self.deallocate_single_addr(limb_casted);

if big_endian {
self.codegen_reverse_vector_in_place(target_vector);
}
Expand Down