refactor: call requests by LeilaWang · Pull Request #7483 · AztecProtocol/aztec-packages

LeilaWang · 2024-07-15T17:47:46Z

Stop revealing start counters of public call requests from private.
Export PublicCallRequest structs instead of hashes from public inputs.
- Gate counts have increased because of the larger data (Will try to reduce them in the next pr). But now the app circuit can save 5k for each public function call.
Remove caller context. Instead, use call context in the call request to check addresses and function selector.
Add missing checks:
- Nested function selector.
- Teardown call request.
- Empty public data update requests.

github-actions · 2024-07-15T17:56:11Z

Changes to circuit sizes

Generated at commit: 6cdb3f244a36112b7cdb0087ed99b1fb33e8e23f, compared to commit: 6812f2b3012b91df09239420cd82c053855a3850

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_tail_to_public_simulated	0 ➖	0.00%	+672 ❌	+20.10%
public_kernel_app_logic_simulated	0 ➖	0.00%	+672 ❌	+20.10%
public_kernel_setup_simulated	0 ➖	0.00%	+672 ❌	+20.10%
public_kernel_teardown_simulated	0 ➖	0.00%	+672 ❌	+20.10%
public_kernel_app_logic	+47,362 ❌	+19.70%	+66,523 ❌	+11.88%
private_kernel_inner	+5,068 ❌	+11.17%	+6,396 ❌	+9.84%
private_kernel_init_simulated	0 ➖	0.00%	+183 ❌	+7.94%
private_kernel_inner_simulated	0 ➖	0.00%	+183 ❌	+7.94%
private_kernel_reset_simulated	0 ➖	0.00%	+183 ❌	+7.94%
private_kernel_reset_simulated_big	0 ➖	0.00%	+183 ❌	+7.94%
private_kernel_reset_simulated_medium	0 ➖	0.00%	+183 ❌	+7.94%
private_kernel_reset_simulated_small	0 ➖	0.00%	+183 ❌	+7.94%
private_kernel_reset_simulated_tiny	0 ➖	0.00%	+183 ❌	+7.94%
private_kernel_init	+2,881 ❌	+11.04%	+3,378 ❌	+7.46%
public_kernel_teardown	+47,544 ❌	+19.67%	+70,834 ❌	+4.38%
public_kernel_setup	+28,492 ❌	+15.55%	+55,558 ❌	+3.58%
private_kernel_tail_to_public	+11,698 ❌	+18.93%	+14,459 ❌	+3.27%
private_kernel_reset_tiny	+357 ❌	+0.63%	+641 ❌	+0.51%
private_kernel_reset_small	+357 ❌	+0.60%	+641 ❌	+0.36%
private_kernel_reset_medium	+357 ❌	+0.54%	+641 ❌	+0.22%
private_kernel_tail	+234 ❌	+1.21%	+753 ❌	+0.14%
public_kernel_tail	+806 ❌	+0.08%	+6,078 ❌	+0.13%
private_kernel_reset_big	+357 ❌	+0.44%	+641 ❌	+0.13%
private_kernel_reset	+357 ❌	+0.33%	+641 ❌	+0.07%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_tail_to_public_simulated	1 (0)	0.00%	4,016 (+672)	+20.10%
public_kernel_app_logic_simulated	1 (0)	0.00%	4,016 (+672)	+20.10%
public_kernel_setup_simulated	1 (0)	0.00%	4,016 (+672)	+20.10%
public_kernel_teardown_simulated	1 (0)	0.00%	4,016 (+672)	+20.10%
public_kernel_app_logic	287,730 (+47,362)	+19.70%	626,685 (+66,523)	+11.88%
private_kernel_inner	50,433 (+5,068)	+11.17%	71,395 (+6,396)	+9.84%
private_kernel_init_simulated	1 (0)	0.00%	2,488 (+183)	+7.94%
private_kernel_inner_simulated	1 (0)	0.00%	2,488 (+183)	+7.94%
private_kernel_reset_simulated	1 (0)	0.00%	2,488 (+183)	+7.94%
private_kernel_reset_simulated_big	1 (0)	0.00%	2,488 (+183)	+7.94%
private_kernel_reset_simulated_medium	1 (0)	0.00%	2,488 (+183)	+7.94%
private_kernel_reset_simulated_small	1 (0)	0.00%	2,488 (+183)	+7.94%
private_kernel_reset_simulated_tiny	1 (0)	0.00%	2,488 (+183)	+7.94%
private_kernel_init	28,972 (+2,881)	+11.04%	48,641 (+3,378)	+7.46%
public_kernel_teardown	289,274 (+47,544)	+19.67%	1,688,836 (+70,834)	+4.38%
public_kernel_setup	211,687 (+28,492)	+15.55%	1,609,614 (+55,558)	+3.58%
private_kernel_tail_to_public	73,499 (+11,698)	+18.93%	457,031 (+14,459)	+3.27%
private_kernel_reset_tiny	56,834 (+357)	+0.63%	125,663 (+641)	+0.51%
private_kernel_reset_small	60,246 (+357)	+0.60%	179,553 (+641)	+0.36%
private_kernel_reset_medium	67,073 (+357)	+0.54%	287,512 (+641)	+0.22%
private_kernel_tail	19,602 (+234)	+1.21%	537,715 (+753)	+0.14%
public_kernel_tail	965,860 (+806)	+0.08%	4,650,926 (+6,078)	+0.13%
private_kernel_reset_big	80,726 (+357)	+0.44%	503,637 (+641)	+0.13%
private_kernel_reset	108,030 (+357)	+0.33%	935,885 (+641)	+0.07%

…est_counter

AztecBot

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite	Current: `bd0f782`	Previous: `199faca`	Ratio
`nativeClientIVCBench/Full/6`	`14119.553545999992` ms/iter	`13343.767048000018` ms/iter	`1.06`
`wasmClientIVCBench/Full/6`	`42536.842025000005` ms/iter	`39779.408566` ms/iter	`1.07`
`commit(t)`	`4754440779` ns/iter	`3669937899` ns/iter	`1.30`
`commit(t)`	`3911801016` ns/iter	`3669937899` ns/iter	`1.07`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ludamad @codygunton

LeilaWang · 2024-07-22T16:27:58Z

noir-projects/aztec-nr/aztec/src/context/private_context.nr

-        assert(item.public_inputs.call_context.is_delegate_call == is_delegate_call);
-        assert(item.public_inputs.call_context.is_static_call == is_static_call);
-
-        if (is_delegate_call) {


The same checks for (non_)delegate call is done in the kernel and must be done there. It's not necessary to check them here in the app circuit. If we want to abort early before executing kernel circuits, can check and throw from the simulator.

LeilaWang · 2024-07-22T16:53:11Z

...ir-protocol-circuits/crates/private-kernel-lib/src/components/private_call_data_validator.nr

-        assert_eq(request.hash, hash, "call stack hash does not match call request hash");
-        assert_eq(request.caller_contract_address, caller.contract_address, "invalid caller contract address");
-        validate_caller_context(request.caller_context, caller.public_inputs.call_context)
+fn validate_call_context(


This is checked on all the private call requests emitted from a private call.
We've replaced the caller context with call context in the call request, and check the addresses in the call context instead.
Which means we don't have to check the addresses again in a nested call (in validate_against_call_request), it's legit as long as the call context in the request matches the one in the call stack item.

LeilaWang · 2024-07-22T17:04:31Z

...ir-protocol-circuits/crates/private-kernel-lib/src/components/private_call_data_validator.nr

        }

+        assert_eq(
+            call_context.function_selector, self.data.call_stack_item.function_data.selector, "function selector in call context does not match call stack item"


I don't think we checked this before. We need to ensure that a nested call's function selector is what the caller expects.

LeilaWang · 2024-07-22T17:51:56Z

noir-projects/aztec-nr/aztec/src/context/private_context.nr

+        PackedReturns::new(returns_hash)
    }

    pub fn call_public_function<let ARGS_COUNT: u32>(


With the changes, it's 5k less to call/enqueue a public function.

LeilaWang · 2024-07-22T18:09:04Z

...circuits/crates/private-kernel-lib/src/components/private_kernel_circuit_output_validator.nr

            previous_kernel.end.unencrypted_logs_hashes,
            array_lengths.unencrypted_logs_hashes
        );
+        validate_array_prepended(


Unfortunately this has increased 4k gate counts, contributing most part of the increment of init (3471) and inner (6489).
I think there's some unreasonably heavy stuffs going on and we should be able to reduce it a bit. (Will refactor in another pr!)

LeilaWang · 2024-07-22T18:11:41Z

...circuits/crates/private-kernel-lib/src/components/private_kernel_circuit_output_validator.nr

            storage_contract_address
        );
-        validate_array_appended_reversed_scoped(
+        validate_array_appended(


This adds another 3k to inner :(
Same as above, will investigate and try to reduce it in the next pr.

…est_counter

AztecBot · 2024-07-23T13:46:10Z

Benchmark results

Metrics with a significant change:

proof_construction_time_sha256_ms (4): 1,827 (+18%)
app_circuit_output_size_in_bytes (ContractClassRegisterer:register): 11,699 (+25%)
app_circuit_output_size_in_bytes (ContractInstanceDeployer:deploy): 11,699 (+25%)
app_circuit_output_size_in_bytes (MultiCallEntrypoint:entrypoint): 11,699 (+25%)
app_circuit_output_size_in_bytes (GasToken:deploy): 11,699 (+25%)
app_circuit_output_size_in_bytes (SchnorrAccount:constructor): 11,699 (+25%)
app_circuit_output_size_in_bytes (SchnorrAccount:entrypoint): 11,699 (+25%)
app_circuit_output_size_in_bytes (Token:privately_mint_private_note): 11,699 (+25%)
app_circuit_output_size_in_bytes (FPC:fee_entrypoint_public): 11,699 (+25%)
app_circuit_output_size_in_bytes (Token:transfer): 11,699 (+25%)
app_circuit_output_size_in_bytes (Benchmarking:create_note): 11,699 (+25%)
app_circuit_output_size_in_bytes (SchnorrAccount:verify_private_authwit): 11,699 (+25%)
app_circuit_output_size_in_bytes (Token:unshield): 11,699 (+25%)
app_circuit_output_size_in_bytes (FPC:fee_entrypoint_private): 11,699 (+25%)
protocol_circuit_simulation_time_in_ms (private-kernel-tail): 447 (+20%)
protocol_circuit_input_size_in_bytes (private-kernel-tail-to-public): 900,567 (+16%)
avm_simulation_time_ms (Token:transfer_public): 45.7 (-37%)
protocol_circuit_witness_generation_time_in_ms (private-kernel-tail-to-public): 1,697 (+22%)
protocol_circuit_witness_generation_time_in_ms (public-kernel-app-logic): 3,969 (+21%)
protocol_circuit_witness_generation_time_in_ms (public-kernel-teardown): 4,091 (+22%)
protocol_circuit_proving_time_in_ms (base-parity): 1,393 (-27%)
protocol_circuit_proof_size_in_bytes (public-kernel-setup): 140,932 (+18%)
protocol_circuit_proof_size_in_bytes (public-kernel-app-logic): 140,932 (+18%)
protocol_circuit_proof_size_in_bytes (public-kernel-teardown): 140,932 (+18%)
protocol_circuit_num_public_inputs (public-kernel-setup): 4,011 (+20%)
protocol_circuit_num_public_inputs (public-kernel-app-logic): 4,011 (+20%)
protocol_circuit_num_public_inputs (public-kernel-teardown): 4,011 (+20%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,706 (-1%)	⚠️ 1,827 (+18%)	714 (+1%)	741	766 (-1%)
proof_construction_time_sha256_30_ms	12,189 (+3%)	3,317 (+4%)	1,397 (-1%)	1,422 (-1%)	1,464 (-1%)
proof_construction_time_sha256_100_ms	44,014	11,967	5,416	5,362 (-1%)	5,338 (-1%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	35.0 (+3%)	59.0 (+2%)	88.0
proof_construction_time_poseidon_hash_30_ms	1,515 (-1%)	415	200 (+1%)	228 (+1%)	265
proof_construction_time_poseidon_hash_100_ms	5,706 (+1%)	1,587 (+4%)	708 (+4%)	721 (-2%)	746

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	708	708	708
l1_rollup_calldata_gas	6,600	6,592	6,600
l1_rollup_execution_gas	583,062	583,205	583,364
l2_block_processing_time_in_ms	763 (+1%)	1,417	2,723 (+2%)
l2_block_building_time_in_ms	10,857 (+6%)	21,110 (+5%)	42,088 (+5%)
l2_block_rollup_simulation_time_in_ms	10,857 (+6%)	21,109 (+5%)	42,088 (+5%)
l2_block_public_tx_process_time_in_ms	9,076 (+6%)	19,141 (+5%)	40,060 (+6%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,065	9,938
node_database_size_in_bytes	12,726,352	16,863,312
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	107 (+12%)	441 (+10%)	21,310 (-2%)	53,089 (-2%)	N/A	N/A	N/A	N/A
private-kernel-inner	196 (+15%)	779 (+11%)	79,930 (-2%)	53,265 (-2%)	N/A	N/A	N/A	N/A
private-kernel-tail	⚠️ 447 (+20%)	942 (+10%)	60,700 (-1%)	57,446 (-8%)	N/A	N/A	N/A	N/A
base-parity	6.59	716 (+4%)	160	96.0	⚠️ 1,393 (-27%)	12,676	3.00	131,072
root-parity	107 (-2%)	107 (-1%)	64,860	96.0	28,099 (+1%)	12,676	3.00	4,194,304
base-rollup	3,405 (+4%)	5,120	181,083	632	40,658	13,476	28.0	4,194,304
root-rollup	156 (+1%)	109 (-4%)	51,261	652	25,479	13,412	26.0	4,194,304
public-kernel-setup	116 (+6%)	2,682 (+13%)	111,864 (-1%)	80,246 (-1%)	16,182 (+4%)	⚠️ 140,932 (+18%)	⚠️ 4,011 (+20%)	2,097,152
public-kernel-app-logic	121 (+13%)	⚠️ 3,969 (+21%)	111,864 (-1%)	80,246 (-1%)	9,752 (+12%)	⚠️ 140,932 (+18%)	⚠️ 4,011 (+20%)	1,048,576
public-kernel-tail	643 (+1%)	26,973 (+2%)	409,605	10,814	62,613 (+1%)	25,860	415	8,388,608
private-kernel-reset-tiny	229 (+1%)	964 (+2%)	76,064 (-1%)	52,960 (-2%)	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	4,235 (-14%)	⚠️ 1,697 (+22%)	⚠️ 900,567 (+16%)	1,632	N/A	N/A	N/A	N/A
public-kernel-teardown	105 (+15%)	⚠️ 4,091 (+22%)	111,864 (-1%)	80,246 (-1%)	17,211 (+5%)	⚠️ 140,932 (+18%)	⚠️ 4,011 (+20%)	2,097,152
merge-rollup	58.1 (-2%)	N/A	33,566	632	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	153,113 (+1%)	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,312	⚠️ 11,699 (+25%)	349 (-2%)	N/A	N/A
ContractInstanceDeployer:deploy	1,376	⚠️ 11,699 (+25%)	28.1 (+11%)	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888	⚠️ 11,699 (+25%)	614 (+4%)	N/A	N/A
GasToken:deploy	1,344	⚠️ 11,699 (+25%)	448 (-8%)	N/A	N/A
SchnorrAccount:constructor	1,280	⚠️ 11,699 (+25%)	440 (-7%)	N/A	N/A
SchnorrAccount:entrypoint	2,272	⚠️ 11,699 (+25%)	825 (+12%)	N/A	N/A
Token:privately_mint_private_note	1,248	⚠️ 11,699 (+25%)	527	N/A	N/A
FPC:fee_entrypoint_public	1,312	⚠️ 11,699 (+25%)	94.4 (-27%)	N/A	N/A
Token:transfer	1,280	⚠️ 11,699 (+25%)	1,354 (-6%)	N/A	N/A
AuthRegistry:set_authorized (avm)	21,702 (+13%)	N/A	N/A	102,048 (+7%)	2,350 (+5%)
FPC:prepare_fee (avm)	25,150 (+11%)	N/A	N/A	102,112 (+7%)	2,371 (+3%)
Token:transfer_public (avm)	58,188 (+4%)	N/A	N/A	102,112 (+7%)	6,282 (+1%)
AuthRegistry:consume (avm)	35,580 (+7%)	N/A	N/A	102,080 (+7%)	2,741 (-5%)
FPC:pay_refund (avm)	30,010 (+9%)	N/A	N/A	102,080 (+7%)	3,664 (+3%)
Benchmarking:create_note	1,312	⚠️ 11,699 (+25%)	420 (+1%)	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248	⚠️ 11,699 (+25%)	43.7 (+5%)	N/A	N/A
Token:unshield	1,344	⚠️ 11,699 (+25%)	1,138 (-1%)	N/A	N/A
FPC:fee_entrypoint_private	1,344	⚠️ 11,699 (+25%)	1,412 (-5%)	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	97.3 (-4%)	13,790
GasToken:set_portal	17.3 (+28%)	3,339
Token:constructor	121 (-2%)	23,692
FPC:constructor	90.4 (-4%)	13,592
GasToken:mint_public	80.7 (-14%)	10,158
Token:mint_public	281 (+5%)	19,034
Token:assert_minter_and_mint	85.2 (+18%)	12,925
AuthRegistry:set_authorized	44.5 (-3%)	7,812
FPC:prepare_fee	276 (+10%)	11,068
Token:transfer_public	⚠️ 45.7 (-37%)	44,012
FPC:pay_refund	74.6 (-5%)	15,961
Benchmarking:increment_balance	1,061 (+6%)	11,281
Token:_increase_public_balance	14.9 (-6%)	15,006
FPC:pay_refund_with_shielded_rebate	130 (-2%)	17,056

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.157 (+2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4	16.8 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.601	0.518 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.4 (-2%)	76.1 (+1%)	131 (+1%)	245 (-1%)	469
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.495 (-2%)	0.467 (+1%)	0.450	0.444	0.438
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.9 (-1%)	111	183 (+1%)	352 (-1%)	690
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.506 (-1%)	0.498	0.484 (+1%)	0.477	0.474
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	73.2	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.520	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	72,014 (-7%)	666,910

Transaction size based on fee payment method

| Metric | |
| - | |

…est_counter

...ir-protocol-circuits/crates/private-kernel-lib/src/components/private_call_data_validator.nr

noir-projects/aztec-nr/aztec/src/context/private_context.nr

MirandaWood

LGTM! 🚀

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.47.1</summary> ## [0.47.1](aztec-package-v0.47.0...aztec-package-v0.47.1) (2024-07-30) ### Features * Do not evict tx objects from p2p tx pool immediately ([#7652](#7652)) ([96492dc](96492dc)) * Min and max block times for sequencer ([#7630](#7630)) ([2a013b8](2a013b8)) * Transaction sender bot ([#7586](#7586)) ([176fd08](176fd08)), closes [#7562](#7562) ### Bug Fixes * Aztec start --prover ([#7617](#7617)) ([ac206a6](ac206a6)) ### Miscellaneous * Add tx bot to terraform ([#7609](#7609)) ([6caa914](6caa914)) * Merge Devnet back to Master ([#7611](#7611)) ([112961c](112961c)) </details> <details><summary>barretenberg.js: 0.47.1</summary> ## [0.47.1](barretenberg.js-v0.47.0...barretenberg.js-v0.47.1) (2024-07-30) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.47.1</summary> ## [0.47.1](aztec-packages-v0.47.0...aztec-packages-v0.47.1) (2024-07-30) ### Features * Add recursive aggregation object to proving/verification keys ([#6770](#6770)) ([f48b069](f48b069)) * Adding aggregation to honk and rollup ([#7466](#7466)) ([2633aa9](2633aa9)) * Allow get_notes to return zero notes ([#7621](#7621)) ([e16452a](e16452a)) * **avm:** Pedersen commit in avm ([#7634](#7634)) ([45e7867](45e7867)) * **avm:** Pedersen commitment sim ([#7632](#7632)) ([cc420a0](cc420a0)) * Do not evict tx objects from p2p tx pool immediately ([#7652](#7652)) ([96492dc](96492dc)) * Handle L1toL2 msgs in prover-node ([#7654](#7654)) ([f35bac5](f35bac5)) * Leonidas ([#7597](#7597)) ([eda498a](eda498a)) * Min and max block times for sequencer ([#7630](#7630)) ([2a013b8](2a013b8)) * **sol-honk:** Integrate solidity honk verifier with bb and acir tests ([#7573](#7573)) ([344ca6f](344ca6f)) * **sol-honk:** Test verifying recursive proof ([#7576](#7576)) ([26408c1](26408c1)) * Static.aztec.network ([#7649](#7649)) ([9dffef5](9dffef5)) * Transaction sender bot ([#7586](#7586)) ([176fd08](176fd08)), closes [#7562](#7562) ### Bug Fixes * Aztec start --prover ([#7617](#7617)) ([ac206a6](ac206a6)) * Bb mac build ([#7619](#7619)) ([e3c5602](e3c5602)) * Faucet correctly derives its account ([#7645](#7645)) ([921773f](921773f)) * Uniswap e2e test "nonce too low" ([#7633](#7633)) ([e9e2318](e9e2318)) ### Miscellaneous * Add tx bot to terraform ([#7609](#7609)) ([6caa914](6caa914)) * **bb readme:** Add installation instructions and TODOs ([#7601](#7601)) ([1a97698](1a97698)) * **bb readme:** Update versioning instructions and add Honk Solidity verifier commands ([#7608](#7608)) ([9dd9195](9dd9195)) * Bench client ivc proof verification ([#7553](#7553)) ([b060309](b060309)) * Call requests ([#7483](#7483)) ([ffedf39](ffedf39)) * Constant inputs for most blackboxes ([#7613](#7613)) ([3247058](3247058)) * **docs:** Fix links ([#7602](#7602)) ([f2029be](f2029be)) * Merge Devnet back to Master ([#7611](#7611)) ([112961c](112961c)) * **p2p:** Tx serialization cleanup ([#7620](#7620)) ([022a899](022a899)) * Replace relative paths to noir-protocol-circuits ([ebaafc7](ebaafc7)) * Replace relative paths to noir-protocol-circuits ([d3b818d](d3b818d)) * Replace relative paths to noir-protocol-circuits ([4a26a19](4a26a19)) </details> <details><summary>barretenberg: 0.47.1</summary> ## [0.47.1](barretenberg-v0.47.0...barretenberg-v0.47.1) (2024-07-30) ### Features * Add recursive aggregation object to proving/verification keys ([#6770](#6770)) ([f48b069](f48b069)) * Adding aggregation to honk and rollup ([#7466](#7466)) ([2633aa9](2633aa9)) * **avm:** Pedersen commit in avm ([#7634](#7634)) ([45e7867](45e7867)) * **avm:** Pedersen commitment sim ([#7632](#7632)) ([cc420a0](cc420a0)) * **sol-honk:** Integrate solidity honk verifier with bb and acir tests ([#7573](#7573)) ([344ca6f](344ca6f)) * **sol-honk:** Test verifying recursive proof ([#7576](#7576)) ([26408c1](26408c1)) ### Bug Fixes * Bb mac build ([#7619](#7619)) ([e3c5602](e3c5602)) ### Miscellaneous * **bb readme:** Add installation instructions and TODOs ([#7601](#7601)) ([1a97698](1a97698)) * **bb readme:** Update versioning instructions and add Honk Solidity verifier commands ([#7608](#7608)) ([9dd9195](9dd9195)) * Call requests ([#7483](#7483)) ([ffedf39](ffedf39)) * Constant inputs for most blackboxes ([#7613](#7613)) ([3247058](3247058)) * Merge Devnet back to Master ([#7611](#7611)) ([112961c](112961c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.47.1</summary> ## [0.47.1](AztecProtocol/aztec-packages@aztec-package-v0.47.0...aztec-package-v0.47.1) (2024-07-30) ### Features * Do not evict tx objects from p2p tx pool immediately ([#7652](AztecProtocol/aztec-packages#7652)) ([96492dc](AztecProtocol/aztec-packages@96492dc)) * Min and max block times for sequencer ([#7630](AztecProtocol/aztec-packages#7630)) ([2a013b8](AztecProtocol/aztec-packages@2a013b8)) * Transaction sender bot ([#7586](AztecProtocol/aztec-packages#7586)) ([176fd08](AztecProtocol/aztec-packages@176fd08)), closes [#7562](AztecProtocol/aztec-packages#7562) ### Bug Fixes * Aztec start --prover ([#7617](AztecProtocol/aztec-packages#7617)) ([ac206a6](AztecProtocol/aztec-packages@ac206a6)) ### Miscellaneous * Add tx bot to terraform ([#7609](AztecProtocol/aztec-packages#7609)) ([6caa914](AztecProtocol/aztec-packages@6caa914)) * Merge Devnet back to Master ([#7611](AztecProtocol/aztec-packages#7611)) ([112961c](AztecProtocol/aztec-packages@112961c)) </details> <details><summary>barretenberg.js: 0.47.1</summary> ## [0.47.1](AztecProtocol/aztec-packages@barretenberg.js-v0.47.0...barretenberg.js-v0.47.1) (2024-07-30) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.47.1</summary> ## [0.47.1](AztecProtocol/aztec-packages@aztec-packages-v0.47.0...aztec-packages-v0.47.1) (2024-07-30) ### Features * Add recursive aggregation object to proving/verification keys ([#6770](AztecProtocol/aztec-packages#6770)) ([f48b069](AztecProtocol/aztec-packages@f48b069)) * Adding aggregation to honk and rollup ([#7466](AztecProtocol/aztec-packages#7466)) ([2633aa9](AztecProtocol/aztec-packages@2633aa9)) * Allow get_notes to return zero notes ([#7621](AztecProtocol/aztec-packages#7621)) ([e16452a](AztecProtocol/aztec-packages@e16452a)) * **avm:** Pedersen commit in avm ([#7634](AztecProtocol/aztec-packages#7634)) ([45e7867](AztecProtocol/aztec-packages@45e7867)) * **avm:** Pedersen commitment sim ([#7632](AztecProtocol/aztec-packages#7632)) ([cc420a0](AztecProtocol/aztec-packages@cc420a0)) * Do not evict tx objects from p2p tx pool immediately ([#7652](AztecProtocol/aztec-packages#7652)) ([96492dc](AztecProtocol/aztec-packages@96492dc)) * Handle L1toL2 msgs in prover-node ([#7654](AztecProtocol/aztec-packages#7654)) ([f35bac5](AztecProtocol/aztec-packages@f35bac5)) * Leonidas ([#7597](AztecProtocol/aztec-packages#7597)) ([eda498a](AztecProtocol/aztec-packages@eda498a)) * Min and max block times for sequencer ([#7630](AztecProtocol/aztec-packages#7630)) ([2a013b8](AztecProtocol/aztec-packages@2a013b8)) * **sol-honk:** Integrate solidity honk verifier with bb and acir tests ([#7573](AztecProtocol/aztec-packages#7573)) ([344ca6f](AztecProtocol/aztec-packages@344ca6f)) * **sol-honk:** Test verifying recursive proof ([#7576](AztecProtocol/aztec-packages#7576)) ([26408c1](AztecProtocol/aztec-packages@26408c1)) * Static.aztec.network ([#7649](AztecProtocol/aztec-packages#7649)) ([9dffef5](AztecProtocol/aztec-packages@9dffef5)) * Transaction sender bot ([#7586](AztecProtocol/aztec-packages#7586)) ([176fd08](AztecProtocol/aztec-packages@176fd08)), closes [#7562](AztecProtocol/aztec-packages#7562) ### Bug Fixes * Aztec start --prover ([#7617](AztecProtocol/aztec-packages#7617)) ([ac206a6](AztecProtocol/aztec-packages@ac206a6)) * Bb mac build ([#7619](AztecProtocol/aztec-packages#7619)) ([e3c5602](AztecProtocol/aztec-packages@e3c5602)) * Faucet correctly derives its account ([#7645](AztecProtocol/aztec-packages#7645)) ([921773f](AztecProtocol/aztec-packages@921773f)) * Uniswap e2e test "nonce too low" ([#7633](AztecProtocol/aztec-packages#7633)) ([e9e2318](AztecProtocol/aztec-packages@e9e2318)) ### Miscellaneous * Add tx bot to terraform ([#7609](AztecProtocol/aztec-packages#7609)) ([6caa914](AztecProtocol/aztec-packages@6caa914)) * **bb readme:** Add installation instructions and TODOs ([#7601](AztecProtocol/aztec-packages#7601)) ([1a97698](AztecProtocol/aztec-packages@1a97698)) * **bb readme:** Update versioning instructions and add Honk Solidity verifier commands ([#7608](AztecProtocol/aztec-packages#7608)) ([9dd9195](AztecProtocol/aztec-packages@9dd9195)) * Bench client ivc proof verification ([#7553](AztecProtocol/aztec-packages#7553)) ([b060309](AztecProtocol/aztec-packages@b060309)) * Call requests ([#7483](AztecProtocol/aztec-packages#7483)) ([ffedf39](AztecProtocol/aztec-packages@ffedf39)) * Constant inputs for most blackboxes ([#7613](AztecProtocol/aztec-packages#7613)) ([3247058](AztecProtocol/aztec-packages@3247058)) * **docs:** Fix links ([#7602](AztecProtocol/aztec-packages#7602)) ([f2029be](AztecProtocol/aztec-packages@f2029be)) * Merge Devnet back to Master ([#7611](AztecProtocol/aztec-packages#7611)) ([112961c](AztecProtocol/aztec-packages@112961c)) * **p2p:** Tx serialization cleanup ([#7620](AztecProtocol/aztec-packages#7620)) ([022a899](AztecProtocol/aztec-packages@022a899)) * Replace relative paths to noir-protocol-circuits ([ebaafc7](AztecProtocol/aztec-packages@ebaafc7)) * Replace relative paths to noir-protocol-circuits ([d3b818d](AztecProtocol/aztec-packages@d3b818d)) * Replace relative paths to noir-protocol-circuits ([4a26a19](AztecProtocol/aztec-packages@4a26a19)) </details> <details><summary>barretenberg: 0.47.1</summary> ## [0.47.1](AztecProtocol/aztec-packages@barretenberg-v0.47.0...barretenberg-v0.47.1) (2024-07-30) ### Features * Add recursive aggregation object to proving/verification keys ([#6770](AztecProtocol/aztec-packages#6770)) ([f48b069](AztecProtocol/aztec-packages@f48b069)) * Adding aggregation to honk and rollup ([#7466](AztecProtocol/aztec-packages#7466)) ([2633aa9](AztecProtocol/aztec-packages@2633aa9)) * **avm:** Pedersen commit in avm ([#7634](AztecProtocol/aztec-packages#7634)) ([45e7867](AztecProtocol/aztec-packages@45e7867)) * **avm:** Pedersen commitment sim ([#7632](AztecProtocol/aztec-packages#7632)) ([cc420a0](AztecProtocol/aztec-packages@cc420a0)) * **sol-honk:** Integrate solidity honk verifier with bb and acir tests ([#7573](AztecProtocol/aztec-packages#7573)) ([344ca6f](AztecProtocol/aztec-packages@344ca6f)) * **sol-honk:** Test verifying recursive proof ([#7576](AztecProtocol/aztec-packages#7576)) ([26408c1](AztecProtocol/aztec-packages@26408c1)) ### Bug Fixes * Bb mac build ([#7619](AztecProtocol/aztec-packages#7619)) ([e3c5602](AztecProtocol/aztec-packages@e3c5602)) ### Miscellaneous * **bb readme:** Add installation instructions and TODOs ([#7601](AztecProtocol/aztec-packages#7601)) ([1a97698](AztecProtocol/aztec-packages@1a97698)) * **bb readme:** Update versioning instructions and add Honk Solidity verifier commands ([#7608](AztecProtocol/aztec-packages#7608)) ([9dd9195](AztecProtocol/aztec-packages@9dd9195)) * Call requests ([#7483](AztecProtocol/aztec-packages#7483)) ([ffedf39](AztecProtocol/aztec-packages@ffedf39)) * Constant inputs for most blackboxes ([#7613](AztecProtocol/aztec-packages#7613)) ([3247058](AztecProtocol/aztec-packages@3247058)) * Merge Devnet back to Master ([#7611](AztecProtocol/aztec-packages#7611)) ([112961c](AztecProtocol/aztec-packages@112961c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Don't export counters of public call requests from private.

4e5da0e

LeilaWang added 5 commits July 15, 2024 18:36

Use PublicCallRequest struct in private.

c5ac2f7

Refactor call requests.

20530b8

Merge remote-tracking branch 'origin/master' into lw/public_call_requ…

e62b0c0

…est_counter

fmt

1e34f64

Fix tests.

fcf1508

AztecBot reviewed Jul 22, 2024

View reviewed changes

Fix tests.

fed5fc7

LeilaWang commented Jul 22, 2024

View reviewed changes

Fix.

8a13200

LeilaWang commented Jul 22, 2024

View reviewed changes

LeilaWang changed the title ~~fix: don't export counters of public call requests from private.~~ refactor: call requests Jul 22, 2024

LeilaWang added 3 commits July 22, 2024 19:18

Ensure no unexpected data in public inputs.

e38ce1d

Merge remote-tracking branch 'origin/master' into lw/public_call_requ…

bd0f782

…est_counter

Merge remote-tracking branch 'origin/master' into lw/public_call_requ…

81deaed

…est_counter

LeilaWang added 3 commits July 23, 2024 18:01

Small update.

59574fb

Check tx data.

42bdb4d

Merge remote-tracking branch 'origin/master' into lw/public_call_requ…

a0b297e

…est_counter

LeilaWang marked this pull request as ready for review July 24, 2024 09:33

LeilaWang requested review from IlyasRidhuan, dbanks12, fcarreiro and jeanmon as code owners July 24, 2024 09:33

fcarreiro removed the request for review from dbanks12 July 25, 2024 10:33

fcarreiro removed request for IlyasRidhuan, fcarreiro and jeanmon July 25, 2024 10:34

MirandaWood reviewed Jul 25, 2024

View reviewed changes

...ir-protocol-circuits/crates/private-kernel-lib/src/components/private_call_data_validator.nr Show resolved Hide resolved

MirandaWood reviewed Jul 25, 2024

View reviewed changes

noir-projects/aztec-nr/aztec/src/context/private_context.nr Show resolved Hide resolved

MirandaWood approved these changes Jul 25, 2024

View reviewed changes

LeilaWang merged commit ffedf39 into master Jul 25, 2024

LeilaWang deleted the lw/public_call_request_counter branch July 25, 2024 13:17

AztecBot mentioned this pull request Jul 25, 2024

chore(master): Release 0.47.1 #7605

Merged

Conversation

LeilaWang commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

Uh oh!

AztecBot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

LeilaWang Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

LeilaWang Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

LeilaWang Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

LeilaWang Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

LeilaWang Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

LeilaWang Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

AztecBot commented Jul 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

Uh oh!

Uh oh!

Uh oh!

MirandaWood left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

LeilaWang commented Jul 15, 2024 •

edited

Loading

github-actions bot commented Jul 15, 2024 •

edited

Loading

AztecBot left a comment •

edited

Loading

AztecBot commented Jul 23, 2024 •

edited

Loading