refactor: private refund cleanup by benesjan · Pull Request #7403 · AztecProtocol/aztec-packages

benesjan · 2024-07-09T13:50:05Z

Addressing comments from #7343 (review) + added test checking that the emitted randomness is legit.

benesjan · 2024-07-09T13:50:19Z

fix: vulnerabilities in private refunds #7424
fix: using different generators in private refund #7414
refactor: private refund cleanup #7403 👈
feat: typing return values of embedded_curve_ops #7413
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

AztecBot · 2024-07-10T09:29:38Z

Benchmark results

Metrics with a significant change:

batch_insert_into_append_only_tree_32_depth_ms (512): 378 (+54%)
batch_insert_into_append_only_tree_32_depth_hash_ms (512): 0.686 (+55%)
batch_insert_into_indexed_tree_20_depth_ms (512): 529 (+50%)
batch_insert_into_indexed_tree_20_depth_hash_ms (512): 0.719 (+51%)
avm_simulation_time_ms (Token:mint_public): 49.9 (-85%)
avm_simulation_time_ms (Token:_increase_public_balance): 62.9 (+320%)
l2_block_building_time_in_ms (8): 30,636 (+19%)
l2_block_rollup_simulation_time_in_ms (8): 30,636 (+19%)
l2_block_public_tx_process_time_in_ms (8): 28,127 (+20%)
l2_block_processing_time_in_ms (8): 2,034 (+44%)
node_history_sync_time_in_ms (5): 15,409 (+56%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,710 (-1%)	1,542 (-1%)	702 (-1%)	762 (+3%)	768
proof_construction_time_sha256_30_ms	11,693 (-1%)	3,140 (-1%)	1,403	1,423	1,465
proof_construction_time_sha256_100_ms	43,680 (-1%)	11,731 (-1%)	6,323 (-1%)	5,409	5,345
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	57.0	89.0 (+2%)
proof_construction_time_poseidon_hash_30_ms	1,516 (-1%)	416 (-1%)	200	228	267
proof_construction_time_poseidon_hash_100_ms	5,606 (-1%)	1,512 (-1%)	675	727 (+1%)	742

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,476	9,464	9,452
l1_rollup_execution_gas	613,504	613,643	613,782
l2_block_processing_time_in_ms	754	⚠️ 2,034 (+44%)	2,716
l2_block_building_time_in_ms	13,011 (-1%)	⚠️ 30,636 (+19%)	50,079 (-1%)
l2_block_rollup_simulation_time_in_ms	13,010 (-1%)	⚠️ 30,636 (+19%)	50,078 (-1%)
l2_block_public_tx_process_time_in_ms	10,977	⚠️ 28,127 (+20%)	47,838 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,166 (+2%)	⚠️ 15,409 (+56%)
node_database_size_in_bytes	12,447,824	16,207,952
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	119 (+9%)	425 (-1%)	13,796	20,002	55,022	76,256	2,316	524,288
private-kernel-inner	241 (+6%)	759 (-1%)	46,786	82,134	55,022	76,256	2,316	2,097,152
private-kernel-tail	1,133 (+7%)	2,523 (-1%)	46,062 (+2%)	62,409	62,089	14,944	400	2,097,152
base-parity	6.61 (+3%)	946	2,467 (-1%)	160	96.0	2,240	3.00	131,072
root-parity	73.5 (+5%)	63.9 (+7%)	34,315	27,868	96.0	2,752	19.0	2,097,152
base-rollup	4,553 (+9%)	5,054	78,543 (-1%)	172,028	632	3,552	44.0	4,194,304
root-rollup	129 (+1%)	85.1 (+4%)	19,405 (-2%)	25,053	652	3,488	42.0	1,048,576
public-kernel-setup	193	2,344	36,382	103,911	80,310	108,992	3,339	2,097,152
public-kernel-app-logic	166 (+11%)	3,317 (-1%)	37,352	103,911	80,310	108,992	3,339	2,097,152
public-kernel-tail	992 (+10%)	24,337 (+4%)	155,597 (-1%)	400,808	10,046	14,944	400	8,388,608
private-kernel-reset-small	317 (+8%)	1,235 (+6%)	23,886	79,273	55,022	76,256	2,316	1,048,576
public-kernel-teardown	137	3,324	37,014	103,911	80,310	108,992	3,339	2,097,152
merge-rollup	40.8 (+1%)	N/A	N/A	16,094	632	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	3,156 (+2%)	45,198 (+1%)	N/A	N/A	108,992	3,339	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,312	9,344	400	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,376	9,344	25.4 (-1%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888	9,344	627 (-1%)	N/A	N/A	N/A	N/A
GasToken:deploy	1,344	9,344	572	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,280	9,344	434 (-1%)	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,272	9,344	844 (+8%)	16,352	4,663 (-4%)	131,072	444
Token:privately_mint_private_note	1,248	9,344	524	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,312	9,344	107 (+3%)	16,352	1,846 (-2%)	65,536	444
Token:transfer	1,280	9,344	1,606	16,352	10,394	524,288	444
AuthRegistry:set_authorized (avm)	19,222	N/A	N/A	91,232	1,651 (-4%)	N/A	N/A
FPC:prepare_fee (avm)	26,664	N/A	N/A	91,296	2,940 (-3%)	N/A	N/A
Token:transfer_public (avm)	42,914	N/A	N/A	91,296	3,776	N/A	N/A
AuthRegistry:consume (avm)	33,100	N/A	N/A	91,232	3,001	N/A	N/A
FPC:pay_refund (avm)	36,829	N/A	N/A	91,264	18,199	N/A	N/A
Benchmarking:create_note	1,312	9,344	479 (+13%)	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248	9,344	41.8 (-1%)	N/A	N/A	N/A	N/A
Token:unshield	1,344	9,344	1,303 (-2%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,344	9,344	1,679 (-1%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	79.7 (+2%)	13,790
GasToken:set_portal	13.4 (-8%)	3,339
Token:constructor	102 (-4%)	23,692
FPC:constructor	73.8 (+1%)	13,592
GasToken:mint_public	63.2 (+2%)	10,158
Token:mint_public	⚠️ 49.9 (-85%)	19,034
Token:assert_minter_and_mint	68.1 (+5%)	12,925
AuthRegistry:set_authorized	35.0	7,812
FPC:prepare_fee	117 (+5%)	15,062
Token:transfer_public	35.8 (-17%)	31,218
FPC:pay_refund	129 (+2%)	25,260
Benchmarking:increment_balance	1,528 (+15%)	15,267
Token:_increase_public_balance	⚠️ 62.9 (+320%)	15,006
FPC:pay_refund_with_shielded_rebate	113 (-29%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.150 (-1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.0 (+6%)	18.3 (+9%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.636 (+6%)	0.560 (+9%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	51.3 (+6%)	75.7	131	⚠️ 378 (+54%)	470
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.525 (+6%)	0.465	0.451	⚠️ 0.686 (+55%)	0.439
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	63.6 (+7%)	111	182	⚠️ 529 (+50%)	693
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.539 (+7%)	0.500	0.483	⚠️ 0.719 (+51%)	0.475
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	82.8 (+14%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.588 (+13%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	74,105	667,868

Transaction size based on fee payment method

| Metric | |
| - | |

github-actions · 2024-07-10T10:47:40Z

Changes to circuit sizes

Generated at commit: 079572f5c7daadb8e1025262b120037a6ff7a07e, compared to commit: 4355b3f3084696c54f6cd44aed7baf6f4caa925d

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_reset	+1,280 ❌	+1.20%	+1,664 ❌	+0.11%
private_kernel_reset_big	+640 ❌	+0.80%	+832 ❌	+0.07%
private_kernel_reset_medium	+320 ❌	+0.48%	+416 ❌	+0.04%
private_kernel_reset_small	+160 ❌	+0.27%	+208 ❌	+0.03%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_reset	108,194 (+1,280)	+1.20%	1,580,624 (+1,664)	+0.11%
private_kernel_reset_big	80,890 (+640)	+0.80%	1,148,376 (+832)	+0.07%
private_kernel_reset_medium	67,237 (+320)	+0.48%	932,251 (+416)	+0.04%
private_kernel_reset_small	60,410 (+160)	+0.27%	824,292 (+208)	+0.03%

sklppy88

👍

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.3</summary> ## [0.46.3](aztec-package-v0.46.2...aztec-package-v0.46.3) (2024-07-11) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.46.3</summary> ## [0.46.3](barretenberg.js-v0.46.2...barretenberg.js-v0.46.3) (2024-07-11) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.3</summary> ## [0.46.3](aztec-packages-v0.46.2...aztec-packages-v0.46.3) (2024-07-11) ### Features * Add CLI argument for debugging comptime blocks (noir-lang/noir#5192) ([97ecff5](97ecff5)) * Add reset tiny and optimize tail ([#7422](#7422)) ([399917b](399917b)) * **avm:** Calldatacopy and return gadget ([#7415](#7415)) ([ec39e4e](ec39e4e)), closes [#7381](#7381) [#7211](#7211) * **avm:** Make ProverPolynomials::get_row return references ([#7419](#7419)) ([108fc5f](108fc5f)) * Integrate new proving systems in e2e ([#6971](#6971)) ([723a0c1](723a0c1)) * Lsp rename/find-all-references for struct members (noir-lang/noir#5443) ([97ecff5](97ecff5)) * MSM sorting ([#7351](#7351)) ([5cbdc54](5cbdc54)) * **optimization:** Deduplicate more instructions (noir-lang/noir#5457) ([97ecff5](97ecff5)) * Prefix operator overload trait dispatch (noir-lang/noir#5423) ([97ecff5](97ecff5)) * Remove proof from L1 Rollup process ([#7347](#7347)) ([2645eab](2645eab)), closes [#7346](#7346) * Remove ram tables in note_getter ([#7434](#7434)) ([fd67da3](fd67da3)) * Sync from aztec-packages (noir-lang/noir#5467) ([97ecff5](97ecff5)) * Typing return values of embedded_curve_ops ([#7413](#7413)) ([db96077](db96077)) ### Bug Fixes * **avm:** Fixes AVM full tests and decrease timeout to 35 minutes ([#7438](#7438)) ([2a7494b](2a7494b)) * Memory init with no other ops gate counting ([#7427](#7427)) ([e7177ba](e7177ba)) * Pass secrets to ci-arm.yml ([#7436](#7436)) ([619501d](619501d)) * Remove compile-time error for invalid indices (noir-lang/noir#5466) ([97ecff5](97ecff5)) * Using different generators in private refund ([#7414](#7414)) ([59b92ca](59b92ca)), closes [#7320](#7320) ### Miscellaneous * **bb:** Fix double increment ([#7428](#7428)) ([7870a58](7870a58)) * **boxes:** Adding an init command for an empty project ([#7398](#7398)) ([a6a605d](a6a605d)) * Bump bb to 0.45.1 (noir-lang/noir#5469) ([97ecff5](97ecff5)) * Disable flaky cheat code test ([7b8c2ba](7b8c2ba)) * Document EmbeddedCurvePoint (noir-lang/noir#5468) ([97ecff5](97ecff5)) * Minimize usage of get_row in inverse computation ([#7431](#7431)) ([f177887](f177887)) * Private refund cleanup ([#7403](#7403)) ([ebec8ff](ebec8ff)) * Replace relative paths to noir-protocol-circuits ([842f6d1](842f6d1)) * Unbundle `check_array_is_initialized` (noir-lang/noir#5451) ([97ecff5](97ecff5)) </details> <details><summary>barretenberg: 0.46.3</summary> ## [0.46.3](barretenberg-v0.46.2...barretenberg-v0.46.3) (2024-07-11) ### Features * **avm:** Calldatacopy and return gadget ([#7415](#7415)) ([ec39e4e](ec39e4e)), closes [#7381](#7381) [#7211](#7211) * **avm:** Make ProverPolynomials::get_row return references ([#7419](#7419)) ([108fc5f](108fc5f)) * Integrate new proving systems in e2e ([#6971](#6971)) ([723a0c1](723a0c1)) * MSM sorting ([#7351](#7351)) ([5cbdc54](5cbdc54)) ### Bug Fixes * **avm:** Fixes AVM full tests and decrease timeout to 35 minutes ([#7438](#7438)) ([2a7494b](2a7494b)) * Memory init with no other ops gate counting ([#7427](#7427)) ([e7177ba](e7177ba)) ### Miscellaneous * **bb:** Fix double increment ([#7428](#7428)) ([7870a58](7870a58)) * Minimize usage of get_row in inverse computation ([#7431](#7431)) ([f177887](f177887)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.3</summary> ## [0.46.3](AztecProtocol/aztec-packages@aztec-package-v0.46.2...aztec-package-v0.46.3) (2024-07-11) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.46.3</summary> ## [0.46.3](AztecProtocol/aztec-packages@barretenberg.js-v0.46.2...barretenberg.js-v0.46.3) (2024-07-11) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.3</summary> ## [0.46.3](AztecProtocol/aztec-packages@aztec-packages-v0.46.2...aztec-packages-v0.46.3) (2024-07-11) ### Features * Add CLI argument for debugging comptime blocks (noir-lang/noir#5192) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Add reset tiny and optimize tail ([#7422](AztecProtocol/aztec-packages#7422)) ([399917b](AztecProtocol/aztec-packages@399917b)) * **avm:** Calldatacopy and return gadget ([#7415](AztecProtocol/aztec-packages#7415)) ([ec39e4e](AztecProtocol/aztec-packages@ec39e4e)), closes [#7381](AztecProtocol/aztec-packages#7381) [#7211](AztecProtocol/aztec-packages#7211) * **avm:** Make ProverPolynomials::get_row return references ([#7419](AztecProtocol/aztec-packages#7419)) ([108fc5f](AztecProtocol/aztec-packages@108fc5f)) * Integrate new proving systems in e2e ([#6971](AztecProtocol/aztec-packages#6971)) ([723a0c1](AztecProtocol/aztec-packages@723a0c1)) * Lsp rename/find-all-references for struct members (noir-lang/noir#5443) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * MSM sorting ([#7351](AztecProtocol/aztec-packages#7351)) ([5cbdc54](AztecProtocol/aztec-packages@5cbdc54)) * **optimization:** Deduplicate more instructions (noir-lang/noir#5457) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Prefix operator overload trait dispatch (noir-lang/noir#5423) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Remove proof from L1 Rollup process ([#7347](AztecProtocol/aztec-packages#7347)) ([2645eab](AztecProtocol/aztec-packages@2645eab)), closes [#7346](AztecProtocol/aztec-packages#7346) * Remove ram tables in note_getter ([#7434](AztecProtocol/aztec-packages#7434)) ([fd67da3](AztecProtocol/aztec-packages@fd67da3)) * Sync from aztec-packages (noir-lang/noir#5467) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Typing return values of embedded_curve_ops ([#7413](AztecProtocol/aztec-packages#7413)) ([db96077](AztecProtocol/aztec-packages@db96077)) ### Bug Fixes * **avm:** Fixes AVM full tests and decrease timeout to 35 minutes ([#7438](AztecProtocol/aztec-packages#7438)) ([2a7494b](AztecProtocol/aztec-packages@2a7494b)) * Memory init with no other ops gate counting ([#7427](AztecProtocol/aztec-packages#7427)) ([e7177ba](AztecProtocol/aztec-packages@e7177ba)) * Pass secrets to ci-arm.yml ([#7436](AztecProtocol/aztec-packages#7436)) ([619501d](AztecProtocol/aztec-packages@619501d)) * Remove compile-time error for invalid indices (noir-lang/noir#5466) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Using different generators in private refund ([#7414](AztecProtocol/aztec-packages#7414)) ([59b92ca](AztecProtocol/aztec-packages@59b92ca)), closes [#7320](AztecProtocol/aztec-packages#7320) ### Miscellaneous * **bb:** Fix double increment ([#7428](AztecProtocol/aztec-packages#7428)) ([7870a58](AztecProtocol/aztec-packages@7870a58)) * **boxes:** Adding an init command for an empty project ([#7398](AztecProtocol/aztec-packages#7398)) ([a6a605d](AztecProtocol/aztec-packages@a6a605d)) * Bump bb to 0.45.1 (noir-lang/noir#5469) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Disable flaky cheat code test ([7b8c2ba](AztecProtocol/aztec-packages@7b8c2ba)) * Document EmbeddedCurvePoint (noir-lang/noir#5468) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Minimize usage of get_row in inverse computation ([#7431](AztecProtocol/aztec-packages#7431)) ([f177887](AztecProtocol/aztec-packages@f177887)) * Private refund cleanup ([#7403](AztecProtocol/aztec-packages#7403)) ([ebec8ff](AztecProtocol/aztec-packages@ebec8ff)) * Replace relative paths to noir-protocol-circuits ([842f6d1](AztecProtocol/aztec-packages@842f6d1)) * Unbundle `check_array_is_initialized` (noir-lang/noir#5451) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) </details> <details><summary>barretenberg: 0.46.3</summary> ## [0.46.3](AztecProtocol/aztec-packages@barretenberg-v0.46.2...barretenberg-v0.46.3) (2024-07-11) ### Features * **avm:** Calldatacopy and return gadget ([#7415](AztecProtocol/aztec-packages#7415)) ([ec39e4e](AztecProtocol/aztec-packages@ec39e4e)), closes [#7381](AztecProtocol/aztec-packages#7381) [#7211](AztecProtocol/aztec-packages#7211) * **avm:** Make ProverPolynomials::get_row return references ([#7419](AztecProtocol/aztec-packages#7419)) ([108fc5f](AztecProtocol/aztec-packages@108fc5f)) * Integrate new proving systems in e2e ([#6971](AztecProtocol/aztec-packages#6971)) ([723a0c1](AztecProtocol/aztec-packages@723a0c1)) * MSM sorting ([#7351](AztecProtocol/aztec-packages#7351)) ([5cbdc54](AztecProtocol/aztec-packages@5cbdc54)) ### Bug Fixes * **avm:** Fixes AVM full tests and decrease timeout to 35 minutes ([#7438](AztecProtocol/aztec-packages#7438)) ([2a7494b](AztecProtocol/aztec-packages@2a7494b)) * Memory init with no other ops gate counting ([#7427](AztecProtocol/aztec-packages#7427)) ([e7177ba](AztecProtocol/aztec-packages@e7177ba)) ### Miscellaneous * **bb:** Fix double increment ([#7428](AztecProtocol/aztec-packages#7428)) ([7870a58](AztecProtocol/aztec-packages@7870a58)) * Minimize usage of get_row in inverse computation ([#7431](AztecProtocol/aztec-packages#7431)) ([f177887](AztecProtocol/aztec-packages@f177887)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

This was referenced Jul 9, 2024

refactor: replace usage of GrumpkinPoint with EmbeddedCurvePoint #7382

Merged

refactor: replace usage of GrumpkinPrivateKey with EmbeddedCurveScalar #7384

Merged

docs: making private refunds smooth-brain friendly #7343

Merged

benesjan force-pushed the 07-08-refactor_replace_usage_of_grumpkinprivatekey_with_embeddedcurvescalar branch from d4b98d8 to 7bc1885 Compare July 9, 2024 15:02

benesjan force-pushed the 07-09-refactor_private_refund_cleanup branch from 7f543e0 to dc2c9df Compare July 9, 2024 15:02

benesjan force-pushed the 07-08-refactor_replace_usage_of_grumpkinprivatekey_with_embeddedcurvescalar branch from 7bc1885 to eaa2761 Compare July 9, 2024 18:11

Base automatically changed from 07-08-refactor_replace_usage_of_grumpkinprivatekey_with_embeddedcurvescalar to master July 9, 2024 20:22

benesjan force-pushed the 07-09-refactor_private_refund_cleanup branch from dc2c9df to 521cfb6 Compare July 10, 2024 08:26

benesjan changed the base branch from master to 07-10-feat_typing_return_values_of_embedded_curve_ops July 10, 2024 08:26

benesjan mentioned this pull request Jul 10, 2024

feat: typing return values of embedded_curve_ops #7413

Merged

benesjan force-pushed the 07-10-feat_typing_return_values_of_embedded_curve_ops branch from 3189011 to 34ae0ac Compare July 10, 2024 08:47

benesjan force-pushed the 07-09-refactor_private_refund_cleanup branch from 521cfb6 to b456086 Compare July 10, 2024 08:47

benesjan marked this pull request as ready for review July 10, 2024 09:19

benesjan requested a review from LHerskind July 10, 2024 09:19

benesjan mentioned this pull request Jul 10, 2024

fix: using different generators in private refund #7414

Merged

benesjan force-pushed the 07-10-feat_typing_return_values_of_embedded_curve_ops branch from 34ae0ac to cfd491d Compare July 10, 2024 10:34

benesjan force-pushed the 07-09-refactor_private_refund_cleanup branch from b456086 to 7371f62 Compare July 10, 2024 10:34

Base automatically changed from 07-10-feat_typing_return_values_of_embedded_curve_ops to master July 10, 2024 13:50

benesjan added 6 commits July 10, 2024 13:53

refactor: private refund cleanup

21bb2e4

fix

c3ce548

comment

d6ec795

clarifying issues

ca848a4

checking logs

05381a1

commit

2502937

benesjan force-pushed the 07-09-refactor_private_refund_cleanup branch from 7371f62 to 2502937 Compare July 10, 2024 13:53

benesjan requested a review from sklppy88 July 10, 2024 13:55

benesjan enabled auto-merge (squash) July 10, 2024 14:06

benesjan mentioned this pull request Jul 10, 2024

fix: vulnerabilities in private refunds #7424

Closed

sklppy88 approved these changes Jul 10, 2024

View reviewed changes

benesjan merged commit ebec8ff into master Jul 10, 2024

benesjan deleted the 07-09-refactor_private_refund_cleanup branch July 10, 2024 14:38

AztecBot mentioned this pull request Jul 10, 2024

chore(master): Release 0.46.3 #7423

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: private refund cleanup#7403

refactor: private refund cleanup#7403
benesjan merged 6 commits intomasterfrom
07-09-refactor_private_refund_cleanup

benesjan commented Jul 9, 2024 •

edited

Loading

Uh oh!

benesjan commented Jul 9, 2024 •

edited

Loading

Uh oh!

AztecBot commented Jul 10, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

Uh oh!

github-actions bot commented Jul 10, 2024 •

edited

Loading

Uh oh!

sklppy88 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

benesjan commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benesjan commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AztecBot commented Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

Uh oh!

github-actions bot commented Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

Uh oh!

sklppy88 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

benesjan commented Jul 9, 2024 •

edited

Loading

benesjan commented Jul 9, 2024 •

edited

Loading

AztecBot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading