refactor: Optimize private call stack item hash for gate count by LHerskind · Pull Request #7285 · AztecProtocol/aztec-packages

LHerskind · 2024-07-02T16:19:09Z

In particular notice the costs around entrypoints 👀 50% reduction, cutting away 1 million constraints.

Tests passed in CI earlier, but I updated a big stack that seemed to kill it as it could not run 4 branches in CI for me at the same time :)

LHerskind · 2024-07-02T16:19:27Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on Graphite

AztecBot · 2024-07-02T16:58:46Z

Benchmark results

Metrics with a significant change:

app_circuit_witness_generation_time_in_ms (MultiCallEntrypoint:entrypoint): 920 (-20%)
app_circuit_witness_generation_time_in_ms (GasToken:deploy): 689 (-16%)
app_circuit_witness_generation_time_in_ms (SchnorrAccount:entrypoint): 1,275 (-21%)
protocol_circuit_simulation_time_in_ms (private-kernel-inner): 219 (-28%)
avm_simulation_time_ms (Token:mint_public): 487 (+953%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 54.7 (-70%)
app_circuit_proving_time_in_ms (SchnorrAccount:entrypoint): 26,760 (-49%)
app_circuit_size_in_gates (SchnorrAccount:entrypoint): 1,048,576 (-50%)
protocol_circuit_proving_time_in_ms (private-kernel-inner): 27,808 (-43%)
protocol_circuit_size_in_gates (private-kernel-inner): 1,048,576 (-50%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,532 (-3%)	1,509 (-2%)	702	729 (-3%)	765 (-1%)
proof_construction_time_sha256_30_ms	11,374 (-3%)	3,297 (+5%)	1,400	1,432	1,465
proof_construction_time_sha256_100_ms	42,393 (-3%)	11,474 (-2%)	5,397	5,410 (+1%)	5,328
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	57.0	88.0
proof_construction_time_poseidon_hash_30_ms	1,465 (-3%)	415	199	228 (+3%)	264
proof_construction_time_poseidon_hash_100_ms	5,552 (-3%)	1,514 (-3%)	718	755 (-2%)	792

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,464	9,472	9,464
l1_rollup_execution_gas	611,203	611,362	611,505
l2_block_processing_time_in_ms	746 (-2%)	1,410	2,649 (-3%)
l2_block_building_time_in_ms	20,153 (-3%)	41,218 (-1%)	78,575 (-4%)
l2_block_rollup_simulation_time_in_ms	20,152 (-3%)	41,218 (-1%)	78,574 (-4%)
l2_block_public_tx_process_time_in_ms	17,203 (-3%)	38,036 (-2%)	75,496 (-4%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,036	9,915 (+1%)
node_database_size_in_bytes	12,488,784	16,175,184
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	108 (+8%)	411 (+9%)	12,494 (-4%)	19,990 (+3%)	55,022 (+2%)	74,432 (+4%)	2,259 (+4%)	524,288
private-kernel-inner	⚠️ 219 (-28%)	790 (+7%)	⚠️ 27,808 (-43%)	82,090 (+2%)	55,022 (+2%)	74,432 (+4%)	2,259 (+4%)	⚠️ 1,048,576 (-50%)
private-kernel-tail	1,035 (-1%)	2,559 (+5%)	55,768 (+15%)	62,345 (+2%)	62,057	14,912	399	2,097,152
base-parity	6.14 (-3%)	1,549 (+3%)	2,653	128	64.0	2,208	2.00	131,072
root-parity	48.2 (-2%)	67.8	41,357 (-2%)	27,100	64.0	2,720	18.0	2,097,152
base-rollup	6,427 (-2%)	4,977 (+4%)	93,966 (+5%)	170,330	728	3,648	47.0	4,194,304
root-rollup	112 (+2%)	85.1 (+3%)	24,401 (+2%)	25,253	620	3,456	41.0	1,048,576
public-kernel-setup	534 (-2%)	2,447 (+3%)	42,306 (-1%)	102,121	80,278	106,912	3,274	2,097,152
public-kernel-app-logic	494 (-2%)	3,355 (+3%)	46,162 (+7%)	102,121	80,278	106,912	3,274	2,097,152
public-kernel-tail	1,121 (-2%)	27,129 (+1%)	181,650 (+2%)	399,014	10,014	14,912	399	8,388,608
private-kernel-reset-small	289 (+1%)	1,185 (+10%)	30,780 (+1%)	79,209 (+1%)	55,022 (+2%)	74,432 (+4%)	2,259 (+4%)	1,048,576
public-kernel-teardown	485 (-2%)	3,428 (+5%)	44,944 (+5%)	102,121	80,278	106,912	3,274	2,097,152
merge-rollup	29.0 (-1%)	N/A	N/A	16,486	728	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	8,993 (+7%)	58,163 (+14%)	N/A	N/A	106,912	3,274	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	9,364 (+7%)	390 (-1%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	9,364 (+7%)	24.3 (+1%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	9,364 (+7%)	⚠️ 920 (-20%)	N/A	N/A	N/A	N/A
GasToken:deploy	1,376	9,364 (+7%)	⚠️ 689 (-16%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	9,364 (+7%)	469 (-1%)	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	9,364 (+7%)	⚠️ 1,275 (-21%)	16,000 (+9%)	⚠️ 26,760 (-49%)	⚠️ 1,048,576 (-50%)	433 (+10%)
Token:privately_mint_private_note	1,280	9,364 (+7%)	654 (+8%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	9,364 (+7%)	232 (-7%)	16,000 (+9%)	10,957 (-2%)	524,288	433 (+10%)
Token:transfer	1,312	9,364 (+7%)	1,700 (-5%)	16,000 (+9%)	12,587	524,288	433 (+10%)
AuthRegistry:set_authorized (avm)	19,226	N/A	N/A	91,264	1,266 (-9%)	N/A	N/A
FPC:prepare_fee (avm)	26,668	N/A	N/A	91,328	2,670 (-7%)	N/A	N/A
Token:transfer_public (avm)	42,918	N/A	N/A	91,328	3,722 (-5%)	N/A	N/A
AuthRegistry:consume (avm)	33,104	N/A	N/A	91,264	2,773 (-6%)	N/A	N/A
FPC:pay_refund (avm)	36,833	N/A	N/A	91,296	23,721 (+2%)	N/A	N/A
Benchmarking:create_note	1,344	9,364 (+7%)	479 (+3%)	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	9,364 (+7%)	41.2 (+2%)	N/A	N/A	N/A	N/A
Token:unshield	1,376	9,364 (+7%)	1,392 (-5%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	9,364 (+7%)	1,854 (-7%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	66.3 (-8%)	13,790
GasToken:set_portal	13.0 (+6%)	3,339
Token:constructor	91.1 (-3%)	23,692
FPC:constructor	63.2 (+23%)	13,592
GasToken:mint_public	49.5 (-1%)	10,158
Token:mint_public	⚠️ 487 (+953%)	19,034
Token:assert_minter_and_mint	⚠️ 54.7 (-70%)	12,925
AuthRegistry:set_authorized	31.5 (+3%)	7,812
FPC:prepare_fee	110 (-4%)	15,062
Token:transfer_public	31.0 (-13%)	31,218
FPC:pay_refund	132 (-3%)	25,260
Benchmarking:increment_balance	2,152 (-2%)	15,267
Token:_increase_public_balance	62.5 (+8%)	15,006
FPC:pay_refund_with_shielded_rebate	124 (+2%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.155 (-3%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.3 (-1%)	16.6	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.596	0.510	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	47.7 (-1%)	75.1 (-1%)	128 (-4%)	244	458 (-3%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.487 (-1%)	0.462 (-1%)	0.440 (-3%)	0.443	0.427 (-3%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	58.6 (-1%)	110 (-2%)	177 (-4%)	353	673 (-3%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.495 (-1%)	0.493 (-1%)	0.470 (-4%)	0.477	0.461 (-3%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	72.0 (-1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.512 (-1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	74,057	667,841

Transaction size based on fee payment method

| Metric | |
| - | |

github-actions · 2024-07-03T18:45:26Z

Changes to circuit sizes

Generated at commit: fe6c86b653647037061ae4b5018eaa700027fd16, compared to commit: e431b6f64937e8fba357f890bdc3042adf17cb44

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_init_simulated	0 ➖	0.00%	+80 ❌	+3.69%
private_kernel_inner_simulated	0 ➖	0.00%	+80 ❌	+3.69%
private_kernel_reset_simulated	0 ➖	0.00%	+80 ❌	+3.69%
private_kernel_reset_simulated_big	0 ➖	0.00%	+80 ❌	+3.69%
private_kernel_reset_simulated_medium	0 ➖	0.00%	+80 ❌	+3.69%
private_kernel_reset_simulated_small	0 ➖	0.00%	+80 ❌	+3.69%
private_kernel_init	+1,240 ❌	+5.04%	+7,845 ❌	+2.10%
private_kernel_reset_small	+128 ❌	+0.21%	+12,887 ❌	+1.58%
private_kernel_reset_medium	+128 ❌	+0.18%	+12,887 ❌	+1.37%
private_kernel_reset_big	+128 ❌	+0.14%	+12,887 ❌	+1.09%
private_kernel_tail	+197 ❌	+0.93%	+13,057 ❌	+1.06%
private_kernel_tail_to_public	+197 ❌	+0.04%	+13,057 ❌	+0.78%
private_kernel_reset	+128 ❌	+0.10%	+12,887 ❌	+0.77%
private_kernel_inner	+1,840 ❌	+4.30%	-101,731 ✅	-8.86%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_init_simulated	1 (0)	0.00%	2,248 (+80)	+3.69%
private_kernel_inner_simulated	1 (0)	0.00%	2,248 (+80)	+3.69%
private_kernel_reset_simulated	1 (0)	0.00%	2,248 (+80)	+3.69%
private_kernel_reset_simulated_big	1 (0)	0.00%	2,248 (+80)	+3.69%
private_kernel_reset_simulated_medium	1 (0)	0.00%	2,248 (+80)	+3.69%
private_kernel_reset_simulated_small	1 (0)	0.00%	2,248 (+80)	+3.69%
private_kernel_init	25,831 (+1,240)	+5.04%	380,757 (+7,845)	+2.10%
private_kernel_reset_small	62,343 (+128)	+0.21%	828,946 (+12,887)	+1.58%
private_kernel_reset_medium	72,338 (+128)	+0.18%	952,765 (+12,887)	+1.37%
private_kernel_reset_big	92,327 (+128)	+0.14%	1,200,482 (+12,887)	+1.09%
private_kernel_tail	21,377 (+197)	+0.93%	1,246,443 (+13,057)	+1.06%
private_kernel_tail_to_public	444,595 (+197)	+0.04%	1,679,771 (+13,057)	+0.78%
private_kernel_reset	132,303 (+128)	+0.10%	1,695,914 (+12,887)	+0.77%
private_kernel_inner	44,605 (+1,840)	+4.30%	1,045,990 (-101,731)	-8.86%

benesjan · 2024-07-04T07:32:30Z

yarn-project/circuits.js/src/structs/private_call_stack_item.ts

   */
  public hash(): Fr {
-    return pedersenHash(this.toFields(), GeneratorIndex.CALL_STACK_ITEM);
+    const fields = [


Suggested change

const fields = [

// We don't need a hash of the entire private call stack item, just a few pieces.

// See Issue(#7092) for more details.

const fields = [

Would also include the comment here as it could be confusing.

benesjan

Looks good. But I think it would be nicer to wrap the hashed values in PrivateCallRequest struct as Leila proposed (which already exists, just needs to be modified).

Hashing just a few values out of the call stack item is not very nice code-quality-wise.

But can be done in another PR.

sirasistant · 2024-07-04T12:08:48Z

noir-projects/aztec-nr/aztec/src/context/private_context.nr

        }
        self.private_call_requests.push(
-            PrivateCallRequest { hash: item.hash(), caller_context, start_side_effect_counter, end_side_effect_counter }
+            PrivateCallRequest {


Could it make sense for the call_private_function oracle to return directly the items necessary for the PrivateCallRequest struct and we validate that? If the oracle returns a call stack item that is largely unconstrained somebody could modify the above code to trust the oracle response when only part of it is constrained (the items that end up in PrivateCallRequest). Previously it was constrained because the whole of it was hashed

But we are also getting return values and such from it. Think we might look at it in a separate go?

sirasistant

Looks good, we can tackle changing call_private_function_internal to return PrivateCallRequest in a followup PR.
This is necessary long term though to avoid exposing unconstrained witnesses to the private function that could mistakenly be used

Fixes #7092 for public, very similar to #7285. Introduces a `compressed` version of the `public_call_stack_item` that is what we will be hashing instead of the full inputs with most values populated by zeros. Notable savings is the SchnorrAccount entrypoint which is reduces all the way to 88K 👀

* master: (176 commits) refactor: counters (#7342) chore: notify Noir team on changes to the stdlib (#7387) chore(bb): do not instantiate Relation (#7389) chore(avm): avoid including flavor where possible (#7361) chore(avm): better log_derivative_inverse_round (#7360) chore(avm): smaller prover (#7359) chore(avm): smaller transcript (#7357) feat: Sync from noir (#7352) feat: VK tree (#6914) chore(docs): Update token tutorial (#7241) chore: sync external contributions (#6984) fix: privacy leak in private refund (#7358) fix: included argshash computation in public call_interfaces and cleanup (#7354) docs: making private refunds smooth-brain friendly (#7343) refactor: optimize public call stack item hashing (#7330) fix: Allow importing notes from other contracts and inject them in the macros (#7349) refactor: Optimize private call stack item hash for gate count (#7285) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits ...

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.0</summary> ## [0.46.0](aztec-package-v0.45.1...aztec-package-v0.46.0) (2024-07-09) ### Features * VK tree ([#6914](#6914)) ([8631237](8631237)) </details> <details><summary>barretenberg.js: 0.46.0</summary> ## [0.46.0](barretenberg.js-v0.45.1...barretenberg.js-v0.46.0) (2024-07-09) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.0</summary> ## [0.46.0](aztec-packages-v0.45.1...aztec-packages-v0.46.0) (2024-07-09) ### ⚠ BREAKING CHANGES * constant inputs for blackbox ([#7222](#7222)) ### Features * Add more slice methods to the stdlib (noir-lang/noir#5424) ([6137a10](6137a10)) * Constant inputs for blackbox ([#7222](#7222)) ([9f9ded2](9f9ded2)) * Detect subgraphs that are completely independent from inputs or outputs (noir-lang/noir#5402) ([c7b1ae4](c7b1ae4)) * Lsp "go to definition" for modules (noir-lang/noir#5406) ([c7b1ae4](c7b1ae4)) * Lsp rename/find-all-references for traits (noir-lang/noir#5409) ([c7b1ae4](c7b1ae4)) * Lsp rename/find-all-references for type aliases (noir-lang/noir#5414) ([6137a10](6137a10)) * Sync from aztec-packages (noir-lang/noir#5408) ([c7b1ae4](c7b1ae4)) * Sync from aztec-packages (noir-lang/noir#5432) ([6137a10](6137a10)) * TXE docs and usability ([#7305](#7305)) ([6b2a351](6b2a351)) * Unquote multiple items from annotations (noir-lang/noir#5441) ([6137a10](6137a10)) * VK tree ([#6914](#6914)) ([8631237](8631237)) ### Bug Fixes * Allow importing notes from other contracts and inject them in the macros ([#7349](#7349)) ([586c0b0](586c0b0)) * Change panic to error in interpreter (noir-lang/noir#5446) ([6137a10](6137a10)) * Complete call stacks with no_predicates (noir-lang/noir#5418) ([c7b1ae4](c7b1ae4)) * Correct range for overlfowing/underflowing integer assignment (noir-lang/noir#5416) ([c7b1ae4](c7b1ae4)) * Included argshash computation in public call_interfaces and cleanup ([#7354](#7354)) ([13e9b94](13e9b94)) * Lsp find struct reference in return locations and paths (noir-lang/noir#5404) ([c7b1ae4](c7b1ae4)) * Lsp struct rename/reference difference (noir-lang/noir#5411) ([6137a10](6137a10)) * Privacy leak in private refund ([#7358](#7358)) ([e05f6f0](e05f6f0)), closes [#7321](#7321) ### Miscellaneous * Add remaining slice methods to the interpreter (noir-lang/noir#5422) ([c7b1ae4](c7b1ae4)) * Add test and benchmarks for poseidon2 (noir-lang/noir#5386) ([c7b1ae4](c7b1ae4)) * **avm:** Avoid including flavor where possible ([#7361](#7361)) ([dbdffd6](dbdffd6)) * **avm:** Better log_derivative_inverse_round ([#7360](#7360)) ([6329833](6329833)) * **avm:** Smaller prover ([#7359](#7359)) ([7d8c833](7d8c833)) * **avm:** Smaller transcript ([#7357](#7357)) ([3952a44](3952a44)) * **bb:** Do not instantiate Relation ([#7389](#7389)) ([d9cbf4c](d9cbf4c)) * Counters ([#7342](#7342)) ([819f370](819f370)) * **docs:** Fix link to docker ([#7395](#7395)) ([ad4a401](ad4a401)) * **docs:** Update token tutorial ([#7241](#7241)) ([0414eb5](0414eb5)) * Dummy workflow (noir-lang/noir#5438) ([6137a10](6137a10)) * Extracts refactoring of reading error payloads from [#5403](#5403) (noir-lang/noir#5413) ([6137a10](6137a10)) * Generate declaration files for VKs ([#7391](#7391)) ([7c96636](7c96636)) * Merge `BarretenbergVerifierBackend` and `BarretenbergBackend` (noir-lang/noir#5399) ([6137a10](6137a10)) * Move SSA checks to a new folder (noir-lang/noir#5434) ([6137a10](6137a10)) * Notify Noir team on changes to the stdlib ([#7387](#7387)) ([061aac3](061aac3)) * Optimize private call stack item hash for gate count ([#7285](#7285)) ([783d9b6](783d9b6)) * Optimize public call stack item hashing ([#7330](#7330)) ([4a5093c](4a5093c)) * Refactor logic around inlining `no_predicates` functions (noir-lang/noir#5433) ([6137a10](6137a10)) * Replace relative paths to noir-protocol-circuits ([8510269](8510269)) * Replace relative paths to noir-protocol-circuits ([9eb8d1c](9eb8d1c)) * Sync external contributions ([#6984](#6984)) ([a265b29](a265b29)) ### Documentation * Making private refunds smooth-brain friendly ([#7343](#7343)) ([533c937](533c937)) * Update overview.md (fix link text) ([#7344](#7344)) ([79e5856](79e5856)) </details> <details><summary>barretenberg: 0.46.0</summary> ## [0.46.0](barretenberg-v0.45.1...barretenberg-v0.46.0) (2024-07-09) ### ⚠ BREAKING CHANGES * constant inputs for blackbox ([#7222](#7222)) ### Features * Constant inputs for blackbox ([#7222](#7222)) ([9f9ded2](9f9ded2)) ### Miscellaneous * **avm:** Avoid including flavor where possible ([#7361](#7361)) ([dbdffd6](dbdffd6)) * **avm:** Better log_derivative_inverse_round ([#7360](#7360)) ([6329833](6329833)) * **avm:** Smaller prover ([#7359](#7359)) ([7d8c833](7d8c833)) * **avm:** Smaller transcript ([#7357](#7357)) ([3952a44](3952a44)) * **bb:** Do not instantiate Relation ([#7389](#7389)) ([d9cbf4c](d9cbf4c)) * Counters ([#7342](#7342)) ([819f370](819f370)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.0</summary> ## [0.46.0](AztecProtocol/aztec-packages@aztec-package-v0.45.1...aztec-package-v0.46.0) (2024-07-09) ### Features * VK tree ([#6914](AztecProtocol/aztec-packages#6914)) ([8631237](AztecProtocol/aztec-packages@8631237)) </details> <details><summary>barretenberg.js: 0.46.0</summary> ## [0.46.0](AztecProtocol/aztec-packages@barretenberg.js-v0.45.1...barretenberg.js-v0.46.0) (2024-07-09) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.0</summary> ## [0.46.0](AztecProtocol/aztec-packages@aztec-packages-v0.45.1...aztec-packages-v0.46.0) (2024-07-09) ### ⚠ BREAKING CHANGES * constant inputs for blackbox ([#7222](AztecProtocol/aztec-packages#7222)) ### Features * Add more slice methods to the stdlib (noir-lang/noir#5424) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Constant inputs for blackbox ([#7222](AztecProtocol/aztec-packages#7222)) ([9f9ded2](AztecProtocol/aztec-packages@9f9ded2)) * Detect subgraphs that are completely independent from inputs or outputs (noir-lang/noir#5402) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Lsp "go to definition" for modules (noir-lang/noir#5406) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Lsp rename/find-all-references for traits (noir-lang/noir#5409) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Lsp rename/find-all-references for type aliases (noir-lang/noir#5414) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Sync from aztec-packages (noir-lang/noir#5408) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Sync from aztec-packages (noir-lang/noir#5432) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * TXE docs and usability ([#7305](AztecProtocol/aztec-packages#7305)) ([6b2a351](AztecProtocol/aztec-packages@6b2a351)) * Unquote multiple items from annotations (noir-lang/noir#5441) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * VK tree ([#6914](AztecProtocol/aztec-packages#6914)) ([8631237](AztecProtocol/aztec-packages@8631237)) ### Bug Fixes * Allow importing notes from other contracts and inject them in the macros ([#7349](AztecProtocol/aztec-packages#7349)) ([586c0b0](AztecProtocol/aztec-packages@586c0b0)) * Change panic to error in interpreter (noir-lang/noir#5446) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Complete call stacks with no_predicates (noir-lang/noir#5418) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Correct range for overlfowing/underflowing integer assignment (noir-lang/noir#5416) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Included argshash computation in public call_interfaces and cleanup ([#7354](AztecProtocol/aztec-packages#7354)) ([13e9b94](AztecProtocol/aztec-packages@13e9b94)) * Lsp find struct reference in return locations and paths (noir-lang/noir#5404) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Lsp struct rename/reference difference (noir-lang/noir#5411) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Privacy leak in private refund ([#7358](AztecProtocol/aztec-packages#7358)) ([e05f6f0](AztecProtocol/aztec-packages@e05f6f0)), closes [#7321](AztecProtocol/aztec-packages#7321) ### Miscellaneous * Add remaining slice methods to the interpreter (noir-lang/noir#5422) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Add test and benchmarks for poseidon2 (noir-lang/noir#5386) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * **avm:** Avoid including flavor where possible ([#7361](AztecProtocol/aztec-packages#7361)) ([dbdffd6](AztecProtocol/aztec-packages@dbdffd6)) * **avm:** Better log_derivative_inverse_round ([#7360](AztecProtocol/aztec-packages#7360)) ([6329833](AztecProtocol/aztec-packages@6329833)) * **avm:** Smaller prover ([#7359](AztecProtocol/aztec-packages#7359)) ([7d8c833](AztecProtocol/aztec-packages@7d8c833)) * **avm:** Smaller transcript ([#7357](AztecProtocol/aztec-packages#7357)) ([3952a44](AztecProtocol/aztec-packages@3952a44)) * **bb:** Do not instantiate Relation ([#7389](AztecProtocol/aztec-packages#7389)) ([d9cbf4c](AztecProtocol/aztec-packages@d9cbf4c)) * Counters ([#7342](AztecProtocol/aztec-packages#7342)) ([819f370](AztecProtocol/aztec-packages@819f370)) * **docs:** Fix link to docker ([#7395](AztecProtocol/aztec-packages#7395)) ([ad4a401](AztecProtocol/aztec-packages@ad4a401)) * **docs:** Update token tutorial ([#7241](AztecProtocol/aztec-packages#7241)) ([0414eb5](AztecProtocol/aztec-packages@0414eb5)) * Dummy workflow (noir-lang/noir#5438) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Extracts refactoring of reading error payloads from [#5403](AztecProtocol/aztec-packages#5403) (noir-lang/noir#5413) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Generate declaration files for VKs ([#7391](AztecProtocol/aztec-packages#7391)) ([7c96636](AztecProtocol/aztec-packages@7c96636)) * Merge `BarretenbergVerifierBackend` and `BarretenbergBackend` (noir-lang/noir#5399) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Move SSA checks to a new folder (noir-lang/noir#5434) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Notify Noir team on changes to the stdlib ([#7387](AztecProtocol/aztec-packages#7387)) ([061aac3](AztecProtocol/aztec-packages@061aac3)) * Optimize private call stack item hash for gate count ([#7285](AztecProtocol/aztec-packages#7285)) ([783d9b6](AztecProtocol/aztec-packages@783d9b6)) * Optimize public call stack item hashing ([#7330](AztecProtocol/aztec-packages#7330)) ([4a5093c](AztecProtocol/aztec-packages@4a5093c)) * Refactor logic around inlining `no_predicates` functions (noir-lang/noir#5433) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Replace relative paths to noir-protocol-circuits ([8510269](AztecProtocol/aztec-packages@8510269)) * Replace relative paths to noir-protocol-circuits ([9eb8d1c](AztecProtocol/aztec-packages@9eb8d1c)) * Sync external contributions ([#6984](AztecProtocol/aztec-packages#6984)) ([a265b29](AztecProtocol/aztec-packages@a265b29)) ### Documentation * Making private refunds smooth-brain friendly ([#7343](AztecProtocol/aztec-packages#7343)) ([533c937](AztecProtocol/aztec-packages@533c937)) * Update overview.md (fix link text) ([#7344](AztecProtocol/aztec-packages#7344)) ([79e5856](AztecProtocol/aztec-packages@79e5856)) </details> <details><summary>barretenberg: 0.46.0</summary> ## [0.46.0](AztecProtocol/aztec-packages@barretenberg-v0.45.1...barretenberg-v0.46.0) (2024-07-09) ### ⚠ BREAKING CHANGES * constant inputs for blackbox ([#7222](AztecProtocol/aztec-packages#7222)) ### Features * Constant inputs for blackbox ([#7222](AztecProtocol/aztec-packages#7222)) ([9f9ded2](AztecProtocol/aztec-packages@9f9ded2)) ### Miscellaneous * **avm:** Avoid including flavor where possible ([#7361](AztecProtocol/aztec-packages#7361)) ([dbdffd6](AztecProtocol/aztec-packages@dbdffd6)) * **avm:** Better log_derivative_inverse_round ([#7360](AztecProtocol/aztec-packages#7360)) ([6329833](AztecProtocol/aztec-packages@6329833)) * **avm:** Smaller prover ([#7359](AztecProtocol/aztec-packages#7359)) ([7d8c833](AztecProtocol/aztec-packages@7d8c833)) * **avm:** Smaller transcript ([#7357](AztecProtocol/aztec-packages#7357)) ([3952a44](AztecProtocol/aztec-packages@3952a44)) * **bb:** Do not instantiate Relation ([#7389](AztecProtocol/aztec-packages#7389)) ([d9cbf4c](AztecProtocol/aztec-packages@d9cbf4c)) * Counters ([#7342](AztecProtocol/aztec-packages#7342)) ([819f370](AztecProtocol/aztec-packages@819f370)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

LHerskind mentioned this pull request Jul 2, 2024

refactor: ARGS_HASH constants 64 -> 16 #7284

Merged

LHerskind linked an issue Jul 2, 2024 that may be closed by this pull request

Reduce constraint count of a function call #7092

Closed

LHerskind mentioned this pull request Jul 2, 2024

refactor: showcase recursion case for transfer #7271

Closed

LHerskind force-pushed the lh/argshash-reduction branch 3 times, most recently from 921718c to fdc5bde Compare July 3, 2024 16:27

LHerskind force-pushed the lh/private-call-stack-item-hash branch from fea148c to 752252f Compare July 3, 2024 18:38

LHerskind marked this pull request as ready for review July 3, 2024 19:23

LHerskind requested review from benesjan and sirasistant July 3, 2024 19:23

LHerskind force-pushed the lh/argshash-reduction branch from fdc5bde to c27ae79 Compare July 3, 2024 19:33

LHerskind force-pushed the lh/private-call-stack-item-hash branch from 752252f to da132ed Compare July 3, 2024 19:33

LHerskind mentioned this pull request Jul 3, 2024

Reduce constraint count of a function call #7092

Closed

LHerskind force-pushed the lh/argshash-reduction branch from c27ae79 to fa9c94d Compare July 3, 2024 22:44

LHerskind force-pushed the lh/private-call-stack-item-hash branch from da132ed to 9ed5785 Compare July 3, 2024 22:44

LHerskind mentioned this pull request Jul 3, 2024

refactor: optimize public call stack item hashing #7330

Merged

benesjan reviewed Jul 4, 2024

View reviewed changes

benesjan approved these changes Jul 4, 2024

View reviewed changes

Base automatically changed from lh/argshash-reduction to master July 4, 2024 08:47

LHerskind force-pushed the lh/private-call-stack-item-hash branch 2 times, most recently from bdecd38 to d6f6ec0 Compare July 4, 2024 11:13

sirasistant reviewed Jul 4, 2024

View reviewed changes

LHerskind requested a review from benesjan July 4, 2024 14:04

LHerskind added 2 commits July 4, 2024 14:21

refactor: Optimize private call stack item hash for gate count

3038fac

refactor: update PrivateCallRequest

58566d7

LHerskind force-pushed the lh/private-call-stack-item-hash branch from d6f6ec0 to 58566d7 Compare July 4, 2024 14:39

sirasistant approved these changes Jul 5, 2024

View reviewed changes

LHerskind merged commit 783d9b6 into master Jul 5, 2024

LHerskind deleted the lh/private-call-stack-item-hash branch July 5, 2024 08:30

AztecBot mentioned this pull request Jul 4, 2024

chore(master): Release 0.46.0 #7345

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Optimize private call stack item hash for gate count#7285

refactor: Optimize private call stack item hash for gate count#7285
LHerskind merged 2 commits intomasterfrom
lh/private-call-stack-item-hash

LHerskind commented Jul 2, 2024 •

edited

Loading

Uh oh!

LHerskind commented Jul 2, 2024 •

edited

Loading

Uh oh!

AztecBot commented Jul 2, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

Uh oh!

github-actions bot commented Jul 3, 2024 •

edited

Loading

Uh oh!

benesjan Jul 4, 2024 •

edited

Loading

Uh oh!

benesjan left a comment •

edited

Loading

Uh oh!

sirasistant Jul 4, 2024 •

edited

Loading

Uh oh!

LHerskind Jul 4, 2024

Uh oh!

sirasistant left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

LHerskind commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LHerskind commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AztecBot commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

Uh oh!

github-actions bot commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

Uh oh!

benesjan Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benesjan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sirasistant Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LHerskind Jul 4, 2024

Choose a reason for hiding this comment

Uh oh!

sirasistant left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LHerskind commented Jul 2, 2024 •

edited

Loading

LHerskind commented Jul 2, 2024 •

edited

Loading

AztecBot commented Jul 2, 2024 •

edited

Loading

github-actions bot commented Jul 3, 2024 •

edited

Loading

benesjan Jul 4, 2024 •

edited

Loading

benesjan left a comment •

edited

Loading

sirasistant Jul 4, 2024 •

edited

Loading